Fisheye on dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c https://devapps.diality.us/changelog/~br%3DDEN-14101-sw-s82-mg-DIAL-179-DIAL-184/dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeChemicalDisinfect.c dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Code review changes Wed, 21 Dec 2022 18:32:44 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=30b88046bfac18be0a31693840562a961866eb07 https://devapps.diality.us/changelog/dgfirmware?cs=30b88046bfac18be0a31693840562a961866eb07 Steve Jarpe <sjarpe@diality.com> committed 30b8804 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. Code review changes

· /firmware/App/Modes/ModeChemicalDisinfect.c (-35, +34) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-10, +10) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 21 Dec 2022 15:02:37 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=81769c6bea6ed32d70698fb03ad5823de1814b27 https://devapps.diality.us/changelog/dgfirmware?cs=81769c6bea6ed32d70698fb03ad5823de1814b27 Dara Navaei committed 81769c6 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFault.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-2, +2) | History | Source | Diff
… 12 more files in changeset.
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merged staging Wed, 21 Dec 2022 14:30:37 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=eceb190a5d66fdbee779478ac8bb50a846ed9241 https://devapps.diality.us/changelog/dgfirmware?cs=eceb190a5d66fdbee779478ac8bb50a846ed9241 Dara Navaei committed eceb190 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware Merged staging

· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-67, +186) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-1302, +856) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-0, +1073) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-10, +69) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-4, +7) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-4, +63) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-3, +4) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +11) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-8, +13) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-1, +4) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-5, +25) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-36, +288) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +21) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 21 Dec 2022 13:40:14 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=3d977e037c170a3ad8870738215830d41713b00b https://devapps.diality.us/changelog/dgfirmware?cs=3d977e037c170a3ad8870738215830d41713b00b Dara Navaei committed 3d977e0 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-5, +5) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.h (-5, +5) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Code review changes. Tue, 20 Dec 2022 18:54:21 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=352a720124edcbbc0c58856c2d23ddf32e558c02 https://devapps.diality.us/changelog/dgfirmware?cs=352a720124edcbbc0c58856c2d23ddf32e558c02 Steve Jarpe <sjarpe@diality.com> committed 352a720 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. Code review changes.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-9, +3) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-9, +8) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): /DEN-14316-chemical-disinfect. Code review changes Tue, 20 Dec 2022 17:18:56 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=daf4763d6f40baf4cbc2f9d88aba7d9faf588ad6 https://devapps.diality.us/changelog/dgfirmware?cs=daf4763d6f40baf4cbc2f9d88aba7d9faf588ad6 Steve Jarpe <sjarpe@diality.com> committed daf4763 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware /DEN-14316-chemical-disinfect. Code review changes

· /firmware/App/Modes/ModeChemicalDisinfect.c (-21, +5) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-18, +4) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-7, +12) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14307: Addressed code review comments. Tue, 20 Dec 2022 16:11:36 -0800 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=335d28f954aed9522d5cc71863cd8dc253070758 https://devapps.diality.us/changelog/dgfirmware?cs=335d28f954aed9522d5cc71863cd8dc253070758 Sean Nash committed 335d28f on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14307: Addressed code review comments.

· /firmware/App/Controllers/ConcentratePumps.h (-0, +3) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFault.h (-3, +0) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-5, +5) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-6, +6) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/ModeService.c (-2, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316: Addressed code review comments. Tue, 20 Dec 2022 13:58:29 -0800 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=9f01014483a2ec46a19bdb7ce7ab97b007f83cbd https://devapps.diality.us/changelog/dgfirmware?cs=9f01014483a2ec46a19bdb7ce7ab97b007f83cbd Sean Nash committed 9f01014 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316: Addressed code review comments.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-2, +3) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-4, +0) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Merged code walkthrough changes and my code review changes. Tue, 20 Dec 2022 12:44:54 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=2bb8d48b499b9124aa983b5d952b5a261f6efed7 https://devapps.diality.us/changelog/dgfirmware?cs=2bb8d48b499b9124aa983b5d952b5a261f6efed7 Steve Jarpe <sjarpe@diality.com> committed 2bb8d48 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. Merged code walkthrough changes and my code review changes.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-33, +34) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-33, +31) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.h (-2, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-3, +3) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Changes for code review Tue, 20 Dec 2022 11:01:54 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=3f19c30ddaa6677778f7e74447cfcdbcfe4cd77e https://devapps.diality.us/changelog/dgfirmware?cs=3f19c30ddaa6677778f7e74447cfcdbcfe4cd77e Steve Jarpe <sjarpe@diality.com> committed 3f19c30 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. Changes for code review

· /firmware/App/Modes/ModeChemicalDisinfect.c (-35, +40) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-25, +24) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.h (-1, +17) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-0, +1) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316: Replaced tabs with 4 spaces per code review. Tue, 20 Dec 2022 09:40:54 -0800 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=7e5cd9476b197f4ef32bdcf37ba9d37a8d8afc70 https://devapps.diality.us/changelog/dgfirmware?cs=7e5cd9476b197f4ef32bdcf37ba9d37a8d8afc70 Sean Nash committed 7e5cd94 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316: Replaced tabs with 4 spaces per code review.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-31, +31) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14307: Use new park option when stopping concentrate pumps. Mon, 19 Dec 2022 08:35:08 -0800 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=d48e02f028dbd430bedda41be0173fbfc45116d7 https://devapps.diality.us/changelog/dgfirmware?cs=d48e02f028dbd430bedda41be0173fbfc45116d7 Sean Nash committed d48e02f on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14307: Use new park option when stopping concentrate pumps.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-5, +3) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-5, +6) | History | Source | Diff
· /firmware/App/Modes/ModeFault.h (-1, +4) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-6, +4) | History | Source | Diff
· /firmware/App/Modes/ModeService.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14307: Added support for parking concentrate pumps. Fri, 16 Dec 2022 16:52:32 -0800 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=eae0635792a827b7cf9197cf6f6e253f2a094260 https://devapps.diality.us/changelog/dgfirmware?cs=eae0635792a827b7cf9197cf6f6e253f2a094260 Sean Nash committed eae0635 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14307: Added support for parking concentrate pumps.

· /firmware/App/Controllers/ConcentratePumps.c (-14, +252) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +12) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-5, +5) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-6, +6) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-4, +153) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-1, +10) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +12) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +90) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +10) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): /DEN-14316-chemical-disinfect. Address code review. Changes due to debugging and testing. Thu, 15 Dec 2022 12:36:00 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=efc7f297febee73bf520b4c5646e49c8f53caf41 https://devapps.diality.us/changelog/dgfirmware?cs=efc7f297febee73bf520b4c5646e49c8f53caf41 Steve Jarpe <sjarpe@diality.com> committed efc7f29 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware /DEN-14316-chemical-disinfect. Address code review. Changes due to debugging and testing.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-367, +420) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-275, +225) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-2, +1) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. This is a testing version. It is not yet complete. Tue, 06 Dec 2022 15:21:39 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=6127d594f1673bd75ffe7be22eec69a2f39e025d https://devapps.diality.us/changelog/dgfirmware?cs=6127d594f1673bd75ffe7be22eec69a2f39e025d Steve Jarpe <sjarpe@diality.com> committed 6127d59 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. This is a testing version. It is not yet complete.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-272, +470) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-64, +66) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-731, +667) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14307 updated the usage info records in the NV data management Thu, 01 Dec 2022 09:37:57 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=1e34d32fcfac88792ed72e55953dee721bacd9d5 https://devapps.diality.us/changelog/dgfirmware?cs=1e34d32fcfac88792ed72e55953dee721bacd9d5 Dara Navaei committed 1e34d32 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14307 updated the usage info records in the NV data management

· /firmware/App/Modes/ModeChemicalDisinfect.c (-27, +20) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-3, +32) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-61, +54) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-0, +23) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-6, +0) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-6, +2) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Debugging ModeChemicalDisinfect and ModeChemicalDisinfectFlush. Added messaging, etc. supp... Wed, 30 Nov 2022 02:54:45 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=e82ddb85a3b3a1fc5d591d8cca0d006597fd94cf https://devapps.diality.us/changelog/dgfirmware?cs=e82ddb85a3b3a1fc5d591d8cca0d006597fd94cf Steve Jarpe <sjarpe@diality.com> committed e82ddb8 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. Debugging ModeChemicalDisinfect and ModeChemicalDisinfectFlush. Added messaging, etc. support for ModeChemicalDisinfectFlush.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-157, +142) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-78, +80) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.h (-2, +14) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-667, +731) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-0, +58) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-1, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +3) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +35) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +4) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14307 work in progress updated heat disinfect Sat, 19 Nov 2022 22:11:41 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=224f096c4d255526eccba9aaa13e36e0e7499f14 https://devapps.diality.us/changelog/dgfirmware?cs=224f096c4d255526eccba9aaa13e36e0e7499f14 Dara Navaei committed 224f096 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14307 work in progress updated heat disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-11, +11) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-39, +44) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Implemntation snapshot. Fri, 18 Nov 2022 15:12:26 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=d8686d68bf29761ee329fc638264d2e60a5191c0 https://devapps.diality.us/changelog/dgfirmware?cs=d8686d68bf29761ee329fc638264d2e60a5191c0 Steve Jarpe <sjarpe@diality.com> committed d8686d6 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. Implemntation snapshot.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-323, +207) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-7, +1121) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-0, +1) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316. Initial modifications of ModeChemicalDisinfect.c for new chem disinfect process. Some new states have been ad... Tue, 15 Nov 2022 10:36:46 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=3fae8c2aab5873ccfaf8b7e1e4a2abf78216a7fd https://devapps.diality.us/changelog/dgfirmware?cs=3fae8c2aab5873ccfaf8b7e1e4a2abf78216a7fd Steve Jarpe <sjarpe@diality.com> committed 3fae8c2 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316. Initial modifications of ModeChemicalDisinfect.c for new chem disinfect process. Some new states have been added but not fully implmemented and are currently not active

· /firmware/App/Modes/ModeChemicalDisinfect.c (-1038, +485) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 26 Oct 2022 14:32:16 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=19934ca6e36e2dcabd6a6083a9a1f15b1ed32189 https://devapps.diality.us/changelog/dgfirmware?cs=19934ca6e36e2dcabd6a6083a9a1f15b1ed32189 Dara Navaei committed 19934ca on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 185 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Heaters.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13786 Code review changes Mon, 24 Oct 2022 14:59:26 -0700 Bill Bracken <bill@criticalsoftwaresolutions.com> https://devapps.diality.us/changelog/dgfirmware?cs=5715610ce2215c16d162ea368f6f46e59226786e https://devapps.diality.us/changelog/dgfirmware?cs=5715610ce2215c16d162ea368f6f46e59226786e Bill Bracken <bill@criticalsoftwaresolutions.com> committed 5715610 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 186 more in dgfirmware DEN-13786 Code review changes

· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-1, +0) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13786 Code review changes Mon, 24 Oct 2022 14:48:58 -0700 Bill Bracken <bill@criticalsoftwaresolutions.com> https://devapps.diality.us/changelog/dgfirmware?cs=b7c391c953dad63a6704e292f7b82a00dac64a73 https://devapps.diality.us/changelog/dgfirmware?cs=b7c391c953dad63a6704e292f7b82a00dac64a73 Bill Bracken <bill@criticalsoftwaresolutions.com> committed b7c391c on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 186 more in dgfirmware DEN-13786 Code review changes

· /firmware/App/Controllers/ROPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-1, +2) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-53, +5) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 18 Oct 2022 18:05:20 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=0c296cef29037819be204c45a23d4d38a52b2718 https://devapps.diality.us/changelog/dgfirmware?cs=0c296cef29037819be204c45a23d4d38a52b2718 Dara Navaei committed 0c296ce on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 188 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Pressures.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Switches.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
… 25 more files in changeset.
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13834 merged staging Tue, 27 Sep 2022 21:08:56 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=2e21405574597474db0ebae86cdd7fa2d517f71c https://devapps.diality.us/changelog/dgfirmware?cs=2e21405574597474db0ebae86cdd7fa2d517f71c Dara Navaei committed 2e21405 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 188 more in dgfirmware DEN-13834 merged staging

· /firmware/App/Controllers/DrainPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-0, +16) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-0, +16) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-55, +62) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-7, +7) | History | Source | Diff
· /firmware/App/Controllers/Pressures.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-16, +25) | History | Source | Diff
· /firmware/App/Controllers/Voltages.c (-1, +3) | History | Source | Diff
· /firmware/App/Controllers/Voltages.h (-2, +2) | History | Source | Diff
· /firmware/App/DGCommon.h (-2, +2) | History | Source | Diff
… 16 more files in changeset.
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 22 Sep 2022 16:48:10 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=256d5cb05f1ef09e19e2f2733a111f600c73a7ee https://devapps.diality.us/changelog/dgfirmware?cs=256d5cb05f1ef09e19e2f2733a111f600c73a7ee Dara Navaei committed 256d5cb on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 189 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DialysateFlow.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-0, +16) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-0, +16) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Pressures.h (-1, +1) | History | Source | Diff
… 38 more files in changeset.
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13834, DEN-13691, DEN-13685, DEN-13064, DEN-9693, DEN-13778, Updated the flow sensors driver by fixing the override ... Sun, 18 Sep 2022 15:08:46 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=8074ecece0b11532c173ad951a98036f0c54ca52 https://devapps.diality.us/changelog/dgfirmware?cs=8074ecece0b11532c173ad951a98036f0c54ca52 Dara Navaei committed 8074ece on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 188 more in dgfirmware DEN-13834, DEN-13691, DEN-13685, DEN-13064, DEN-9693, DEN-13778, Updated the flow sensors driver by fixing the override functions. Removed the old RO flow functions and anywhere that they were used. Replaced the VRD valve with a reserved space

· /firmware/App/Controllers/FlowSensors.c (-0, +15) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-4, +10) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-129, +6) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-6, +0) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.c (-2, +3) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-5, +29) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-2, +3) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-9, +13) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-1, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-8, +0) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-33, +0) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-3, +0) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13834 updated the getValveState function to return the state of the valve in enum. Updated the treatment blocking da... Wed, 14 Sep 2022 20:36:37 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=cb4d35cc50df2d3cc9e828cd92e53cf456ca9b9d https://devapps.diality.us/changelog/dgfirmware?cs=cb4d35cc50df2d3cc9e828cd92e53cf456ca9b9d Dara Navaei committed cb4d35c on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 188 more in dgfirmware DEN-13834 updated the getValveState function to return the state of the valve in enum. Updated the treatment blocking data to be written to NV data. Updated the FlowSensors driver and renamed the dialysate flow messages to flow sensors messages

· /firmware/App/Controllers/FlowSensors.c (-16, +15) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-7, +14) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-13, +48) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-28, +27) | History | Source | Diff
· /firmware/App/DGCommon.h (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-25, +57) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-31, +59) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-74, +0) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-27, +21) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-5, +6) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-25, +60) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-6, +6) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13460: Fixed bug DEN-13777. Mon, 29 Aug 2022 13:10:45 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=9c8b132dfff7ad0ef4973698e14d673b9d72a92b https://devapps.diality.us/changelog/dgfirmware?cs=9c8b132dfff7ad0ef4973698e14d673b9d72a92b Sean Nash committed 9c8b132 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 190 more in dgfirmware DEN-13460: Fixed bug DEN-13777.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13460 merged staging Fri, 26 Aug 2022 09:17:35 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=261cfc6d93996e76e26c1e9c3f5740077ad2ec22 https://devapps.diality.us/changelog/dgfirmware?cs=261cfc6d93996e76e26c1e9c3f5740077ad2ec22 Dara Navaei committed 261cfc6 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 190 more in dgfirmware DEN-13460 merged staging

· /firmware/App/Controllers/ConductivitySensors.c (-9, +10) | History | Source | Diff
· /firmware/App/Controllers/DialysateFlow.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-4, +4) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-2, +3) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-3, +3) | History | Source | Diff
· /firmware/App/DGCommon.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-34, +35) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-38, +73) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-46, +50) | History | Source | Diff
]]>