Fisheye on dgfirmware/firmware/App/Modes/ModeChemicalDisinfectFlush.c https://devapps.diality.us/changelog/~br%3DDEN-14101-sw-s82-mg-DIAL-179-DIAL-184/dgfirmware/firmware/App/Modes/ModeChemicalDisinfectFlush.c Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeChemicalDisinfectFlush.c dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Code review changes Wed, 21 Dec 2022 18:32:44 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=30b88046bfac18be0a31693840562a961866eb07 https://devapps.diality.us/changelog/dgfirmware?cs=30b88046bfac18be0a31693840562a961866eb07 Steve Jarpe <sjarpe@diality.com> committed 30b8804 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. Code review changes

· /firmware/App/Modes/ModeChemicalDisinfect.c (-35, +34) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-10, +10) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 21 Dec 2022 15:02:37 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=81769c6bea6ed32d70698fb03ad5823de1814b27 https://devapps.diality.us/changelog/dgfirmware?cs=81769c6bea6ed32d70698fb03ad5823de1814b27 Dara Navaei committed 81769c6 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFault.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-2, +2) | History | Source | Diff
… 12 more files in changeset.
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merged staging Wed, 21 Dec 2022 14:30:37 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=eceb190a5d66fdbee779478ac8bb50a846ed9241 https://devapps.diality.us/changelog/dgfirmware?cs=eceb190a5d66fdbee779478ac8bb50a846ed9241 Dara Navaei committed eceb190 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware Merged staging

· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-67, +186) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-1302, +856) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-0, +1073) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-10, +69) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-4, +7) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-4, +63) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-3, +4) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +11) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-8, +13) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-1, +4) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-5, +25) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-36, +288) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +21) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 21 Dec 2022 13:40:14 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=3d977e037c170a3ad8870738215830d41713b00b https://devapps.diality.us/changelog/dgfirmware?cs=3d977e037c170a3ad8870738215830d41713b00b Dara Navaei committed 3d977e0 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-5, +5) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.h (-5, +5) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316: Addressed code review comments. Wed, 21 Dec 2022 12:52:56 -0800 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=523e9d316c136beb71aa533a15099b1f81f7e886 https://devapps.diality.us/changelog/dgfirmware?cs=523e9d316c136beb71aa533a15099b1f81f7e886 Sean Nash committed 523e9d3 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316: Addressed code review comments.

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-5, +6) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Code review changes. Tue, 20 Dec 2022 18:54:21 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=352a720124edcbbc0c58856c2d23ddf32e558c02 https://devapps.diality.us/changelog/dgfirmware?cs=352a720124edcbbc0c58856c2d23ddf32e558c02 Steve Jarpe <sjarpe@diality.com> committed 352a720 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. Code review changes.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-9, +3) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-9, +8) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): /DEN-14316-chemical-disinfect. Code review changes Tue, 20 Dec 2022 17:18:56 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=daf4763d6f40baf4cbc2f9d88aba7d9faf588ad6 https://devapps.diality.us/changelog/dgfirmware?cs=daf4763d6f40baf4cbc2f9d88aba7d9faf588ad6 Steve Jarpe <sjarpe@diality.com> committed daf4763 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware /DEN-14316-chemical-disinfect. Code review changes

· /firmware/App/Modes/ModeChemicalDisinfect.c (-21, +5) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-18, +4) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-7, +12) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316: Addressed code review comments. Tue, 20 Dec 2022 13:58:29 -0800 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=9f01014483a2ec46a19bdb7ce7ab97b007f83cbd https://devapps.diality.us/changelog/dgfirmware?cs=9f01014483a2ec46a19bdb7ce7ab97b007f83cbd Sean Nash committed 9f01014 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316: Addressed code review comments.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-2, +3) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-4, +0) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Merged code walkthrough changes and my code review changes. Tue, 20 Dec 2022 12:44:54 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=2bb8d48b499b9124aa983b5d952b5a261f6efed7 https://devapps.diality.us/changelog/dgfirmware?cs=2bb8d48b499b9124aa983b5d952b5a261f6efed7 Steve Jarpe <sjarpe@diality.com> committed 2bb8d48 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. Merged code walkthrough changes and my code review changes.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-33, +34) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-33, +31) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.h (-2, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-3, +3) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Changes for code review Tue, 20 Dec 2022 11:01:54 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=3f19c30ddaa6677778f7e74447cfcdbcfe4cd77e https://devapps.diality.us/changelog/dgfirmware?cs=3f19c30ddaa6677778f7e74447cfcdbcfe4cd77e Steve Jarpe <sjarpe@diality.com> committed 3f19c30 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. Changes for code review

· /firmware/App/Modes/ModeChemicalDisinfect.c (-35, +40) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-25, +24) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.h (-1, +17) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-0, +1) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316: Replaced tabs with 4 spaces per code review. Tue, 20 Dec 2022 09:58:03 -0800 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=d63cef4dd53596502b928a1c13cd2a7431ef1336 https://devapps.diality.us/changelog/dgfirmware?cs=d63cef4dd53596502b928a1c13cd2a7431ef1336 Sean Nash committed d63cef4 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316: Replaced tabs with 4 spaces per code review.

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-32, +32) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): /DEN-14316-chemical-disinfect. Address code review. Changes due to debugging and testing. Thu, 15 Dec 2022 12:36:00 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=efc7f297febee73bf520b4c5646e49c8f53caf41 https://devapps.diality.us/changelog/dgfirmware?cs=efc7f297febee73bf520b4c5646e49c8f53caf41 Steve Jarpe <sjarpe@diality.com> committed efc7f29 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware /DEN-14316-chemical-disinfect. Address code review. Changes due to debugging and testing.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-367, +420) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-275, +225) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-2, +1) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. This is a testing version. It is not yet complete. Tue, 06 Dec 2022 15:21:39 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=6127d594f1673bd75ffe7be22eec69a2f39e025d https://devapps.diality.us/changelog/dgfirmware?cs=6127d594f1673bd75ffe7be22eec69a2f39e025d Steve Jarpe <sjarpe@diality.com> committed 6127d59 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. This is a testing version. It is not yet complete.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-272, +470) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-64, +66) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-731, +667) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Debugging ModeChemicalDisinfect and ModeChemicalDisinfectFlush. Added messaging, etc. supp... Wed, 30 Nov 2022 02:54:45 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=e82ddb85a3b3a1fc5d591d8cca0d006597fd94cf https://devapps.diality.us/changelog/dgfirmware?cs=e82ddb85a3b3a1fc5d591d8cca0d006597fd94cf Steve Jarpe <sjarpe@diality.com> committed e82ddb8 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. Debugging ModeChemicalDisinfect and ModeChemicalDisinfectFlush. Added messaging, etc. support for ModeChemicalDisinfectFlush.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-157, +142) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-78, +80) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.h (-2, +14) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-667, +731) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-0, +58) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-1, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +3) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +35) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +4) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316-chemical-disinfect. Implemntation snapshot. Fri, 18 Nov 2022 15:12:26 -0800 Steve Jarpe <sjarpe@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=d8686d68bf29761ee329fc638264d2e60a5191c0 https://devapps.diality.us/changelog/dgfirmware?cs=d8686d68bf29761ee329fc638264d2e60a5191c0 Steve Jarpe <sjarpe@diality.com> committed d8686d6 on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316-chemical-disinfect. Implemntation snapshot.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-323, +207) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-7, +1121) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-0, +1) | History | Source | Diff
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14316 initial commit of ModeChemicalDisinfectFlush mode Tue, 15 Nov 2022 11:08:40 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=12d64de03890be512d1ccaca5d258710f3de99bb https://devapps.diality.us/changelog/dgfirmware?cs=12d64de03890be512d1ccaca5d258710f3de99bb Dara Navaei committed 12d64de on branch master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 176 more in dgfirmware DEN-14316 initial commit of ModeChemicalDisinfectFlush mode

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-0, +24) | History | Source
· /firmware/App/Modes/ModeChemicalDisinfectFlush.h (-0, +24) | History | Source
· /firmware/App/Modes/OperationModes.c (-12, +20) | History | Source | Diff
]]>