Fisheye on hdfirmware/firmware

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 addressed a code review comment

Dara Navaei — Thu, 10 Nov 2022 10:27:12 -0800

Dara Navaei committed 54ef95c on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 addressed a code review comment

· /firmware/App/Services/FPGA.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-1, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 addressed the code review comments. Updated the reservoir switch command in pre treatment and added the getHWC...

Dara Navaei — Wed, 09 Nov 2022 13:25:12 -0800

Dara Navaei committed a9368b2 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 addressed the code review comments. Updated the reservoir switch command in pre treatment and added the getHWConfig function in FPGA

· /firmware/App/Modes/ModePreTreat.c	(-2, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-6, +10)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-1, +4)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-14175-dg_hd_dev-hd_dg_dvt-update-part-5

Dara Navaei — Wed, 09 Nov 2022 12:56:56 -0800

Dara Navaei committed fae0fd5 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

Merge branch 'staging' into DEN-14175-dg_hd_dev-hd_dg_dvt-update-part-5

· /firmware/App/Controllers/SyringePump.c	(-4, +126)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-7, +17)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 removed a blank line

Dara Navaei — Wed, 09 Nov 2022 12:56:39 -0800

Dara Navaei committed ccdc42e on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 removed a blank line

· /firmware/App/Controllers/PresOccl.c

(-1, +0)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Tue, 08 Nov 2022 14:22:25 -0800

Dara Navaei committed 0b6cb1c on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 08 Nov 2022 14:22:18 -0800

Dara Navaei committed e482c96 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/SyringePump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-14170-sw_dev_sprint_82_darren' into staging

Tue, 08 Nov 2022 14:19:29 -0800

Darren Cox committed 66c6285 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

Merge branch 'DEN-14170-sw_dev_sprint_82_darren' into staging

· /firmware/App/Controllers/SyringePump.c	(-2, +124)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-5, +15)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14170 Code review comment update for if/else condition.

Tue, 08 Nov 2022 11:59:56 -0800

Darren Cox committed a5ed2e6 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-14170 Code review comment update for if/else condition.

· /firmware/App/Controllers/SyringePump.c

(-14, +14)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14170 Remove check for Syringe in Preload request. Preload function does this test and sets alarm properly.

Mon, 07 Nov 2022 18:25:08 -0800

Darren Cox committed abd31ef on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-14170 Remove check for Syringe in Preload request. Preload function does this test and sets alarm properly.

· /firmware/App/Controllers/SyringePump.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 merged staging and resolved the conflicts

Dara Navaei — Mon, 07 Nov 2022 10:52:41 -0800

Dara Navaei committed 427b37a on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 merged staging and resolved the conflicts

· /firmware/App/Controllers/DGInterface.c	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-3, +14)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-48, +155)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-76, +217)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 addressed the code review comments

Dara Navaei — Mon, 07 Nov 2022 10:34:26 -0800

Dara Navaei committed 2b81130 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 addressed the code review comments

· /firmware/App/Modes/ModePreTreat.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-2, +3)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14170 Updated for code review comments.

Fri, 04 Nov 2022 15:27:59 -0700

Darren Cox committed c5bb512 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-14170 Updated for code review comments.

· /firmware/App/Controllers/SyringePump.c	(-22, +24)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 replaced the V3 flag with FPGA hardware check and added the default the fixed valves PWM count in FPGA

Dara Navaei — Thu, 03 Nov 2022 16:00:14 -0700

Dara Navaei committed d9b4581 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 replaced the V3 flag with FPGA hardware check and added the default the fixed valves PWM count in FPGA

· /firmware/App/Controllers/Valves.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-1, +9)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14170 Fix TODO with new fault.

Thu, 03 Nov 2022 13:39:23 -0700

Darren Cox committed 6cec0f4 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-14170 Fix TODO with new fault.

· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 addressed code review comments

Dara Navaei — Thu, 03 Nov 2022 09:53:03 -0700

Dara Navaei committed 3cd6c27 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 addressed code review comments

· /firmware/App/Controllers/BloodLeak.c

(-10, +0)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 updated the reservoir switch command to send the trimmer use the previous duty cycle or estimate the duty cycl...

Dara Navaei — Thu, 03 Nov 2022 09:45:28 -0700

Dara Navaei committed ef398e6 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 updated the reservoir switch command to send the trimmer use the previous duty cycle or estimate the duty cycle

· /firmware/App/Controllers/DGInterface.c	(-3, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-2, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-5, +20)	\| History	\| Source	\| Diff
· /firmware/App/Modes/PreTreatmentRecirc.c	(-1, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-2, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-1, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14170 Remove TODO, no longer relevant.

Wed, 02 Nov 2022 17:16:09 -0700

Darren Cox committed 1cc7e8c on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-14170 Remove TODO, no longer relevant.

· /firmware/App/Controllers/SyringePump.c

(-1, +0)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175: Added f/w support for alarm dialog blood stopped countdown while in rinseback state per DEN-10791.

Sean Nash — Wed, 02 Nov 2022 08:51:08 -0700

Sean Nash committed aae7692 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175: Added f/w support for alarm dialog blood stopped countdown while in rinseback state per DEN-10791.

· /firmware/App/Modes/Rinseback.c

(-0, +15)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175: Additional fix to syringe pump DAC write issue.

Sean Nash — Tue, 01 Nov 2022 19:19:48 -0700

Sean Nash committed cf7f4d1 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175: Additional fix to syringe pump DAC write issue.

· /firmware/App/Controllers/SyringePump.c

(-1, +4)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175: Stop syringe pump on transition to fault mode only. Continuous stopping of pump was preventing DAC write on ...

Sean Nash — Tue, 01 Nov 2022 18:19:25 -0700

Sean Nash committed b07452c on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175: Stop syringe pump on transition to fault mode only. Continuous stopping of pump was preventing DAC write on force sensor check failure. DEN-14254.

· /firmware/App/Modes/ModeFault.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14175 implemented the FGPA hardware configuration register, changed the trimmer heater start/stop command to HD comm...

Dara Navaei — Tue, 01 Nov 2022 14:43:34 -0700

Dara Navaei committed 9d81efe on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

DEN-14175 implemented the FGPA hardware configuration register, changed the trimmer heater start/stop command to HD command and not the log in command. Added a command to benign the polynomial calibration values of the temperature sensors

· /firmware/App/Controllers/Fans.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Temperatures.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-2, +15)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Fri, 28 Oct 2022 15:15:57 -0700

Dara Navaei committed 8d76ac5 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 28 Oct 2022 15:15:50 -0700

Dara Navaei committed b31eee6 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 305 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DGInterface.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-13801: cosmetic code review changes.

Michael Garthwaite — Fri, 28 Oct 2022 13:29:46 -0700

Michael Garthwaite committed 66f77cd on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-13801: cosmetic code review changes.

· /firmware/App/Modes/ModePreTreat.c	(-26, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-7, +6)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-13801: reverted priming changes to explicitly set active reservoir.

Michael Garthwaite — Fri, 28 Oct 2022 12:05:30 -0700

Michael Garthwaite committed 1c17c97 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-13801: reverted priming changes to explicitly set active reservoir.

· /firmware/App/Modes/Prime.c

(-2, +5)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-13801: fixed getpretreatmentfillvolume missing brackets for conditional statements.

Michael Garthwaite — Fri, 28 Oct 2022 08:31:47 -0700

Michael Garthwaite committed d3ec548 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-13801: fixed getpretreatmentfillvolume missing brackets for conditional statements.

· /firmware/App/Modes/ModePreTreat.c

(-0, +4)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-13801: fixed rsvr mgmt causing r2 to fill to 700 instead of 1300.

Michael Garthwaite — Thu, 27 Oct 2022 17:09:00 -0700

Michael Garthwaite committed 5195e22 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-13801: fixed rsvr mgmt causing r2 to fill to 700 instead of 1300.

· /firmware/App/Modes/Prime.c

(-5, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-13801: forced start rsvr mgmt to have res 2 as active. Changed prime max time to 30 minutes. Moved signalactiontores...

Michael Garthwaite — Thu, 27 Oct 2022 16:26:14 -0700

Michael Garthwaite committed 1d49abd on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-13801: forced start rsvr mgmt to have res 2 as active. Changed prime max time to 30 minutes. Moved signalactiontoresumefill() to be executed when dry self tests are disabled. Fixed wet self tests stalling in state 3.

· /firmware/App/Modes/ModePreTreat.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-6, +13)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-13801: removed unnecessary cmdsetactive reservoirs in reservoir management. initialized flushed status flags.

Michael Garthwaite — Thu, 27 Oct 2022 13:51:40 -0700

Michael Garthwaite committed aebdf67 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-13801: removed unnecessary cmdsetactive reservoirs in reservoir management. initialized flushed status flags.

· /firmware/App/Modes/ModePreTreat.c

(-3, +6)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-13801: added new switch reservoir request state to pretreatment reservoir management to prevent switches from failin...

Michael Garthwaite — Thu, 27 Oct 2022 10:34:34 -0700

Michael Garthwaite committed fb7b901 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 306 more in hdfirmware

DEN-13801: added new switch reservoir request state to pretreatment reservoir management to prevent switches from failing

· /firmware/App/Modes/ModePreTreat.c

(-7, +58)

| History

| Source

| Diff