Fisheye on hdfirmware/

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14458 addressed a code review comment

Dara Navaei — Wed, 14 Dec 2022 13:20:52 -0800

Dara Navaei committed 7889dc8 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14458 addressed a code review comment

· /firmware/App/Modes/SelfTests.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14458 addressed the code review comments

Dara Navaei — Wed, 14 Dec 2022 11:48:44 -0800

Dara Navaei committed 7350aa8 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14458 addressed the code review comments

· /firmware/App/Controllers/BloodFlow.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-6, +6)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14458 cleaned up the code

Dara Navaei — Wed, 14 Dec 2022 09:31:53 -0800

Dara Navaei committed 5c2c248 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14458 cleaned up the code

· /firmware/App/Modes/SelfTests.c

(-37, +11)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14458 updated the air trap's broadcast interval

Dara Navaei — Tue, 13 Dec 2022 15:13:11 -0800

Dara Navaei committed 5e2f6fd on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14458 updated the air trap's broadcast interval

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14458 cleaned up the code and removed the commented lines

Dara Navaei — Tue, 13 Dec 2022 14:19:10 -0800

Dara Navaei committed 80abfe8 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14458 cleaned up the code and removed the commented lines

· /firmware/App/Modes/SelfTests.c

(-99, +63)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14464 updated a code with a possible fix to make sure the active reservoir starts with 1500 mL upon transitioning to...

Dara Navaei — Tue, 13 Dec 2022 10:59:43 -0800

Dara Navaei committed 19aba08 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14464 updated a code with a possible fix to make sure the active reservoir starts with 1500 mL upon transitioning to treatment from pretreatment

· /firmware/App/Modes/ModePreTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-10, +12)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14470 updated the dry self test to be able to command the fill in pretreatment if the syringe pump is enabled

Dara Navaei — Tue, 13 Dec 2022 09:09:40 -0800

Dara Navaei committed a5c69f5 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14470 updated the dry self test to be able to command the fill in pretreatment if the syringe pump is enabled

· /firmware/App/Modes/SelfTests.c

(-0, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14458 lowered the self tests' target fill volume

Dara Navaei — Mon, 12 Dec 2022 15:11:48 -0800

Dara Navaei committed f125389 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14458 lowered the self tests' target fill volume

· /firmware/App/Modes/ModePreTreat.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14417 reversed the direction of the reservoirs' displacement in the second displacement in the wet self test

Dara Navaei — Mon, 12 Dec 2022 15:07:00 -0800

Dara Navaei committed f2ea5cc on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14417 reversed the direction of the reservoirs' displacement in the second displacement in the wet self test

· /firmware/App/Modes/SelfTests.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14458 updated the wet self test events payload

Dara Navaei — Fri, 09 Dec 2022 15:59:39 -0800

Dara Navaei committed 6b74d8f on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14458 updated the wet self test events payload

· /firmware/App/Modes/SelfTests.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14259 added an extra check prior to triggering the dialin, dialout, blood pumps speed alarm

Dara Navaei — Fri, 09 Dec 2022 14:38:55 -0800

Dara Navaei committed 68ee5d1 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14259 added an extra check prior to triggering the dialin, dialout, blood pumps speed alarm

· /firmware/App/Controllers/BloodFlow.c	(-2, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +4)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14464 changed the fill targets in pre-treatment to 1100 mL and changed the directions of the reservoir's fill from R...

Dara Navaei — Fri, 09 Dec 2022 14:12:46 -0800

Dara Navaei committed 3f047e8 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14464 changed the fill targets in pre-treatment to 1100 mL and changed the directions of the reservoir's fill from R1 to R2 to R2 to R1 in the wet self tests second displacement

· /firmware/App/Modes/ModePreTreat.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14458 fixed the post treatment reservoir management

Dara Navaei — Thu, 08 Dec 2022 16:07:30 -0800

Dara Navaei committed e760277 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14458 fixed the post treatment reservoir management

· /firmware/App/Modes/ModePostTreat.c

(-14, +8)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14458 updated the code

Dara Navaei — Thu, 08 Dec 2022 10:22:52 -0800

Dara Navaei committed 5573c69 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14458 updated the code

· /firmware/App/Modes/SelfTests.c

(-18, +7)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14458, DEN-14417 updated the wet self test displacement check

Dara Navaei — Thu, 08 Dec 2022 09:41:22 -0800

Dara Navaei committed abcf0f0 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14458, DEN-14417 updated the wet self test displacement check

· /firmware/App/Modes/SelfTests.c

(-23, +78)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14458: Cosmetic changes to rotor hall sensor signal handling.

Sean Nash — Thu, 08 Dec 2022 09:05:18 -0800

Sean Nash committed 46b0fc6 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14458: Cosmetic changes to rotor hall sensor signal handling.

· /firmware/App/Controllers/BloodFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-9, +7)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14458 updated the post treatment reservoir management

Dara Navaei — Wed, 07 Dec 2022 17:04:30 -0800

Dara Navaei committed 269317d on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

DEN-14458 updated the post treatment reservoir management

· /firmware/App/Modes/ModePostTreat.c

(-21, +52)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Mon, 05 Dec 2022 14:34:30 -0800

Dara Navaei committed e35a80f on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 05 Dec 2022 14:34:22 -0800

Dara Navaei committed 14c1c80 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialInFlow.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-14344-sw-s85-mg-dpi-pwmflow-fix' into staging

Michael Garthwaite — Mon, 05 Dec 2022 14:27:09 -0800

Michael Garthwaite committed 94d066f on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 300 more in hdfirmware

Merge branch 'DEN-14344-sw-s85-mg-dpi-pwmflow-fix' into staging

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-14344-sw-s85-mg-dpi-pwmflow-fix

Michael Garthwaite — Mon, 05 Dec 2022 14:26:45 -0800

Michael Garthwaite committed 659245d on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 301 more in hdfirmware

Merge branch 'staging' into DEN-14344-sw-s85-mg-dpi-pwmflow-fix

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Mon, 05 Dec 2022 14:05:35 -0800

Dara Navaei committed 1d3cd10 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 301 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 05 Dec 2022 14:05:25 -0800

Dara Navaei committed 5ce2656 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 301 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DGInterface.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14344: Addressed code review comments.

Sean Nash — Mon, 05 Dec 2022 13:59:07 -0800

Sean Nash committed decd87e on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 301 more in hdfirmware

DEN-14344: Addressed code review comments.

· /firmware/App/Controllers/DialInFlow.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14344: code review comments.

Michael Garthwaite — Fri, 02 Dec 2022 17:01:26 -0800

Michael Garthwaite committed 6483eb0 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 301 more in hdfirmware

DEN-14344: code review comments.

· /firmware/App/Controllers/DialInFlow.c	(-16, +15)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN_14252: Addressed code review comment.

Sean Nash — Fri, 02 Dec 2022 16:36:01 -0800

Sean Nash committed ba53065 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 302 more in hdfirmware

DEN_14252: Addressed code review comment.

· /firmware/App/Modes/Prime.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14252: Another fix to pre-tx reservor mgmt state machine.

Sean Nash — Fri, 02 Dec 2022 14:14:42 -0800

Sean Nash committed 71ecc11 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 302 more in hdfirmware

DEN-14252: Another fix to pre-tx reservor mgmt state machine.

· /firmware/App/Modes/ModePreTreat.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14252: Additional fix to reservoir mgmt state machine.

Sean Nash — Fri, 02 Dec 2022 12:03:44 -0800

Sean Nash committed 80b0182 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 302 more in hdfirmware

DEN-14252: Additional fix to reservoir mgmt state machine.

· /firmware/App/Modes/ModePreTreat.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14252 updated the getDGCommandResponse to not set the command ID to none until the command is done

Dara Navaei — Fri, 02 Dec 2022 09:32:55 -0800

Dara Navaei committed c49c52c on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 302 more in hdfirmware

DEN-14252 updated the getDGCommandResponse to not set the command ID to none until the command is done

· /firmware/App/Controllers/DGInterface.c

(-1, +0)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14252 updated the pretreatment reservoirs state change condition and added the HD load cels events

Dara Navaei — Thu, 01 Dec 2022 18:13:19 -0800

Dara Navaei committed 11fcffb on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 302 more in hdfirmware

DEN-14252 updated the pretreatment reservoirs state change condition and added the HD load cels events

· /firmware/App/Modes/Dialysis.c	(-4, +9)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-1, +4)	\| History	\| Source	\| Diff