Fisheye on hdfirmware/firmware

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14830: fixed alarm mgmt faulting on clear.

Michael Garthwaite — Fri, 07 Apr 2023 11:19:13 -0700

Michael Garthwaite committed bdfb263 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more in hdfirmware

DEN-14830: fixed alarm mgmt faulting on clear.

· /firmware/App/Services/AlarmMgmt.c

(-2, +4)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14830: Fixed alarm mgmt not clearing alarm ids under 30. Fixed Dial temps

Michael Garthwaite — Thu, 06 Apr 2023 14:22:58 -0700

Michael Garthwaite committed 9baf80d on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more in hdfirmware

DEN-14830: Fixed alarm mgmt not clearing alarm ids under 30. Fixed Dial temps

· /firmware/App/Controllers/DGInterface.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14830: fixes

Michael Garthwaite — Thu, 06 Apr 2023 13:53:42 -0700

Michael Garthwaite committed 3840d6e on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more in hdfirmware

DEN-14830: fixes

· /firmware/App/Controllers/DGInterface.c

(-8, +5)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14830: simplifying temperature control logic.

Michael Garthwaite — Thu, 06 Apr 2023 13:50:57 -0700

Michael Garthwaite committed 42bb206 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more in hdfirmware

DEN-14830: simplifying temperature control logic.

· /firmware/App/Controllers/DGInterface.c

(-37, +4)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14830: compiler fixes.

Michael Garthwaite — Wed, 05 Apr 2023 13:13:58 -0700

Michael Garthwaite committed dc25111 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more in hdfirmware

DEN-14830: compiler fixes.

· /firmware/App/Controllers/DGInterface.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14830: Reworked dialysate temperature logic so persistence triggers do not cancel each other out. Fixed air pump not...

Michael Garthwaite — Wed, 05 Apr 2023 13:11:58 -0700

Michael Garthwaite committed b204cbc on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more in hdfirmware

DEN-14830: Reworked dialysate temperature logic so persistence triggers do not cancel each other out. Fixed air pump not turning off when dry self tests are user stopped.

· /firmware/App/Controllers/DGInterface.c	(-10, +36)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-0, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14830: removed 2 dialysate temperature alarms.

Michael Garthwaite — Tue, 04 Apr 2023 17:26:59 -0700

Michael Garthwaite committed f748628 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more in hdfirmware

DEN-14830: removed 2 dialysate temperature alarms.

· /firmware/App/Controllers/DGInterface.c

(-20, +19)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14830: PRS alignments

Michael Garthwaite — Tue, 04 Apr 2023 16:03:52 -0700

Michael Garthwaite committed 80fcb3e on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more in hdfirmware

DEN-14830: PRS alignments

· /firmware/App/Controllers/DGInterface.c

(-9, +5)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-14830-incorrect-dialysate-temperature-alarm-triggered

Michael Garthwaite — Tue, 04 Apr 2023 15:43:30 -0700

Michael Garthwaite committed 78e44d1 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more in hdfirmware

Merge branch 'staging' into DEN-14830-incorrect-dialysate-temperature-alarm-triggered

· /firmware/App/Controllers/DGInterface.c

(-5, +26)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Fri, 31 Mar 2023 19:30:45 -0700

Dara Navaei committed eb466df on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 31 Mar 2023 19:30:32 -0700

Dara Navaei committed 25ede6f on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DialInFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DialOutFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/PresOccl.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/SyringePump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreTreat.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatmentParams.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/Rinseback.c

(-1, +1)

| History

| Source

| Diff

… 6 more files in changeset.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999: merged staging

Dara Navaei — Fri, 31 Mar 2023 19:13:42 -0700

Dara Navaei committed 46b16ef on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999: merged staging

· /firmware/App/Controllers/PresOccl.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-4, +4)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999: Additional fix to DEN-14850.

Sean Nash — Fri, 31 Mar 2023 15:19:37 -0700

Sean Nash committed 36937bf on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999: Additional fix to DEN-14850.

· /firmware/App/Services/AlarmMgmt.c

(-3, +8)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Fri, 31 Mar 2023 15:14:50 -0700

Dara Navaei committed a6987b7 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 31 Mar 2023 15:14:43 -0700

Dara Navaei committed b5339d5 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Fri, 31 Mar 2023 11:06:34 -0700

Dara Navaei committed e1b5415 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 252 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 31 Mar 2023 11:06:26 -0700

Dara Navaei committed 6f0304b on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 252 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge DEN-14860 to staging

Fri, 31 Mar 2023 11:04:36 -0700

Darren Cox committed 8dc2d20 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 252 more in hdfirmware

Merge DEN-14860 to staging

· /firmware/App/Modes/SelfTests.c	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-57, +96)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen...

Fri, 31 Mar 2023 08:58:46 -0700

James Walter Taylor committed c1ea1dc on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 252 more in hdfirmware

HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Closing code review comments.

· /firmware/App/Services/SystemComm.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999: Small fix to HD WD POST.

Sean Nash — Thu, 30 Mar 2023 21:19:37 -0700

Sean Nash committed 7ed5254 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999: Small fix to HD WD POST.

· /firmware/App/Services/WatchdogMgmt.c

(-0, +5)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999: Removed BP and DPi flow range checks.

Sean Nash — Thu, 30 Mar 2023 20:49:20 -0700

Sean Nash committed 52412b5 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999: Removed BP and DPi flow range checks.

· /firmware/App/Controllers/BloodFlow.c	(-30, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-17, +3)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999: Removed redundant trigger for DG restarted alarm.

Sean Nash — Thu, 30 Mar 2023 20:19:53 -0700

Sean Nash committed 243440e on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999: Removed redundant trigger for DG restarted alarm.

· /firmware/App/Modes/SampleWater.c

(-31, +0)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999, DEN-15030 fixed the start DG command to only get the acid and bicarb parameters if the HD is sending a start ...

Dara Navaei — Thu, 30 Mar 2023 19:06:05 -0700

Dara Navaei committed 3662494 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999, DEN-15030 fixed the start DG command to only get the acid and bicarb parameters if the HD is sending a start command

· /firmware/App/Services/SystemCommMessages.c

(-3, +9)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14999-alarm-table-updates

Sean Nash — Thu, 30 Mar 2023 17:28:56 -0700

Sean Nash committed ba71bd3 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14999-alarm-table-updates

· /firmware/App/Services/SystemCommMessages.c

(-2, +4)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999: Fixed sending of DG valve settings command.

Sean Nash — Thu, 30 Mar 2023 17:28:51 -0700

Sean Nash committed 9c78cf3 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999: Fixed sending of DG valve settings command.

· /firmware/App/Services/SystemCommMessages.c

(-0, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999, DEN-15030 updated the DG start command payload

Dara Navaei — Thu, 30 Mar 2023 16:12:07 -0700

Dara Navaei committed 5b89b58 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999, DEN-15030 updated the DG start command payload

· /firmware/App/Services/SystemCommMessages.c

(-2, +4)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999: updates to pressure POST test and 24V range alarms.

Sean Nash — Thu, 30 Mar 2023 16:11:07 -0700

Sean Nash committed bed5628 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999: updates to pressure POST test and 24V range alarms.

· /firmware/App/Controllers/PresOccl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Voltages.c	(-11, +25)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999: Removed obsolete/redundant alarms. Addressed code review comment.

Sean Nash — Thu, 30 Mar 2023 09:41:46 -0700

Sean Nash committed 13b15c2 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999: Removed obsolete/redundant alarms. Addressed code review comment.

· /firmware/App/Modes/Rinseback.c	(-8, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentRecirc.c	(-31, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999: on blood leak detection, alarm, but then go to init state to prevent re-trigger after alarm cleared.

Sean Nash — Wed, 29 Mar 2023 23:09:23 -0700

Sean Nash committed be2b776 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999: on blood leak detection, alarm, but then go to init state to prevent re-trigger after alarm cleared.

· /firmware/App/Controllers/BloodLeak.c

(-0, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen...

Wed, 29 Mar 2023 16:11:14 -0700

James Walter Taylor committed b4bb0e5 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 252 more in hdfirmware

DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen

Increased message ACK timeouts, for both DG and UI.

· /firmware/App/Services/SystemComm.c

(-3, +3)

| History

| Source

| Diff