Fisheye on dgfirmware/firmware/App/Controllers/Valves.h https://devapps.diality.us/changelog/~br%3DDEN-14859-cleaning-modes-state-timer-reset/dgfirmware/firmware/App/Controllers/Valves.h Recent activity in "dgfirmware" under directory /firmware/App/Controllers/Valves.h DG-DEN-2650-1: closed by Dara Navaei Thu, 19 Oct 2023 08:42:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei Closed DG-DEN-2650-1 ]]> DG-DEN-2650-1: reviewers finished Thu, 19 Oct 2023 08:42:03 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei finished reviewing DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:41:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2650-1: started by Dara Navaei Thu, 19 Oct 2023 08:41:19 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei started review DG-DEN-2650-1 ]]> DG-DEN-13834-1: closed by Dara Navaei Wed, 18 Oct 2023 21:05:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13834-1 https://devapps.diality.us/cru/DG-DEN-13834-1 Dara Navaei Closed DG-DEN-13834-1 ]]> DG-DEN-13834-1: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH" Wed, 18 Oct 2023 21:05:20 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13834-1/#c19058 https://devapps.diality.us/cru/DG-DEN-13834-1/#c19058 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-13834-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-13834-1: started by Dara Navaei Wed, 18 Oct 2023 21:03:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13834-1 https://devapps.diality.us/cru/DG-DEN-13834-1 Dara Navaei started review DG-DEN-13834-1 ]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 03 Jan 2023 10:10:54 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=6499ea25921fcf67826fa0c35bb03caf411ba542 https://devapps.diality.us/changelog/dgfirmware?cs=6499ea25921fcf67826fa0c35bb03caf411ba542 Dara Navaei committed 6499ea2 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 174 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
… 84 more files in changeset.
]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 10 Nov 2022 10:35:45 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=9cc5da6947aa143a10f95519eb7f366c1b095d61 https://devapps.diality.us/changelog/dgfirmware?cs=9cc5da6947aa143a10f95519eb7f366c1b095d61 Dara Navaei committed 9cc5da6 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 182 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Thermistors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-1, +1) | History | Source | Diff
… 8 more files in changeset.
]]> DG-DEN-14175-1: closed by Dara Navaei Thu, 10 Nov 2022 10:34:54 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14175-1 https://devapps.diality.us/cru/DG-DEN-14175-1 Dara Navaei Closed DG-DEN-14175-1 ]]> DG-DEN-14175-1: reviewers finished Thu, 10 Nov 2022 10:26:00 -0800 https://devapps.diality.us/cru/DG-DEN-14175-1 https://devapps.diality.us/cru/DG-DEN-14175-1 wbracken  (deleted user) and Sean Nash finished reviewing DG-DEN-14175-1 DG-DEN-14175_DG HD Dev HD DG Dvt Update Part 5 ]]> DG-DEN-14175-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Thu, 10 Nov 2022 10:19:33 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14175-1/#c14851 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14851 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-14175-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-14175-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 10 Nov 2022 10:04:54 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14175-1/#c14850 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14850 Sean Nash replied to Dara Navaei in DG-DEN-14175-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14175-1: comment by Dara Navaei "Done." Thu, 10 Nov 2022 09:08:31 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14175-1/#c14849 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14849 Dara Navaei replied to Sean Nash in DG-DEN-14175-1

Done.

]]> DG-DEN-14175-1: comment by Dara Navaei "Done." Thu, 10 Nov 2022 09:07:22 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14175-1/#c14848 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14848 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-14175-1

Done.

]]> DG-DEN-14175-1: comment by wbracken "Isn't fpgaSensorReadings an input?" Wed, 09 Nov 2022 15:05:57 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14175-1/#c14845 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14845 wbracken  (deleted user) commented on DG-DEN-14175-1

Isn't fpgaSensorReadings an input?

]]> DG-DEN-14175-1: comment by Sean Nash "Restore or remove." Wed, 09 Nov 2022 14:23:10 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14175-1/#c14844 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14844 Sean Nash commented on DG-DEN-14175-1

Restore or remove.

]]> DG-DEN-14175-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Thu, 03 Nov 2022 10:37:59 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-14175-1/#c14722 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14722 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-14175-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-14175-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Thu, 03 Nov 2022 10:32:44 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-14175-1/#c14721 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14721 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-14175-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-14175-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Thu, 03 Nov 2022 10:29:10 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-14175-1/#c14720 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14720 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-14175-1

RESOLVED IN CODE WALKTHROUGH

]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14175 addressed the code review comments and replaced the V3 enable software configuration flag with the hardware co... Thu, 03 Nov 2022 10:03:17 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=6f2991204047ccbceeb5461f7c35af6d8f5dfd0b https://devapps.diality.us/changelog/dgfirmware?cs=6f2991204047ccbceeb5461f7c35af6d8f5dfd0b Dara Navaei committed 6f29912 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more in dgfirmware DEN-14175 addressed the code review comments and replaced the V3 enable software configuration flag with the hardware configuration flag from FGPA. Updated the trimmer heater's ramp state to check the use previous duty cycle flag instead of estimating the duty cycle.

· /firmware/App/Controllers/ConcentratePumps.c (-4, +5) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-5, +6) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-7, +30) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-0, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-9, +7) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-9, +5) | History | Source | Diff
· /firmware/App/Controllers/Thermistors.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-9, +71) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-1, +3) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-3, +4) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-1, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-6, +7) | History | Source | Diff
]]> DG-DEN-14175-1: comment by Dara Navaei "This is done to get an average of the fill temp..." Thu, 03 Nov 2022 09:56:52 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14175-1/#c14714 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14714 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-14175-1

This is done to get an average of the fill temperature as well as the last fill temperature prior to tranistioning to Gen Idle. These values are used for the next estimation and are different from the heaters driver.

]]> DG-DEN-14175-1: comment by Dara Navaei "Done." Thu, 03 Nov 2022 09:55:19 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14175-1/#c14713 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14713 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-14175-1

Done.

]]> DG-DEN-14175-1: comment by Dara Navaei "No, it should be removed." Thu, 03 Nov 2022 09:54:36 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14175-1/#c14712 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14712 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-14175-1

No, it should be removed.

]]> DG-DEN-14175-1: comment by wbracken "Where is valveSensedStates being updated?" Mon, 31 Oct 2022 14:00:27 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-14175-1/#c14705 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14705 wbracken  (deleted user) commented on DG-DEN-14175-1

Where is valveSensedStates being updated?

]]> DG-DEN-14175-1: comment by wbracken "Remove comment." Mon, 31 Oct 2022 13:53:36 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-14175-1/#c14704 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14704 wbracken  (deleted user) commented on DG-DEN-14175-1

Remove comment.

]]> DG-DEN-14175-1: comment by wbracken "Not clear this needs to be done. I believe is ..." Fri, 28 Oct 2022 11:58:30 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-14175-1/#c14664 https://devapps.diality.us/cru/DG-DEN-14175-1/#c14664 wbracken  (deleted user) commented on DG-DEN-14175-1

Not clear this needs to be done. I believe is properly handled in heaters when you get a temperature value and configured for V3.

]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14175, DIAL-213 added drain pump current and direction override commands, updated the heaters driver with the latest... Fri, 28 Oct 2022 09:56:32 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=2b9d10664884e9b20d391cc3178d3c85347cdf2c https://devapps.diality.us/changelog/dgfirmware?cs=2b9d10664884e9b20d391cc3178d3c85347cdf2c Dara Navaei committed 2b9d106 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more in dgfirmware DEN-14175, DIAL-213 added drain pump current and direction override commands, updated the heaters driver with the latest optimization requirements, added a DG valves sensed states override command

· /firmware/App/Controllers/DrainPump.c (-2, +98) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +6) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-26, +46) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-14, +95) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-30, +37) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-10, +17) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +12) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-3, +97) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +9) | History | Source | Diff
]]> DG-DEN-14175-1: started by Dara Navaei Thu, 27 Oct 2022 13:10:50 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14175-1 https://devapps.diality.us/cru/DG-DEN-14175-1 Dara Navaei started review DG-DEN-14175-1 ]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 18 Oct 2022 18:05:20 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=0c296cef29037819be204c45a23d4d38a52b2718 https://devapps.diality.us/changelog/dgfirmware?cs=0c296cef29037819be204c45a23d4d38a52b2718 Dara Navaei committed 0c296ce on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 187 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Pressures.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Switches.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
… 25 more files in changeset.
]]>