Fisheye on hdfirmware/firmware/App/Services/SystemCommMessages.c

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999, DEN-15030 fixed the start DG command to only get the acid and bicarb parameters if the HD is sending a start ...

Dara Navaei — Thu, 30 Mar 2023 19:06:05 -0700

Dara Navaei committed 3662494 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999, DEN-15030 fixed the start DG command to only get the acid and bicarb parameters if the HD is sending a start command

· /firmware/App/Services/SystemCommMessages.c

(-3, +9)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14999-alarm-table-updates

Sean Nash — Thu, 30 Mar 2023 17:28:56 -0700

Sean Nash committed ba71bd3 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14999-alarm-table-updates

· /firmware/App/Services/SystemCommMessages.c

(-2, +4)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999: Fixed sending of DG valve settings command.

Sean Nash — Thu, 30 Mar 2023 17:28:51 -0700

Sean Nash committed 9c78cf3 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999: Fixed sending of DG valve settings command.

· /firmware/App/Services/SystemCommMessages.c

(-0, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999, DEN-15030 updated the DG start command payload

Dara Navaei — Thu, 30 Mar 2023 16:12:07 -0700

Dara Navaei committed 5b89b58 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999, DEN-15030 updated the DG start command payload

· /firmware/App/Services/SystemCommMessages.c

(-2, +4)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14999: Removed minimum UF change. Added 250ms of persistence to HD fluid leak alarm. Increased no ack retries from...

Sean Nash — Wed, 29 Mar 2023 11:20:23 -0700

Sean Nash committed 0471700 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 251 more in hdfirmware

DEN-14999: Removed minimum UF change. Added 250ms of persistence to HD fluid leak alarm. Increased no ack retries from 8 to 10 because UI needed more time at startup. Accept UI check-in message regardless of payload size because UI is sending 2 different flavors of check-in message.

· /firmware/App/Controllers/FluidLeak.c	(-1, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-10, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 28 Mar 2023 09:01:35 -0700

Dara Navaei committed 14d740b on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 252 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirTrap.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14906: fixed merge conflicts from staging.

Sean Nash — Tue, 28 Mar 2023 08:23:03 -0700

Sean Nash committed 709def4 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 253 more in hdfirmware

DEN-14906: fixed merge conflicts from staging.

· /firmware/App/Controllers/BloodFlow.c	(-1, +10)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-7, +15)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-6, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-3, +1)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-51, +62)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +35)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-182, +322)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14906: Fix response to Dialin requiring ACK when it should not.

Sean Nash — Wed, 22 Mar 2023 16:32:32 -0700

Sean Nash committed 447486e on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 253 more in hdfirmware

DEN-14906: Fix response to Dialin requiring ACK when it should not.

· /firmware/App/Controllers/AirTrap.c	(-4, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 22 Mar 2023 11:06:39 -0700

Dara Navaei committed afe0d7c on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 255 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Bubble.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-14788-DIAL-242-air-bubble-sensor

Michael Garthwaite — Wed, 22 Mar 2023 09:38:53 -0700

Michael Garthwaite committed fcb0c81 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 256 more in hdfirmware

Merge branch 'staging' into DEN-14788-DIAL-242-air-bubble-sensor

· /firmware/App/Services/SystemCommMessages.c

(-6, +134)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14788: fixed UI check-in.

Michael Garthwaite — Wed, 22 Mar 2023 09:38:37 -0700

Michael Garthwaite committed 1683e61 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 256 more in hdfirmware

DEN-14788: fixed UI check-in.

· /firmware/App/Services/SystemCommMessages.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 21 Mar 2023 16:56:34 -0700

Dara Navaei committed 19f13e6 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 256 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DGInterface.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10

Dara Navaei — Mon, 20 Mar 2023 20:30:14 -0700

Dara Navaei committed 57dd046 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 257 more in hdfirmware

Merge branch 'staging' into DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10

· /firmware/App/Modes/OperationModes.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-33, +29)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-174, +186)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +76)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 20 Mar 2023 10:24:41 -0700

Dara Navaei committed 9d924ec on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 259 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/FluidLeak.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/BloodPrime.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentRecirc.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14763 addressed the code review comments

Dara Navaei — Mon, 20 Mar 2023 09:46:26 -0700

Dara Navaei committed 5b71511 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 257 more in hdfirmware

DEN-14763 addressed the code review comments

· /firmware/App/Modes/ModeStandby.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +4)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10

Dara Navaei — Sat, 18 Mar 2023 15:02:42 -0700

Dara Navaei committed 5c083ca on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 257 more in hdfirmware

Merge branch 'staging' into DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10

· /firmware/App/Modes/ModeStandby.c	(-28, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-19, +19)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +5)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14689: code review changes.

Michael Garthwaite — Fri, 17 Mar 2023 13:54:45 -0700

Michael Garthwaite committed 366524f on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 260 more in hdfirmware

DEN-14689: code review changes.

· /firmware/App/Services/AlarmMgmt.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-8, +8)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-14689-messaging-bugs

Michael Garthwaite — Fri, 17 Mar 2023 13:47:12 -0700

Michael Garthwaite committed e5fc9a1 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 260 more in hdfirmware

Merge branch 'staging' into DEN-14689-messaging-bugs

· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-21, +20)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-2, +9)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-12, +12)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +5)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14763 fixed the space a in message function

Dara Navaei — Fri, 17 Mar 2023 11:26:50 -0700

Dara Navaei committed 278207f on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 257 more in hdfirmware

DEN-14763 fixed the space a in message function

· /firmware/App/Services/SystemCommMessages.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 17 Mar 2023 09:34:57 -0700

Dara Navaei committed 99ec83e on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 260 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/HDCommon.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10

Dara Navaei — Thu, 16 Mar 2023 20:31:32 -0700

Dara Navaei committed 140ae22 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 257 more in hdfirmware

Merge branch 'staging' into DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10

· /firmware/App/Controllers/DGInterface.c	(-11, +34)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.h	(-4, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-12, +12)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +3)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14763 added commands to be able to issue hard stop the HD pumps from Dialin

Dara Navaei — Thu, 16 Mar 2023 20:22:08 -0700

Dara Navaei committed 876a1cd on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 257 more in hdfirmware

DEN-14763 added commands to be able to issue hard stop the HD pumps from Dialin

· /firmware/App/Controllers/Valves.h	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-9, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +13)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +69)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +9)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14888: Implemented user confirmation of treatment end response to alarm.

Sean Nash — Mon, 13 Mar 2023 13:52:05 -0700

Sean Nash committed 2fa2467 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 261 more in hdfirmware

DEN-14888: Implemented user confirmation of treatment end response to alarm.

· /firmware/App/HDCommon.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-27, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-19, +18)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +4)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14689: reworked message len checks for it to be grabbed by automation

Michael Garthwaite — Fri, 10 Mar 2023 09:58:38 -0800

Michael Garthwaite committed 96b0388 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 260 more in hdfirmware

DEN-14689: reworked message len checks for it to be grabbed by automation

· /firmware/App/Services/SystemCommMessages.c

(-5, +5)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14689: removed dg checkin message as it is no longer needed.

Michael Garthwaite — Thu, 09 Mar 2023 09:33:08 -0800

Michael Garthwaite committed 8c195e4 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 260 more in hdfirmware

DEN-14689: removed dg checkin message as it is no longer needed.

· /firmware/App/Services/SystemComm.c	(-4, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-9, +26)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14689: updated active alarm list response to have a payload contained within a struct

Michael Garthwaite — Wed, 08 Mar 2023 16:39:34 -0800

Michael Garthwaite committed 7dae221 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 260 more in hdfirmware

DEN-14689: updated active alarm list response to have a payload contained within a struct

· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-8, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-1, +9)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-10, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14689: fixed compiler warning.

Michael Garthwaite — Wed, 08 Mar 2023 15:50:07 -0800

Michael Garthwaite committed 468292c on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 260 more in hdfirmware

DEN-14689: fixed compiler warning.

· /firmware/App/Services/SystemCommMessages.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14689: updated message protocols to be contained within structs. Fixed <32 bit fields to be compiled as their respec...

Michael Garthwaite — Wed, 08 Mar 2023 15:47:53 -0800

Michael Garthwaite committed c9eae08 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 260 more in hdfirmware

DEN-14689: updated message protocols to be contained within structs. Fixed <32 bit fields to be compiled as their respective byte size.

· /firmware/App/Services/SystemCommMessages.c	(-25, +34)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-14, +14)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-14689-messaging-bugs

Michael Garthwaite — Wed, 08 Mar 2023 15:35:54 -0800

Michael Garthwaite committed 1d4d523 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 260 more in hdfirmware

Merge branch 'staging' into DEN-14689-messaging-bugs

· /firmware/App/Controllers/SyringePump.c	(-27, +18)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-23, +52)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +3)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14763 changed the sizeof of message 0x98 to be able to pick up with the script

Dara Navaei — Wed, 08 Mar 2023 13:26:36 -0800

Dara Navaei committed f5acc08 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 257 more in hdfirmware

DEN-14763 changed the sizeof of message 0x98 to be able to pick up with the script

· /firmware/App/Services/SystemCommMessages.c

(-1, +1)

| History

| Source

| Diff