Fisheye on hdfirmware/

hdfirmware (DEN-16693-institutional-settings-implementation-2): DIAL-262: code review changes

Michael Garthwaite — Wed, 14 Jun 2023 11:23:35 -0700

Michael Garthwaite committed 2d00c9f on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 196 more in hdfirmware

DIAL-262: code review changes

· /firmware/App/Modes/OperationModes.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DIAL-264: fixed blood prime not showing sub state in operation status event

Michael Garthwaite — Wed, 14 Jun 2023 10:42:30 -0700

Michael Garthwaite committed 49083c8 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 196 more in hdfirmware

DIAL-264: fixed blood prime not showing sub state in operation status event

· /firmware/App/Modes/BloodPrime.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Merge branch 'staging' into DEN-15196-DIAL-262-fixes

Michael Garthwaite — Wed, 14 Jun 2023 10:39:50 -0700

Michael Garthwaite committed 42202c4 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 196 more in hdfirmware

Merge branch 'staging' into DEN-15196-DIAL-262-fixes

· /firmware/App/Modes/OperationModes.c	(-3, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-71, +72)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Wed, 14 Jun 2023 10:26:12 -0700

Dara Navaei committed fd5bc40 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 197 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 14 Jun 2023 10:26:03 -0700

Dara Navaei committed f1157c7 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 197 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodLeak.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merged DEN-15367

Dara Navaei — Wed, 14 Jun 2023 10:21:59 -0700

Dara Navaei committed 5be9247 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 197 more in hdfirmware

Merged DEN-15367

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15367 merged staging

Dara Navaei — Wed, 14 Jun 2023 09:56:47 -0700

Dara Navaei committed e63dcc4 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

DEN-15367 merged staging

· /firmware/App/Controllers/BloodLeak.c	(-8, +15)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-11, +15)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Wed, 14 Jun 2023 09:41:22 -0700

Dara Navaei committed dd19edf on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 14 Jun 2023 09:41:08 -0700

Dara Navaei committed 180305f on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeTreatmentParams.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-15493-usability-ui-fw-rinseback-flow-rate' into staging

Wed, 14 Jun 2023 09:38:28 -0700

Darren Cox committed ba2020f on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

Merge branch 'DEN-15493-usability-ui-fw-rinseback-flow-rate' into staging

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Wed, 14 Jun 2023 09:25:09 -0700

Dara Navaei committed 085c5c2 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 14 Jun 2023 09:25:02 -0700

Dara Navaei committed e288ab9 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/PresOccl.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merged DEN-15558 to staging.

Sean Nash — Wed, 14 Jun 2023 09:23:04 -0700

Sean Nash committed bfccacc on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

Merged DEN-15558 to staging.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merged staging to DEN-15558.

Sean Nash — Wed, 14 Jun 2023 09:20:05 -0700

Sean Nash committed 50a2a4f on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

Merged staging to DEN-15558.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15367 addressed a code review comment

Dara Navaei — Wed, 14 Jun 2023 09:13:22 -0700

Dara Navaei committed febf34a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

DEN-15367 addressed a code review comment

· /firmware/App/Modes/ModeStandby.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15489 updated the code that checks for the validation dates

Dara Navaei — Wed, 14 Jun 2023 09:07:57 -0700

Dara Navaei committed 8bfe61e on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

DEN-15489 updated the code that checks for the validation dates

· /firmware/App/Modes/ModeStandby.c

(-16, +18)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DIAL-262: fixes

Michael Garthwaite — Tue, 13 Jun 2023 16:53:44 -0700

Michael Garthwaite committed 7527efb on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 196 more in hdfirmware

DIAL-262: fixes

· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DIAL-262: added additional event calls for UF and saline transitions.

Michael Garthwaite — Tue, 13 Jun 2023 16:50:37 -0700

Michael Garthwaite committed 673214e on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 196 more in hdfirmware

DIAL-262: added additional event calls for UF and saline transitions.

· /firmware/App/Modes/Dialysis.c	(-1, +9)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-0, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15367 addressed the code review comments. Added code to check the payload of the message that is received from DG to...

Dara Navaei — Tue, 13 Jun 2023 15:34:29 -0700

Dara Navaei committed f249310 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

DEN-15367 addressed the code review comments. Added code to check the payload of the message that is received from DG to indicate that DG is ready to dispense more water in RO permeate sample mode

· /firmware/App/Controllers/BloodLeak.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-9, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15558: Addressed code review comment.

Sean Nash — Tue, 13 Jun 2023 15:32:40 -0700

Sean Nash committed f0e53bc on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

DEN-15558: Addressed code review comment.

· /firmware/App/Controllers/PresOccl.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DIAL-262: removed old 4th state data when hd pauses in priming

Michael Garthwaite — Tue, 13 Jun 2023 14:35:56 -0700

Michael Garthwaite committed c0421d4 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 196 more in hdfirmware

DIAL-262: removed old 4th state data when hd pauses in priming

· /firmware/App/Modes/Prime.c

(-0, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15558: Extend exemption for venous low pressure alarm during air trap fill for 5 seconds after fill to allow pressur...

Sean Nash — Tue, 13 Jun 2023 12:34:47 -0700

Sean Nash committed bafedda on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

DEN-15558: Extend exemption for venous low pressure alarm during air trap fill for 5 seconds after fill to allow pressure to recover.

· /firmware/App/Controllers/PresOccl.c

(-17, +29)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Tue, 13 Jun 2023 10:35:41 -0700

Dara Navaei committed b386611 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 13 Jun 2023 10:35:30 -0700

Dara Navaei committed b442cce on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodLeak.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-15363-fw-handle-bld-sensor-communication-errors' into staging

Tue, 13 Jun 2023 10:33:57 -0700

Bill Bracken committed 0c966d9 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

Merge branch 'DEN-15363-fw-handle-bld-sensor-communication-errors' into staging

· /firmware/App/Controllers/BloodLeak.c

(-5, +12)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15558: Finished restore of original BP speed during dialyzer prime.

Sean Nash — Tue, 13 Jun 2023 10:06:45 -0700

Sean Nash committed dde8219 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

DEN-15558: Finished restore of original BP speed during dialyzer prime.

· /firmware/App/Modes/Prime.c

(-2, +0)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DIAL-262: fixed operation status event to have more accurate transitioning in between dialysis sub modes.

Michael Garthwaite — Tue, 13 Jun 2023 09:57:01 -0700

Michael Garthwaite committed dd6ff80 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 196 more in hdfirmware

DIAL-262: fixed operation status event to have more accurate transitioning in between dialysis sub modes.

· /firmware/App/Modes/Dialysis.c

(-2, +5)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15558: Reversed temporary change in dialyzer prime BP speed. Increased max venous pressure from 300 to 400 mmHg.

Sean Nash — Tue, 13 Jun 2023 09:46:39 -0700

Sean Nash committed 68e6a5f on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

DEN-15558: Reversed temporary change in dialyzer prime BP speed. Increased max venous pressure from 300 to 400 mmHg.

· /firmware/App/Controllers/PresOccl.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-6, +6)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15558: temporary slow down of BP during pre-tx dialyzer prime state to see if helps with blood leak issue.

Sean Nash — Mon, 12 Jun 2023 17:55:14 -0700

Sean Nash committed efe4732 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

DEN-15558: temporary slow down of BP during pre-tx dialyzer prime state to see if helps with blood leak issue.

· /firmware/App/Modes/Prime.c

(-6, +8)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Mon, 12 Jun 2023 16:41:16 -0700

Dara Navaei committed e77e147 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff