Fisheye on application/sources/model/ui/data/MUIBloodPressureData.cpp https://devapps.diality.us/changelog/~br%3DDEN-15219-UI-VD-S96-vitalMeasTimer/application/sources/model/ui/data/MUIBloodPressureData.cpp Recent activity in "application" under directory /sources/model/ui/data/MUIBloodPressureData.cpp UI-DEN-12031-2: closed by Dara Navaei Tue, 19 Nov 2024 15:27:58 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-12031-2 https://devapps.diality.us/cru/UI-DEN-12031-2 Dara Navaei Closed UI-DEN-12031-2 ]]> UI-DEN-12031-2: reviewers finished Tue, 19 Nov 2024 13:54:25 -0800 https://devapps.diality.us/cru/UI-DEN-12031-2 https://devapps.diality.us/cru/UI-DEN-12031-2 Behrouz NematiPour and Dara Navaei finished reviewing UI-DEN-12031-2 UI-DEN-12031_Leahi/Features/Den 12031 UI AM Models Nested Ifs ]]> UI-DEN-12031-2: started by Dara Navaei Tue, 19 Nov 2024 13:27:27 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-12031-2 https://devapps.diality.us/cru/UI-DEN-12031-2 Dara Navaei started review UI-DEN-12031-2 ]]> UI-BUG-S62-1: closed by Behrouz NematiPour Wed, 02 Feb 2022 12:18:11 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-BUG-S62-1 https://devapps.diality.us/cru/UI-BUG-S62-1 Behrouz NematiPour Closed UI-BUG-S62-1 ]]> UI-BUG-S62-1: reviewers finished Wed, 02 Feb 2022 11:33:02 -0800 https://devapps.diality.us/cru/UI-BUG-S62-1 https://devapps.diality.us/cru/UI-BUG-S62-1 Michael Garthwaite and Sean Nash finished reviewing UI-BUG-S62-1 UI-BUG-S62 ]]> UI-BUG-S62-1: comment by Sean Nash "RESOLVED." Wed, 02 Feb 2022 11:07:03 -0800 Sean Nash https://devapps.diality.us/cru/UI-BUG-S62-1/#c11860 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11860 Sean Nash replied to Behrouz NematiPour in UI-BUG-S62-1

RESOLVED.

]]> UI-BUG-S62-1: comment by Sean Nash "RESOLVED." Wed, 02 Feb 2022 11:06:51 -0800 Sean Nash https://devapps.diality.us/cru/UI-BUG-S62-1/#c11859 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11859 Sean Nash replied to Behrouz NematiPour in UI-BUG-S62-1

RESOLVED.

]]> UI-BUG-S62-1: comment by Sean Nash "RESOLVED." Wed, 02 Feb 2022 11:06:39 -0800 Sean Nash https://devapps.diality.us/cru/UI-BUG-S62-1/#c11858 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11858 Sean Nash replied to Behrouz NematiPour in UI-BUG-S62-1

RESOLVED.

]]> UI-BUG-S62-1: comment by Sean Nash "RESOLVED." Wed, 02 Feb 2022 11:06:13 -0800 Sean Nash https://devapps.diality.us/cru/UI-BUG-S62-1/#c11857 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11857 Sean Nash replied to Behrouz NematiPour in UI-BUG-S62-1

RESOLVED.

]]> UI-BUG-S62-1: comment by Sean Nash "RESOLVED." Wed, 02 Feb 2022 11:05:27 -0800 Sean Nash https://devapps.diality.us/cru/UI-BUG-S62-1/#c11856 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11856 Sean Nash replied to Behrouz NematiPour in UI-BUG-S62-1

RESOLVED.

]]> UI-BUG-S62-1: comment by Michael Garthwaite "RESOLVED." Wed, 02 Feb 2022 09:57:15 -0800 Michael Garthwaite https://devapps.diality.us/cru/UI-BUG-S62-1/#c11852 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11852 Michael Garthwaite replied to Behrouz NematiPour in UI-BUG-S62-1

RESOLVED.

]]> UI-BUG-S62-1: comment by Dara Navaei "RESOLVED." Tue, 01 Feb 2022 20:55:31 -0800 Dara Navaei https://devapps.diality.us/cru/UI-BUG-S62-1/#c11851 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11851 Dara Navaei replied to Behrouz NematiPour in UI-BUG-S62-1

RESOLVED.

]]> UI-BUG-S62-1: comment by Behrouz NematiPour "matched." Tue, 01 Feb 2022 15:09:12 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-BUG-S62-1/#c11844 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11844 Behrouz NematiPour replied to Michael Garthwaite in UI-BUG-S62-1

matched.

]]> UI-BUG-S62-1: comment by Behrouz NematiPour "The file is removed." Tue, 01 Feb 2022 15:08:59 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-BUG-S62-1/#c11843 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11843 Behrouz NematiPour replied to Sean Nash in UI-BUG-S62-1

The file is removed.

]]> UI-BUG-S62-1: comment by Behrouz NematiPour "The Arterial and Venous sliders are RangeSlider..." Tue, 01 Feb 2022 15:08:06 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-BUG-S62-1/#c11842 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11842 Behrouz NematiPour replied to Sean Nash in UI-BUG-S62-1

The Arterial and Venous sliders are RangeSlider and are handled differently.
The extra code is removed.

]]> UI-BUG-S62-1: comment by Behrouz NematiPour "The Arterial and Venous sliders are RangeSlider..." Tue, 01 Feb 2022 15:07:59 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-BUG-S62-1/#c11841 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11841 Behrouz NematiPour replied to Sean Nash in UI-BUG-S62-1

The Arterial and Venous sliders are RangeSlider and are handled differently.
The extra code is removed.

]]> UI-BUG-S62-1: comment by Behrouz NematiPour "The Arterial and Venous sliders are RangeSlider..." Tue, 01 Feb 2022 15:06:58 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-BUG-S62-1/#c11840 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11840 Behrouz NematiPour replied to Sean Nash in UI-BUG-S62-1

The Arterial and Venous sliders are RangeSlider and are handled differently.
The extra code is removed.

]]> UI-BUG-S62-1: comment by Behrouz NematiPour "Couldn't find time to investigate more on this,..." Tue, 01 Feb 2022 14:53:47 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-BUG-S62-1/#c11839 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11839 Behrouz NematiPour replied to Dara Navaei in UI-BUG-S62-1

Couldn't find time to investigate more on this,
So created a task for later code cleanup and refactoring.
http://dvm-linux02:8080/browse/DEN-12031

]]> UI-BUG-S62-1: comment by Behrouz NematiPour "It's just code clean-up notes, ToDos with low p..." Tue, 01 Feb 2022 14:39:01 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-BUG-S62-1/#c11838 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11838 Behrouz NematiPour replied to Sean Nash in UI-BUG-S62-1

It's just code clean-up notes, ToDos with low priority and will be addressed when gets priority.

]]> UI-BUG-S62-1: comment by Michael Garthwaite "RESOLVED." Wed, 26 Jan 2022 14:14:58 -0800 Michael Garthwaite https://devapps.diality.us/cru/UI-BUG-S62-1/#c11780 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11780 Michael Garthwaite replied to Michael Garthwaite in UI-BUG-S62-1

RESOLVED.

]]> UI-BUG-S62-1: comment by Michael Garthwaite "Disregard. Found where it is used." Wed, 26 Jan 2022 14:14:51 -0800 Michael Garthwaite https://devapps.diality.us/cru/UI-BUG-S62-1/#c11779 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11779 Michael Garthwaite replied to Michael Garthwaite in UI-BUG-S62-1

Disregard. Found where it is used.

]]> UI-BUG-S62-1: comment by Michael Garthwaite "What is the purpose of this alias?" Wed, 26 Jan 2022 14:11:00 -0800 Michael Garthwaite https://devapps.diality.us/cru/UI-BUG-S62-1/#c11778 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11778 Michael Garthwaite commented on UI-BUG-S62-1

What is the purpose of this alias?

]]> UI-BUG-S62-1: comment by Sean Nash "Why commented out?" Wed, 26 Jan 2022 14:05:51 -0800 Sean Nash https://devapps.diality.us/cru/UI-BUG-S62-1/#c11777 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11777 Sean Nash commented on UI-BUG-S62-1

Why commented out?

]]> UI-BUG-S62-1: comment by Sean Nash "Why commented out?" Wed, 26 Jan 2022 14:04:37 -0800 Sean Nash https://devapps.diality.us/cru/UI-BUG-S62-1/#c11776 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11776 Sean Nash commented on UI-BUG-S62-1

Why commented out?

]]> UI-BUG-S62-1: comment by Sean Nash "Why is this commented out?" Wed, 26 Jan 2022 14:03:57 -0800 Sean Nash https://devapps.diality.us/cru/UI-BUG-S62-1/#c11775 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11775 Sean Nash commented on UI-BUG-S62-1

Why is this commented out?

]]> UI-BUG-S62-1: comment by Sean Nash "When will we do this?" Wed, 26 Jan 2022 14:02:35 -0800 Sean Nash https://devapps.diality.us/cru/UI-BUG-S62-1/#c11774 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11774 Sean Nash commented on UI-BUG-S62-1

When will we do this?

]]> UI-BUG-S62-1: comment by Sean Nash "File name does not appear to match image." Wed, 26 Jan 2022 13:53:47 -0800 Sean Nash https://devapps.diality.us/cru/UI-BUG-S62-1/#c11772 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11772 Sean Nash commented on UI-BUG-S62-1

File name does not appear to match image.

]]> UI-BUG-S62-1: comment by Michael Garthwaite "The declaration in the header file has const fo..." Wed, 26 Jan 2022 13:34:51 -0800 Michael Garthwaite https://devapps.diality.us/cru/UI-BUG-S62-1/#c11771 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11771 Michael Garthwaite commented on UI-BUG-S62-1

The declaration in the header file has const for all 3 parameters.

]]> UI-BUG-S62-1: comment by Behrouz NematiPour "That is a very good point. No one ever mention..." Wed, 19 Jan 2022 09:30:08 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-BUG-S62-1/#c11767 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11767 Behrouz NematiPour replied to Dara Navaei in UI-BUG-S62-1

That is a very good point.
No one ever mentioned that.

Let me investigate, why I had all these repeated else.
Could be for performance not to check next, but there is another way for that too.
If I can't find a quick answer for that let me create a case for that since it is everywhere.

]]> UI-BUG-S62-1: comment by Dara Navaei "RESOLVED." Wed, 19 Jan 2022 09:32:31 -0800 Dara Navaei https://devapps.diality.us/cru/UI-BUG-S62-1/#c11768 https://devapps.diality.us/cru/UI-BUG-S62-1/#c11768 Dara Navaei replied to Behrouz NematiPour in UI-BUG-S62-1

RESOLVED.

]]>