Fisheye on hdfirmware/

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15274 addressed a code review comment

Dara Navaei — Wed, 17 May 2023 11:23:56 -0700

Dara Navaei committed e788fc8 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

DEN-15274 addressed a code review comment

· /firmware/App/Modes/ModePreTreat.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15274, DEN-15360 changed the code to not alarm watchdog expired until POST is done

Dara Navaei — Wed, 17 May 2023 10:18:23 -0700

Dara Navaei committed 8b7624b on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

DEN-15274, DEN-15360 changed the code to not alarm watchdog expired until POST is done

· /firmware/App/Services/WatchdogMgmt.c

(-3, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15274 tranistioned the blood pump occlusion to transition to patient connect

Dara Navaei — Wed, 17 May 2023 08:32:39 -0700

Dara Navaei committed 926e278 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

DEN-15274 tranistioned the blood pump occlusion to transition to patient connect

· /firmware/App/Modes/ModePreTreat.c	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-5, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15274, DEN-15356 fixed the dialyzer inverted reject reason

Dara Navaei — Wed, 17 May 2023 07:52:46 -0700

Dara Navaei committed 0d9ab05 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

DEN-15274, DEN-15356 fixed the dialyzer inverted reject reason

· /firmware/App/Modes/ModePreTreat.c

(-3, +3)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15274 added blood pump occlusion in transition to treatment for expedite pre-treatment command

Dara Navaei — Tue, 16 May 2023 18:28:27 -0700

Dara Navaei committed c0cbf6f on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

DEN-15274 added blood pump occlusion in transition to treatment for expedite pre-treatment command

· /firmware/App/Modes/ModeTreatment.c

(-0, +5)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-15274-hd_dg_test_configuration_setup

Dara Navaei — Tue, 16 May 2023 17:10:00 -0700

Dara Navaei committed 8747e94 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

Merge branch 'staging' into DEN-15274-hd_dg_test_configuration_setup

· /firmware/App/Modes/BloodPrime.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-14, +46)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-3, +33)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-4, +6)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Tue, 16 May 2023 16:13:21 -0700

Dara Navaei committed ec63a63 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 16 May 2023 16:13:13 -0700

Dara Navaei committed 3835544 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/BloodPrime.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ConsumableSelfTest.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/Dialysis.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModePostTreat.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreTreat.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeService.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatment.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatmentParams.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/PreTreatmentRecirc.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/Prime.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/Rinseback.c

(-2, +2)

| History

| Source

| Diff

… 5 more files in changeset.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-15196-DIAL-251' into staging

Michael Garthwaite — Tue, 16 May 2023 15:52:08 -0700

Michael Garthwaite committed c37d7a8 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

Merge branch 'DEN-15196-DIAL-251' into staging

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DIAL-251: code review comments.

Michael Garthwaite — Tue, 16 May 2023 14:03:19 -0700

Michael Garthwaite committed a1a592e on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 223 more in hdfirmware

DIAL-251: code review comments.

· /firmware/App/Modes/ModeTreatmentParams.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/PreTreatmentRecirc.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentRecirc.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-15196-DIAL-251

Michael Garthwaite — Tue, 16 May 2023 12:44:32 -0700

Michael Garthwaite committed d49b934 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 223 more in hdfirmware

Merge branch 'staging' into DEN-15196-DIAL-251

· /firmware/App/Modes/ModePreTreat.c	(-14, +37)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +30)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Tue, 16 May 2023 11:03:51 -0700

Dara Navaei committed 09e5006 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 223 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 16 May 2023 11:03:41 -0700

Dara Navaei committed a59f964 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 223 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModePreTreat.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-15229-fw-dpi-pump-on-during-inverted-dialyzer' into staging

Tue, 16 May 2023 10:55:29 -0700

Darren Cox committed cb18b44 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 223 more in hdfirmware

Merge branch 'DEN-15229-fw-dpi-pump-on-during-inverted-dialyzer' into staging

· /firmware/App/Modes/ModePreTreat.c

(-12, +35)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Tue, 16 May 2023 10:35:53 -0700

Dara Navaei committed bf3b0c4 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 223 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 16 May 2023 10:35:43 -0700

Dara Navaei committed bd08e87 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 223 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeStandby.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merged DIAL-252 to staging.

Sean Nash — Tue, 16 May 2023 10:32:57 -0700

Sean Nash committed 16572d5 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 223 more in hdfirmware

Merged DIAL-252 to staging.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-15196-DIAL-251

Michael Garthwaite — Tue, 16 May 2023 09:57:28 -0700

Michael Garthwaite committed 139d7ba on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 223 more in hdfirmware

Merge branch 'staging' into DEN-15196-DIAL-251

· /firmware/App/Modes/SelfTests.c

(-3, +3)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15274 fixed a typo

Dara Navaei — Tue, 16 May 2023 08:34:12 -0700

Dara Navaei committed 6aa0022 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

DEN-15274 fixed a typo

· /firmware/App/Modes/ModePreTreat.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-15274-hd_dg_test_configuration_setup

Dara Navaei — Tue, 16 May 2023 08:30:09 -0700

Dara Navaei committed f9c0896 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

Merge branch 'staging' into DEN-15274-hd_dg_test_configuration_setup

· /firmware/App/Controllers/Valves.c	(-54, +50)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-3, +3)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15274 addressed the code review comment

Dara Navaei — Mon, 15 May 2023 20:15:24 -0700

Dara Navaei committed b341967 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

DEN-15274 addressed the code review comment

· /firmware/App/Controllers/Valves.c	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-88, +74)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DIAL-252: Update to standby mode to handle alarms w/ stop property (will close valves).

Sean Nash — Mon, 15 May 2023 17:25:59 -0700

Sean Nash committed 80c4b42 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 224 more in hdfirmware

DIAL-252: Update to standby mode to handle alarms w/ stop property (will close valves).

· /firmware/App/Modes/ModeStandby.c

(-1, +30)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15229 Code review changes. Clear flag, no need to check door when required to be shut.

Mon, 15 May 2023 16:32:05 -0700

Darren Cox committed 85c561f on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 224 more in hdfirmware

DEN-15229 Code review changes. Clear flag, no need to check door when required to be shut.

· /firmware/App/Modes/ModePreTreat.c

(-3, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15274 added heating parameters set at the end of the pre-treatment reservoir management

Dara Navaei — Mon, 15 May 2023 15:40:38 -0700

Dara Navaei committed bd4f21c on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

DEN-15274 added heating parameters set at the end of the pre-treatment reservoir management

· /firmware/App/Modes/ModePreTreat.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15229 Code review update.

Mon, 15 May 2023 15:38:35 -0700

Darren Cox committed a73cb04 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 224 more in hdfirmware

DEN-15229 Code review update.

· /firmware/App/Modes/ModePreTreat.c

(-2, +4)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15229 Update based on code review comments.

Mon, 15 May 2023 14:37:26 -0700

Darren Cox committed d6a491c on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 224 more in hdfirmware

DEN-15229 Update based on code review comments.

· /firmware/App/Modes/ModePreTreat.c

(-5, +3)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Mon, 15 May 2023 14:25:25 -0700

Dara Navaei committed e381ca3 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 224 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 15 May 2023 14:25:15 -0700

Dara Navaei committed f4f7e0e on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 224 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Comm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Comm.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.h	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-15104-hd-fpga-communications' into staging

Mon, 15 May 2023 14:23:47 -0700

Bill Bracken committed 5c7fc70 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 224 more in hdfirmware

Merge branch 'DEN-15104-hd-fpga-communications' into staging

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15274 work in progress

Dara Navaei — Mon, 15 May 2023 14:21:30 -0700

Dara Navaei committed 00fc3c7 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 222 more in hdfirmware

DEN-15274 work in progress

· /firmware/App/Modes/ModePreTreat.c

(-5, +9)

| History

| Source

| Diff