· /alarmMapping.sh	(-1, +1)	| History	| Source	| Diff
· /cppcheck.sh	(-2, +2)	| History	| Source	| Diff
· /cr_objectives.sh	(-1, +1)	| History	| Source	| Diff
· /imake.sh	(-1, +1)	| History	| Source	| Diff
· /main.cpp	(-1, +1)	| History	| Source	| Diff
· /remove-exra-emptylines.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/autostart	(-2, +2)	| History	| Source	| Diff
· /scripts/bluetooth_paired_clear.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/bluetooth_paired_query.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/brightness_get.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/brightness_set.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/date_time_set.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/export_logs.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/globals.sh	(-3, +4)	| History	| Source	| Diff
· /scripts/run.sh	(-3, +3)	| History	| Source	| Diff
… 594 more files in changeset.

]]> Wed, 16 Feb 2022 10:10:27 -0800 Dara Navaei https://devapps.diality.us/changelog/application?cs=27cc308ff5113a9386899d3c8f8b29962a8498e1 https://devapps.diality.us/changelog/application?cs=27cc308ff5113a9386899d3c8f8b29962a8498e1 Dara Navaei committed 27cc308 on branch master, @Environement_Swith and 200 more in application Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh	(-7, +6)	| History	| Source	| Diff
· /cppcheck.sh	(-6, +6)	| History	| Source	| Diff
· /cr_objectives.sh	(-0, +15)	| History	| Source	| Diff
· /main.cpp	(-6, +6)	| History	| Source	| Diff
· /remove-exra-emptylines.sh	(-6, +6)	| History	| Source	| Diff
· /scripts/autostart	(-6, +6)	| History	| Source	| Diff
· /scripts/bluetooth_paired_clear.sh	(-6, +6)	| History	| Source	| Diff
· /scripts/bluetooth_paired_query.sh	(-6, +6)	| History	| Source	| Diff
· /scripts/brightness_get.sh	(-0, +15)	| History	| Source	| Diff
· /scripts/brightness_set.sh	(-0, +15)	| History	| Source	| Diff
· /scripts/date_time_set.sh	(-0, +15)	| History	| Source	| Diff
· /scripts/export_logs.sh	(-0, +15)	| History	| Source	| Diff
· /scripts/run.sh	(-6, +6)	| History	| Source	| Diff
· /scripts/setup.sh	(-6, +6)	| History	| Source	| Diff
· /scripts/start.sh	(-6, +6)	| History	| Source	| Diff
… 570 more files in changeset.

]]> Fri, 02 Jul 2021 09:19:46 -0700 plucia https://devapps.diality.us/cru/UI-DEN-8252-1 https://devapps.diality.us/cru/UI-DEN-8252-1 plucia  (deleted user) Closed UI-DEN-8252-1 ]]> Thu, 01 Jul 2021 11:54:10 -0700 https://devapps.diality.us/cru/UI-DEN-8252-1 https://devapps.diality.us/cru/UI-DEN-8252-1 Behrouz NematiPour finished reviewing UI-DEN-8252-1 UI-DEN-8252_POST ]]> Fri, 25 Jun 2021 12:53:23 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-8252-1/#c10331 https://devapps.diality.us/cru/UI-DEN-8252-1/#c10331 Behrouz NematiPour commented on UI-DEN-8252-1

Is it ready for review?

Note for reviewers:
I've created this review ahead of time
I am still working on the implementation

RESOLVED

RESOLVED

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

As we had a conversation, we will keep that in mind and should see how much that affects UI for something like Logging and so on.

As we had a conversation, the V&V request can be covered in the effort of the three stacks checking their versions and compatibility, then a message can be sent over the HD channel.

Added a FIXME which is more important than TODO.
Updated

Updated

Updated

Updated

remove the before anything

does not (instead of doesn't)

change (instead of changed)

Add TODO

V&V has requested to be able to get the version from the UI using dialin to automate their testing

The UI is already talking with Dialin. Your simulator is using dialin to talk to the UI.
Because the UI doesn't recognize Dialin at all, Dialin has to talk on the HD to UI or DG to UI channels instead when sending up commands to the UI.
This poses a security risk because the UI could never restrict communication to just the DG/HD only. If Dialin can talk to the UI on separate channels then those channels can be ignored in production mode later.

It's your stack so your call but something I think we should consider

If we decide UI to talk with Dialin we need to add Dialin channels later, but it is not the case now.