UI-DEN-8252-1 UI-DEN-8252_POST

closed on 02 Jul 21

Author

Moderator

Reviewers

UI-DEN-8252_POST

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 96

application 0
- Folder resources 0
  - Folder images 0
    - File RedCross.png 0 Remove
  - Folder settings 0
    - Folder Instructions 0
      - File Instructions.conf 0 Remove
      - File instructions.conf 0 Remove
    - Folder PowerOnSelfTests 0
      - File PowerOnSelfTests.conf 0 Remove
    - File Service.conf 0 Remove
    - File readme.md 0 Remove
- Folder scripts 0
  - File bluetoothctl_check.out 0 Remove
  - File brightness_set.sh 0 Remove
  - File checksums.conf 0 Remove
  - File checksums_desktop.conf 0 Remove
  - File checksums_target.conf 0 Remove
  - File copy.sh 0 Remove
  - File files_check.py 0 Remove
  - File modules_check.out 0 Remove
  - File rtc_check.out 0 Remove
  - File run.sh 0 Remove
  - File setup.sh 0 Remove
  - File touchscreen_check.out 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
    - File MessageInterpreter.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File Label.qml 0 Remove
        
        File MainMenu.qml 0 Remove
        
        File TextEntry.qml 0 Remove
        
        File TimeEntry.qml 0 Remove
        
        File WaitDone.qml 0 Remove
      - Folder compounds 0
        
        File CheckListScrollView.qml 0 Remove
        
        File CheckListView.qml 0 Remove
        
        File TouchGrid.qml 0 Remove
      - Folder dialogs 0
        
        File AlarmListDialog.qml 0 Remove
      - Folder pages 0
        
        Folder disinfect 0
        
        File DisinfectStack.qml 0 Remove
        
        Folder post 0
        
        File PostInProgress.qml 0 Remove
        
        Folder settings 0
        
        File SettingsBase.qml 0 Remove
        
        File SettingsDG.qml 0 Remove
        
        File SettingsDateTime.qml 0 Remove
        
        File SettingsHome.qml 0 Remove
        
        File SettingsStack.qml 0 Remove
        
        File SettingsWiFi.qml 0 Remove
        
        File MainStack.qml 0 Remove
        
        File TreatmentFlowBase.qml 0 Remove
        
        File UserConfirmation.qml 0 Remove
      - File AlarmItem.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
  - Folder model 0
    - Folder dg 0
      - Folder adjustment/settings 0
        
        File MAdjustDGRequests.h 0 Remove
      - Folder data 0
        
        File MDGPostFinalResultData.cpp 0 Remove
        
        File MDGPostFinalResultData.h 0 Remove
        
        File MDGPostSingleResultData.cpp 0 Remove
        
        File MDGPostSingleResultData.h 0 Remove
    - Folder hd 0
      - Folder adjustment/settings 0
        
        File MAdjustHDAlarmVolumeResponse.cpp 0 Remove
        
        File MAdjustHDAlarmVolumeResponse.h 0 Remove
        
        File MAdjustHDRequests.h 0 Remove
      - Folder alarm 0
        
        File MAlarmMapping.cpp 0 Remove
      - Folder data 0
        
        Folder treatmentlog 0
        
        File MTreatmentLogAlarmData.h 0 Remove
        
        File MHDPostFinalResultData.cpp 0 Remove
        
        File MHDPostFinalResultData.h 0 Remove
        
        File MHDPostSingleResultData.cpp 0 Remove
        
        File MHDPostSingleResultData.h 0 Remove
        
        File MHDRequestVersions.cpp 0 Remove
        
        File MHDRequestVersions.h 0 Remove
    - File MAbstract.h 0 Remove
    - File MModel.h 0 Remove
  - Folder storage 0
    - File Logger.cpp 0 Remove
    - File Logger.h 0 Remove
    - File Settings.cpp 0 Remove
    - File Settings.h 0 Remove
    - File StorageGlobals.cpp 0 Remove
    - File StorageGlobals.h 0 Remove
    - File TreatmentLog.cpp 0 Remove
  - Folder view 0
    - Folder dg/data 0
      - File VDGPostFinalResultData.cpp 0 Remove
      - File VDGPostFinalResultData.h 0 Remove
      - File VDGPostSingleResultData.cpp 0 Remove
      - File VDGPostSingleResultData.h 0 Remove
    - Folder hd 0
      - Folder alarm 0
        
        File VAlarmActiveList.cpp 0 Remove
        
        File VAlarmActiveList.h 0 Remove
      - Folder data 0
        
        Folder pretreatment 0
        
        File VPreTreatmentStatesData.cpp 0 Remove
        
        File VHDOperationModeData.cpp 0 Remove
        
        File VHDPostFinalResultData.cpp 0 Remove
        
        File VHDPostFinalResultData.h 0 Remove
        
        File VHDPostSingleResultData.cpp 0 Remove
        
        File VHDPostSingleResultData.h 0 Remove
    - Folder settings 0
      - File VSettings.cpp 0 Remove
    - File VUIPostSingleResultData.cpp 0 Remove
    - File VUIPostSingleResultData.h 0 Remove
    - File VUIPowerOnSelfTest.cpp 0 Remove
    - File VUIPowerOnSelfTest.h 0 Remove
    - File VView.h 0 Remove
- File alarmMapping 0 Remove
- File cppcheck.err 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File en_US.udic 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
plucia (deleted user)	Author & Moderator	7m	1	Note for reviewers: I've created this review ahead of tim...
Behrouz NematiPour	Reviewer - Complete	30m	1	Is it ready for review?
pmontazemi (deleted user)	Reviewer - Complete	4m
Total		41m	2

Linked issues
- DEN-8252
- DEN-8256
- DEN-8257
- DEN-8258
- DEN-8308
- DEN-8454
- DEN-8494
- DEN-8495
- DEN-8500
- DEN-8501
- DEN-8504
- DEN-8514
- DEN-8519

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

plucia (deleted user)

Note for reviewers: I've created this review ahead of time I am still working...

Note for reviewers:
I've created this review ahead of time
I am still working on the implementation

02 Jun 21

Behrouz NematiPour

Is it ready for review?

25 Jun 21

Click to load diff

/resources/.../Instructions/instructions.conf Deleted

Click to load diff

/resources/.../PowerOnSelfTests/PowerOnSelfTests.conf Deleted

Click to load diff

/sources/gui/.../pages/post/PostInProgress.qml Deleted

Click to load diff

/sources/view/VUIPostSingleResultData.cpp Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-8252-1

UI-DEN-8252_POST

UI-DEN-8252-1 2

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

plucia (deleted user)

Behrouz NematiPour

Log time

UI-DEN-8252_POST

UI-DEN-8252-1 2

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

plucia (deleted user)

Behrouz NematiPour

Log time