Fisheye on hdfirmware/firmware

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15536 addressed the code review comments

Dara Navaei — Mon, 24 Jul 2023 09:21:48 -0700

Dara Navaei committed 1193ff9 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 174 more in hdfirmware

DEN-15536 addressed the code review comments

· /firmware/App/Modes/ModeTreatment.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-2, +3)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Merge branch 'staging' into DEN-15536-fw-usability-dry-self-tests-did-not-repeat-after-dry-self-test-failure

Dara Navaei — Mon, 24 Jul 2023 09:16:53 -0700

Dara Navaei committed 4064ee2 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 174 more in hdfirmware

Merge branch 'staging' into DEN-15536-fw-usability-dry-self-tests-did-not-repeat-after-dry-self-test-failure

· /firmware/App/Modes/ModeTreatment.c

(-14, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Fri, 21 Jul 2023 18:01:28 -0700

Dara Navaei committed 5cebc8a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 174 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 21 Jul 2023 18:01:14 -0700

Dara Navaei committed 16b0238 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 174 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodLeak.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15536: Addressed DEN-15898.

Sean Nash — Fri, 21 Jul 2023 17:19:16 -0700

Sean Nash committed 59ba490 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 174 more in hdfirmware

DEN-15536: Addressed DEN-15898.

· /firmware/App/Modes/ModeTreatment.c	(-2, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-6, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-8, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentRecirc.c	(-6, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15536: Fix +/- 15 mmHg check on offset.

Sean Nash — Fri, 21 Jul 2023 15:26:53 -0700

Sean Nash committed b91f035 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 174 more in hdfirmware

DEN-15536: Fix +/- 15 mmHg check on offset.

· /firmware/App/Controllers/PresOccl.c

(-1, +8)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-64 removed DPo from bypass detection in blood leak driver

Dara Navaei — Fri, 21 Jul 2023 11:15:35 -0700

Dara Navaei committed 9391789 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 175 more in hdfirmware

DENBUG-64 removed DPo from bypass detection in blood leak driver

· /firmware/App/Controllers/BloodLeak.c

(-1, +0)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Merge branch 'staging' into DENBUG-64-sys-dialyzer-blood-leak-alarm-triggered-during-treatment

Dara Navaei — Fri, 21 Jul 2023 08:19:19 -0700

Dara Navaei committed e01f7b4 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 175 more in hdfirmware

Merge branch 'staging' into DENBUG-64-sys-dialyzer-blood-leak-alarm-triggered-during-treatment

· /firmware/App/HDCommon.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-21, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-16, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Thu, 20 Jul 2023 23:36:05 -0700

Dara Navaei committed 5b8439d on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 176 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 20 Jul 2023 23:35:52 -0700

Dara Navaei committed 9353792 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 176 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14934: Updated blood flow estimation coefficients.

Sean Nash — Thu, 20 Jul 2023 15:47:27 -0700

Sean Nash committed 31b6217 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 177 more in hdfirmware

DEN-14934: Updated blood flow estimation coefficients.

· /firmware/App/Controllers/BloodFlow.c

(-3, +3)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14934: Addressed code review comments.

Sean Nash — Thu, 20 Jul 2023 15:26:17 -0700

Sean Nash committed 419f50d on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 177 more in hdfirmware

DEN-14934: Addressed code review comments.

· /firmware/App/Modes/Rinseback.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14934: Addressed DEN-15536.

Sean Nash — Thu, 20 Jul 2023 13:34:39 -0700

Sean Nash committed 727f304 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 177 more in hdfirmware

DEN-14934: Addressed DEN-15536.

· /firmware/App/Controllers/PresOccl.c	(-5, +41)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +5)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14934: Adjusted DPo flow filter time and flow correction coefficient.

Sean Nash — Thu, 20 Jul 2023 09:53:59 -0700

Sean Nash committed 495f23d on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 177 more in hdfirmware

DEN-14934: Adjusted DPo flow filter time and flow correction coefficient.

· /firmware/App/Controllers/DialOutFlow.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14934: Aligned rotor vs motor speed alarm threshold with requirements.

Sean Nash — Thu, 20 Jul 2023 08:59:55 -0700

Sean Nash committed 7c8130c on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 177 more in hdfirmware

DEN-14934: Aligned rotor vs motor speed alarm threshold with requirements.

· /firmware/App/Controllers/BloodFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14934: Addressed DEN-15769 re: removal of UF volume change option to adjust treatment duration.

Sean Nash — Wed, 19 Jul 2023 18:22:02 -0700

Sean Nash committed 672ea05 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 177 more in hdfirmware

DEN-14934: Addressed DEN-15769 re: removal of UF volume change option to adjust treatment duration.

· /firmware/App/Modes/ModeTreatment.c

(-20, +4)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14934: Added new rinseback state to instruct user to reconnect patient before returning to treatment.

Sean Nash — Wed, 19 Jul 2023 17:49:15 -0700

Sean Nash committed 0bdf0c3 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 177 more in hdfirmware

DEN-14934: Added new rinseback state to instruct user to reconnect patient before returning to treatment.

· /firmware/App/Modes/Rinseback.c

(-2, +42)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Wed, 19 Jul 2023 13:57:59 -0700

Dara Navaei committed 1a77559 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 178 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 19 Jul 2023 13:57:51 -0700

Dara Navaei committed 487d352 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 178 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Merged staging to DEN-15844.

Sean Nash — Wed, 19 Jul 2023 13:49:52 -0700

Sean Nash committed 43937ee on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 179 more in hdfirmware

Merged staging to DEN-15844.

· /firmware/App/Modes/SelfTests.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-64 addressed a code review comment

Dara Navaei — Wed, 19 Jul 2023 13:28:21 -0700

Dara Navaei committed e21e33d on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 175 more in hdfirmware

DENBUG-64 addressed a code review comment

· /firmware/App/Modes/TreatmentStop.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15844: Addressed code review comment.

Sean Nash — Wed, 19 Jul 2023 13:26:19 -0700

Sean Nash committed e30c448 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 179 more in hdfirmware

DEN-15844: Addressed code review comment.

· /firmware/App/Modes/SelfTests.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-64 changed the blood detect code to not check for blood when the dialysate line is in bypass mode

Dara Navaei — Wed, 19 Jul 2023 09:14:21 -0700

Dara Navaei committed c7d760a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 175 more in hdfirmware

DENBUG-64 changed the blood detect code to not check for blood when the dialysate line is in bypass mode

· /firmware/App/Controllers/BloodLeak.c

(-29, +52)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15844: Fix to DEN-15865.

Sean Nash — Wed, 19 Jul 2023 08:34:55 -0700

Sean Nash committed daddf3a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 179 more in hdfirmware

DEN-15844: Fix to DEN-15865.

· /firmware/App/Modes/SelfTests.c

(-0, +4)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15844: Addressed DEN-15865 re: occlusion baseline not getting set.

Sean Nash — Tue, 18 Jul 2023 13:48:57 -0700

Sean Nash committed 28792eb on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 179 more in hdfirmware

DEN-15844: Addressed DEN-15865 re: occlusion baseline not getting set.

· /firmware/App/Controllers/PresOccl.c	(-375, +375)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-55, +55)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-1, +10)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-14, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-1, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-64 addressed the code review comments

Dara Navaei — Tue, 18 Jul 2023 13:04:14 -0700

Dara Navaei committed f14422a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 175 more in hdfirmware

DENBUG-64 addressed the code review comments

· /firmware/App/Controllers/BloodLeak.c	(-31, +6)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-5, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-64 changed the code to constantly reset the blood sitting timer in treatment stop recover blood detections state

Dara Navaei — Tue, 18 Jul 2023 12:47:36 -0700

Dara Navaei committed 4f4bccc on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 175 more in hdfirmware

DENBUG-64 changed the code to constantly reset the blood sitting timer in treatment stop recover blood detections state

· /firmware/App/Modes/TreatmentStop.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-64 updated the blood leak sensor code

Dara Navaei — Tue, 18 Jul 2023 11:22:36 -0700

Dara Navaei committed fe82031 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 175 more in hdfirmware

DENBUG-64 updated the blood leak sensor code

· /firmware/App/Controllers/BloodLeak.c	(-2, +10)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-1, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-64 addressed the code review comments

Dara Navaei — Tue, 18 Jul 2023 11:12:11 -0700

Dara Navaei committed f0745a4 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 175 more in hdfirmware

DENBUG-64 addressed the code review comments

· /firmware/App/Controllers/BloodLeak.c	(-11, +39)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-15, +21)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-64 work in progress updated the blood detect algorithm

Dara Navaei — Tue, 18 Jul 2023 10:05:55 -0700

Dara Navaei committed 90d598a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 175 more in hdfirmware

DENBUG-64 work in progress updated the blood detect algorithm

· /firmware/App/Controllers/BloodLeak.c	(-17, +61)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-24, +31)	\| History	\| Source	\| Diff