Fisheye on hdfirmware/firmware/App

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15660 addressed a code review comment

Dara Navaei — Thu, 13 Jul 2023 10:48:57 -0700

Dara Navaei committed 1ab9ca9 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 182 more in hdfirmware

DEN-15660 addressed a code review comment

· /firmware/App/Controllers/BloodLeak.c

(-1, +0)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15628 changed the blood leak zero sequence counter from Z to G since Z is repeated twice in each zero sequence

Dara Navaei — Thu, 13 Jul 2023 09:49:50 -0700

Dara Navaei committed 248262d on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 182 more in hdfirmware

DEN-15628 changed the blood leak zero sequence counter from Z to G since Z is repeated twice in each zero sequence

· /firmware/App/Controllers/BloodLeak.c	(-4, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15660, DEN-15721 added code to check the blood detection in treatment and service mode both

Dara Navaei — Wed, 12 Jul 2023 14:53:21 -0700

Dara Navaei committed b397539 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 182 more in hdfirmware

DEN-15660, DEN-15721 added code to check the blood detection in treatment and service mode both

· /firmware/App/Controllers/BloodLeak.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Merge branch 'staging' into DEN-15660-test_configuration_treatment_recovery

Dara Navaei — Wed, 12 Jul 2023 13:22:49 -0700

Dara Navaei committed 556668d on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 182 more in hdfirmware

Merge branch 'staging' into DEN-15660-test_configuration_treatment_recovery

· /firmware/App/Modes/ModeTreatment.c	(-7, +26)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-14, +17)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-36, +60)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +35)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Wed, 12 Jul 2023 11:24:17 -0700

Dara Navaei committed ba42315 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 182 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 12 Jul 2023 11:24:10 -0700

Dara Navaei committed d608769 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 182 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirTrap.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15556: Addressed code review comments.

Sean Nash — Wed, 12 Jul 2023 10:07:39 -0700

Sean Nash committed 53274f1 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 183 more in hdfirmware

DEN-15556: Addressed code review comments.

· /firmware/App/Modes/ModePreTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-3, +4)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15556: Fix to last.

Sean Nash — Tue, 11 Jul 2023 15:34:14 -0700

Sean Nash committed db75192 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 183 more in hdfirmware

DEN-15556: Fix to last.

· /firmware/App/Modes/SelfTests.c

(-1, +8)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15556: Stabilize pressures after UF rate change.

Sean Nash — Tue, 11 Jul 2023 14:03:03 -0700

Sean Nash committed ce8cdf9 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 183 more in hdfirmware

DEN-15556: Stabilize pressures after UF rate change.

· /firmware/App/Controllers/AirTrap.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15556: Addressed issues for DEN-15556 re: not repeating used cartridge test and openeing VBA after door closed after...

Sean Nash — Tue, 11 Jul 2023 12:48:28 -0700

Sean Nash committed 5aa849d on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 183 more in hdfirmware

DEN-15556: Addressed issues for DEN-15556 re: not repeating used cartridge test and openeing VBA after door closed after cartridge install to prevent saline from leaking into the line.

· /firmware/App/Modes/ModePreTreat.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-4, +43)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.h	(-0, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15660, DEN-15809 updated the code

Dara Navaei — Mon, 10 Jul 2023 17:22:17 -0700

Dara Navaei committed 8a9a5cd on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 182 more in hdfirmware

DEN-15660, DEN-15809 updated the code

· /firmware/App/Services/Reservoirs.c

(-6, +6)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15660 uncommented the code

Dara Navaei — Mon, 10 Jul 2023 16:49:56 -0700

Dara Navaei committed 2559cb6 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 182 more in hdfirmware

DEN-15660 uncommented the code

· /firmware/App/Controllers/BloodLeak.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Mon, 10 Jul 2023 16:02:36 -0700

Dara Navaei committed 3848da7 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 184 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 10 Jul 2023 16:02:21 -0700

Dara Navaei committed ffaf9f1 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 184 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirTrap.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskBG.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Addressed code review comments.

Sean Nash — Mon, 10 Jul 2023 15:33:03 -0700

Sean Nash committed 2564e23 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Addressed code review comments.

· /firmware/App/Controllers/DialOutFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-2, +4)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: increased timeout period for dialysate prime state of pre-tx.

Sean Nash — Mon, 10 Jul 2023 14:48:09 -0700

Sean Nash committed ba64f5e on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: increased timeout period for dialysate prime state of pre-tx.

· /firmware/App/Modes/Prime.c

(-3, +7)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: adjusted timing of uf rate calculation to clean up logging issues.

Sean Nash — Mon, 10 Jul 2023 13:35:30 -0700

Sean Nash committed 6442d95 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: adjusted timing of uf rate calculation to clean up logging issues.

· /firmware/App/Controllers/DialOutFlow.c

(-13, +22)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15660 disabled alarm 63 for testing

Dara Navaei — Mon, 10 Jul 2023 08:15:55 -0700

Dara Navaei committed be75ea1 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 182 more in hdfirmware

DEN-15660 disabled alarm 63 for testing

· /firmware/App/Controllers/BloodLeak.c

(-4, +4)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Changed clear persistence behavior for illegal air trap alarm. Additional refinements to UF control start up...

Sean Nash — Sat, 08 Jul 2023 12:25:49 -0700

Sean Nash committed 2a30143 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Changed clear persistence behavior for illegal air trap alarm. Additional refinements to UF control start up.

· /firmware/App/Controllers/AirTrap.c	(-4, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-7, +24)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Addressed code review comment.

Sean Nash — Fri, 07 Jul 2023 14:56:04 -0700

Sean Nash committed b983007 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Addressed code review comment.

· /firmware/App/Controllers/DialOutFlow.c

(-2, +5)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: set DG mode to fault if DG comm is lost.

Sean Nash — Fri, 07 Jul 2023 14:23:12 -0700

Sean Nash committed 3635df0 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: set DG mode to fault if DG comm is lost.

· /firmware/App/Controllers/DGInterface.c	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Tuning of start of UF control per data.

Sean Nash — Thu, 06 Jul 2023 18:48:25 -0700

Sean Nash committed 17c0be2 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Tuning of start of UF control per data.

· /firmware/App/Controllers/DialOutFlow.c	(-10, +9)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-2, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: more updates to start of UF control.

Sean Nash — Wed, 05 Jul 2023 18:13:50 -0700

Sean Nash committed bd1a180 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: more updates to start of UF control.

· /firmware/App/Controllers/DialOutFlow.c

(-5, +7)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Addressed DEN-15779.

Sean Nash — Wed, 05 Jul 2023 13:38:12 -0700

Sean Nash committed d367cda on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Addressed DEN-15779.

· /firmware/App/Modes/Prime.c

(-6, +0)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Addressed DEN-15729.

Sean Nash — Wed, 05 Jul 2023 13:13:53 -0700

Sean Nash committed 09c17bf on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Addressed DEN-15729.

· /firmware/App/Modes/SelfTests.c

(-12, +4)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Addressed code review comment.

Sean Nash — Wed, 05 Jul 2023 12:52:56 -0700

Sean Nash committed 50082d7 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Addressed code review comment.

· /firmware/App/Controllers/DGInterface.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Additional fix for DEN-15763 to allow post-tx to drain reservoirs if DG was restarted (alarm 107).

Sean Nash — Wed, 05 Jul 2023 10:11:55 -0700

Sean Nash committed e283a8f on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Additional fix for DEN-15763 to allow post-tx to drain reservoirs if DG was restarted (alarm 107).

· /firmware/App/Controllers/AirTrap.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-4, +9)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Clear preserved POR bit for logging purposes after logged.

Sean Nash — Fri, 30 Jun 2023 14:43:12 -0700

Sean Nash committed 2589063 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Clear preserved POR bit for logging purposes after logged.

· /firmware/App/Modes/ModeInitPOST.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Addressed DEN-15763. Increased max UI boot time from 40 sec to 2 min.

Sean Nash — Thu, 29 Jun 2023 13:01:16 -0700

Sean Nash committed 85e78f8 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Addressed DEN-15763. Increased max UI boot time from 40 sec to 2 min.

· /firmware/App/Controllers/DGInterface.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskBG.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Thu, 29 Jun 2023 12:17:54 -0700

Dara Navaei committed 300320d on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff