Fisheye on dgfirmware/firmware

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15701: handle stop DG command from HD while in standby water sampling states.

Sean Nash — Thu, 22 Jun 2023 09:11:14 -0700

Sean Nash committed 79b494c on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 104 more in dgfirmware

DEN-15701: handle stop DG command from HD while in standby water sampling states.

· /firmware/App/Modes/ModeStandby.c	(-0, +23)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-15, +16)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 21 Jun 2023 11:19:20 -0700

Dara Navaei committed 299bd11 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 104 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 21 Jun 2023 11:19:11 -0700

Dara Navaei committed 12c382b on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 104 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15647 addressed the code review comments

Dara Navaei — Wed, 21 Jun 2023 11:14:16 -0700

Dara Navaei committed 3ed05da on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 105 more in dgfirmware

DEN-15647 addressed the code review comments

· /firmware/App/Modes/ModeFlush.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15610 fixed DG flush to write basic flush complete timestamp in the usage record

Dara Navaei — Tue, 20 Jun 2023 17:31:51 -0700

Dara Navaei committed 4db653d on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 105 more in dgfirmware

DEN-15610 fixed DG flush to write basic flush complete timestamp in the usage record

· /firmware/App/Modes/ModeFlush.c

(-3, +8)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15647 updated the heat disinfect active cool mode to deenergize the actuators prior to transitioning to cancel water...

Dara Navaei — Tue, 20 Jun 2023 16:00:47 -0700

Dara Navaei committed f62fc45 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 105 more in dgfirmware

DEN-15647 updated the heat disinfect active cool mode to deenergize the actuators prior to transitioning to cancel water path state

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c

(-1, +8)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 15 Jun 2023 17:09:52 -0700

Dara Navaei committed f0a4d2a on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 106 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 15 Jun 2023 17:09:43 -0700

Dara Navaei committed a683ad9 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 106 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15571 updated the code

Dara Navaei — Thu, 15 Jun 2023 16:29:16 -0700

Dara Navaei committed 056d73c on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 107 more in dgfirmware

DEN-15571 updated the code

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +3)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15571, DEN-15398 changed the fill mode full speed prime time from 8 seconds to 7 seconds

Dara Navaei — Thu, 15 Jun 2023 16:24:36 -0700

Dara Navaei committed 47e9d94 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 107 more in dgfirmware

DEN-15571, DEN-15398 changed the fill mode full speed prime time from 8 seconds to 7 seconds

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15571 addressed the code review comments

Dara Navaei — Thu, 15 Jun 2023 16:22:56 -0700

Dara Navaei committed 53fa5b7 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 107 more in dgfirmware

DEN-15571 addressed the code review comments

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-14, +11)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15571 updated the chemical disinfect drain status function

Dara Navaei — Thu, 15 Jun 2023 13:55:51 -0700

Dara Navaei committed 0970cd6 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 107 more in dgfirmware

DEN-15571 updated the chemical disinfect drain status function

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +5)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15443 added code to transition back to ramp state in concenrate pumps if the new requested target speed is greater t...

Dara Navaei — Wed, 14 Jun 2023 15:50:09 -0700

Dara Navaei committed a1feadd on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 107 more in dgfirmware

DEN-15443 added code to transition back to ramp state in concenrate pumps if the new requested target speed is greater than the threshold

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +11)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15571 made changes in the chemical disinfect mode to not trigger the max temeprature and conductivity out of range u...

Dara Navaei — Wed, 14 Jun 2023 15:24:35 -0700

Dara Navaei committed 995ac63 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 107 more in dgfirmware

DEN-15571 made changes in the chemical disinfect mode to not trigger the max temeprature and conductivity out of range until the end of the chemical disinfect mode

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-18, +20)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 14 Jun 2023 09:57:14 -0700

Dara Navaei committed 221ed35 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 107 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 14 Jun 2023 09:57:02 -0700

Dara Navaei committed d325999 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 107 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c

(-1, +1)

| History

| Source

| Diff

… 11 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'staging' into DEN-15367-hd_dg_test_configuration_setup

Dara Navaei — Wed, 14 Jun 2023 09:09:25 -0700

Dara Navaei committed 80b41ef on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

Merge branch 'staging' into DEN-15367-hd_dg_test_configuration_setup

· /firmware/App/Controllers/DrainPump.c

(-7, +21)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14657 removed code to not check the error bit of a temperature sensor and let the temperature out of range alarm tri...

Dara Navaei — Tue, 13 Jun 2023 17:04:01 -0700

Dara Navaei committed 1a4ffea on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

DEN-14657 removed code to not check the error bit of a temperature sensor and let the temperature out of range alarm trigger the alarm

· /firmware/App/Controllers/TemperatureSensors.c

(-52, +3)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15571 changed the chemical disinfect temperature timeout from 1 minute to 5 minutes

Dara Navaei — Tue, 13 Jun 2023 13:56:00 -0700

Dara Navaei committed 2024427 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

DEN-15571 changed the chemical disinfect temperature timeout from 1 minute to 5 minutes

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15367 removed the payload from the message that informs HD that DG is ready to dispense more fluid in DG. DEN-15571 ...

Dara Navaei — Tue, 13 Jun 2023 13:33:32 -0700

Dara Navaei committed 5e47cac on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

DEN-15367 removed the payload from the message that informs HD that DG is ready to dispense more fluid in DG. DEN-15571 fixed the chemical disinfect state machine to transition to cancel water path once the target temperature was not reached within the specified time

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-6, +11)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15367 addressed a code review comment

Dara Navaei — Tue, 13 Jun 2023 12:42:39 -0700

Dara Navaei committed fc05ef5 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

DEN-15367 addressed a code review comment

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15367 addressed the code review comments

Dara Navaei — Tue, 13 Jun 2023 10:37:58 -0700

Dara Navaei committed fab0257 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

DEN-15367 addressed the code review comments

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-7, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-3, +14)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 12 Jun 2023 17:35:28 -0700

Dara Navaei committed e660d2a on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 12 Jun 2023 17:35:17 -0700

Dara Navaei committed cb3489c on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DrainPump.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15522 fixed the heat disinfect active cool fill timeout not triggering. DEN-14805 fixed chemical disinfect reservoir...

Dara Navaei — Mon, 12 Jun 2023 13:55:08 -0700

Dara Navaei committed 653a028 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

DEN-15522 fixed the heat disinfect active cool fill timeout not triggering. DEN-14805 fixed chemical disinfect reservoir leak alarm

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-4, +13)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-6, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15367 changed the RO permeate sample cancel water path. DEN-14004 changed the request message from UI to 0x89. DEN-1...

Dara Navaei — Sun, 11 Jun 2023 20:28:08 -0700

Dara Navaei committed ac305d5 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

DEN-15367 changed the RO permeate sample cancel water path. DEN-14004 changed the request message from UI to 0x89. DEN-15509 changed the reservoir threshold from 1700 to 1850 mL. DEN-15192 changed the concentrate pump low speed threshold.

· /firmware/App/Controllers/ConcentratePumps.c	(-10, +14)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-5, +10)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): -DEN-15367 fixed the transition to cancel water path in RO permeate sample mode -DEN-14004 changed the request message I...

Dara Navaei — Sun, 11 Jun 2023 14:24:32 -0700

Dara Navaei committed 66fe4aa on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

-DEN-15367 fixed the transition to cancel water path in RO permeate sample mode -DEN-14004 changed the request message ID to 0x89 from UI to send the DG service record -DEN-15192 changed the concentrate pumps low speed check threshold -DEN-15509 changed the reservoir full threshold from 1700 mL to 1850 mL.

· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-8, +43)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14004 added another message to receive and send DG service record upon request from HD. The format of the payload is...

Dara Navaei — Sun, 11 Jun 2023 14:24:32 -0700

Dara Navaei committed 2e0a2f8 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

DEN-14004 added another message to receive and send DG service record upon request from HD. The format of the payload is different from the format that is sent to UI

· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-8, +43)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15367, DEN-15389, DEN-15511, DEN-15443 added code in the mode fill to check for the conductivity of the values in th...

Dara Navaei — Sat, 10 Jun 2023 18:04:56 -0700

Dara Navaei committed 673b5a1 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

DEN-15367, DEN-15389, DEN-15511, DEN-15443 added code in the mode fill to check for the conductivity of the values in the produce state and have a timeout. Removed the acid check at the end of the mode fill

· /firmware/App/Controllers/ConcentratePumps.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-237, +219)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15367, DEN-15404 worked on RO permeate sample mode

Dara Navaei — Fri, 09 Jun 2023 17:42:57 -0700

Dara Navaei committed 8822f86 on branch master, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 108 more in dgfirmware

DEN-15367, DEN-15404 worked on RO permeate sample mode

· /firmware/App/Controllers/ROPump.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-7, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.h	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff