Fisheye on hdfirmware/firmware/App/Controllers

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Addressed code review comments.

Sean Nash — Mon, 10 Jul 2023 15:33:03 -0700

Sean Nash committed 2564e23 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Addressed code review comments.

· /firmware/App/Controllers/DialOutFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-2, +4)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: adjusted timing of uf rate calculation to clean up logging issues.

Sean Nash — Mon, 10 Jul 2023 13:35:30 -0700

Sean Nash committed 6442d95 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: adjusted timing of uf rate calculation to clean up logging issues.

· /firmware/App/Controllers/DialOutFlow.c

(-13, +22)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Changed clear persistence behavior for illegal air trap alarm. Additional refinements to UF control start up...

Sean Nash — Sat, 08 Jul 2023 12:25:49 -0700

Sean Nash committed 2a30143 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Changed clear persistence behavior for illegal air trap alarm. Additional refinements to UF control start up.

· /firmware/App/Controllers/AirTrap.c	(-4, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-7, +24)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Addressed code review comment.

Sean Nash — Fri, 07 Jul 2023 14:56:04 -0700

Sean Nash committed b983007 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Addressed code review comment.

· /firmware/App/Controllers/DialOutFlow.c

(-2, +5)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: set DG mode to fault if DG comm is lost.

Sean Nash — Fri, 07 Jul 2023 14:23:12 -0700

Sean Nash committed 3635df0 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: set DG mode to fault if DG comm is lost.

· /firmware/App/Controllers/DGInterface.c	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Tuning of start of UF control per data.

Sean Nash — Thu, 06 Jul 2023 18:48:25 -0700

Sean Nash committed 17c0be2 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Tuning of start of UF control per data.

· /firmware/App/Controllers/DialOutFlow.c	(-10, +9)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-2, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: more updates to start of UF control.

Sean Nash — Wed, 05 Jul 2023 18:13:50 -0700

Sean Nash committed bd1a180 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: more updates to start of UF control.

· /firmware/App/Controllers/DialOutFlow.c

(-5, +7)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Addressed code review comment.

Sean Nash — Wed, 05 Jul 2023 12:52:56 -0700

Sean Nash committed 50082d7 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Addressed code review comment.

· /firmware/App/Controllers/DGInterface.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Additional fix for DEN-15763 to allow post-tx to drain reservoirs if DG was restarted (alarm 107).

Sean Nash — Wed, 05 Jul 2023 10:11:55 -0700

Sean Nash committed e283a8f on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Additional fix for DEN-15763 to allow post-tx to drain reservoirs if DG was restarted (alarm 107).

· /firmware/App/Controllers/AirTrap.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-4, +9)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15763: Addressed DEN-15763. Increased max UI boot time from 40 sec to 2 min.

Sean Nash — Thu, 29 Jun 2023 13:01:16 -0700

Sean Nash committed 85e78f8 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 185 more in hdfirmware

DEN-15763: Addressed DEN-15763. Increased max UI boot time from 40 sec to 2 min.

· /firmware/App/Controllers/DGInterface.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskBG.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 26 Jun 2023 13:01:53 -0700

Dara Navaei committed 4f3b9e1 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 189 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/PresOccl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15282: Reverted pressure stabilization time back to 60s from 30s. During rinseback run and paused states, allow res...

Sean Nash — Fri, 23 Jun 2023 15:28:40 -0700

Sean Nash committed e7b6540 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 190 more in hdfirmware

DEN-15282: Reverted pressure stabilization time back to 60s from 30s. During rinseback run and paused states, allow resume and end tx options for alarms - resume will resume rinseback.

· /firmware/App/Controllers/PresOccl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +18)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-0, +25)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-3, +3)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 21 Jun 2023 18:31:44 -0700

Dara Navaei committed eae4d66 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 191 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialInFlow.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-63 Updated coefficients for DPi flow calculations.

Wed, 21 Jun 2023 14:36:02 -0700

Darren Cox committed 5516bb4 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 192 more in hdfirmware

DENBUG-63 Updated coefficients for DPi flow calculations.

· /firmware/App/Controllers/DialInFlow.c

(-6, +6)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 15 Jun 2023 13:03:58 -0700

Dara Navaei committed 97e1c0a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 194 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-0, +16)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15489: Addressed issue with preventing pumps to be commanded to top speed.

Sean Nash — Wed, 14 Jun 2023 15:34:30 -0700

Sean Nash committed 6d19d84 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 195 more in hdfirmware

DEN-15489: Addressed issue with preventing pumps to be commanded to top speed.

· /firmware/App/Controllers/BloodFlow.c	(-2, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 14 Jun 2023 10:26:03 -0700

Dara Navaei committed f1157c7 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 197 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodLeak.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15367 merged staging

Dara Navaei — Wed, 14 Jun 2023 09:56:47 -0700

Dara Navaei committed e63dcc4 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

DEN-15367 merged staging

· /firmware/App/Controllers/BloodLeak.c	(-8, +15)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-11, +15)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 14 Jun 2023 09:25:02 -0700

Dara Navaei committed e288ab9 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/PresOccl.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15367 addressed the code review comments. Added code to check the payload of the message that is received from DG to...

Dara Navaei — Tue, 13 Jun 2023 15:34:29 -0700

Dara Navaei committed f249310 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

DEN-15367 addressed the code review comments. Added code to check the payload of the message that is received from DG to indicate that DG is ready to dispense more water in RO permeate sample mode

· /firmware/App/Controllers/BloodLeak.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-9, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15558: Addressed code review comment.

Sean Nash — Tue, 13 Jun 2023 15:32:40 -0700

Sean Nash committed f0e53bc on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

DEN-15558: Addressed code review comment.

· /firmware/App/Controllers/PresOccl.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15558: Extend exemption for venous low pressure alarm during air trap fill for 5 seconds after fill to allow pressur...

Sean Nash — Tue, 13 Jun 2023 12:34:47 -0700

Sean Nash committed bafedda on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

DEN-15558: Extend exemption for venous low pressure alarm during air trap fill for 5 seconds after fill to allow pressure to recover.

· /firmware/App/Controllers/PresOccl.c

(-17, +29)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 13 Jun 2023 10:35:30 -0700

Dara Navaei committed b442cce on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodLeak.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-15363-fw-handle-bld-sensor-communication-errors' into staging

Tue, 13 Jun 2023 10:33:57 -0700

Bill Bracken committed 0c966d9 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

Merge branch 'DEN-15363-fw-handle-bld-sensor-communication-errors' into staging

· /firmware/App/Controllers/BloodLeak.c

(-5, +12)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15558: Reversed temporary change in dialyzer prime BP speed. Increased max venous pressure from 300 to 400 mmHg.

Sean Nash — Tue, 13 Jun 2023 09:46:39 -0700

Sean Nash committed 68e6a5f on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

DEN-15558: Reversed temporary change in dialyzer prime BP speed. Increased max venous pressure from 300 to 400 mmHg.

· /firmware/App/Controllers/PresOccl.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-6, +6)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 12 Jun 2023 16:41:06 -0700

Dara Navaei committed 6b26db8 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15459 changed the blood leak alarm detection to not trigger if the HD mode is not in treatment

Dara Navaei — Mon, 12 Jun 2023 16:24:53 -0700

Dara Navaei committed c2bd959 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 200 more in hdfirmware

DEN-15459 changed the blood leak alarm detection to not trigger if the HD mode is not in treatment

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 12 Jun 2023 15:09:37 -0700

Dara Navaei committed 8d44b80 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 200 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodFlow.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-15363-fw-handle-bld-sensor-communication-errors

Mon, 12 Jun 2023 10:52:33 -0700

Bill Bracken committed 63e285c on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 200 more in hdfirmware

Merge branch 'staging' into DEN-15363-fw-handle-bld-sensor-communication-errors

· /firmware/App/Controllers/BloodLeak.c

(-2, +3)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-15367 addressed the code review comments

Dara Navaei — Mon, 12 Jun 2023 09:13:46 -0700

Dara Navaei committed 437ac34 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more in hdfirmware

DEN-15367 addressed the code review comments

· /firmware/App/Controllers/BloodLeak.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-4, +5)	\| History	\| Source	\| Diff