Fisheye on dgfirmware/firmware/App/Controllers/Thermistors.h https://devapps.diality.us/changelog/~br%3DDEN-15791-dg-software-design-description/dgfirmware/firmware/App/Controllers/Thermistors.h Recent activity in "dgfirmware" under directory /firmware/App/Controllers/Thermistors.h DG-DEN-3421-1: closed by Dara Navaei Thu, 19 Oct 2023 08:34:58 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-3421-1 https://devapps.diality.us/cru/DG-DEN-3421-1 Dara Navaei Closed DG-DEN-3421-1 ]]> DG-DEN-3421-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:34:41 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-3421-1/#c19107 https://devapps.diality.us/cru/DG-DEN-3421-1/#c19107 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-3421-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-3421-1: reviewers resumed Thu, 19 Oct 2023 08:29:12 -0700 https://devapps.diality.us/cru/DG-DEN-3421-1 https://devapps.diality.us/cru/DG-DEN-3421-1 pmontazemi  (deleted user) , qnguyen  (deleted user) and Sean Nash resumed reviewing DG-DEN-3421-1 DG-DEN-3421_DG Heat Disinfection ]]> DG-DEN-3421-1: started by Dara Navaei Thu, 19 Oct 2023 08:29:07 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-3421-1 https://devapps.diality.us/cru/DG-DEN-3421-1 Dara Navaei started review DG-DEN-3421-1 ]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 18 Jan 2023 14:11:22 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=34ae229d1508df89630f4dc5fbe9291d135f0686 https://devapps.diality.us/changelog/dgfirmware?cs=34ae229d1508df89630f4dc5fbe9291d135f0686 Dara Navaei committed 34ae229 on branch DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13972-flush-bubbles-ro-pump-state-does-not-match-srsdg-844 and 166 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Thermistors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Thermistors.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-2, +2) | History | Source | Diff
]]> DG-DEN-13946-1: closed by Dara Navaei Wed, 18 Jan 2023 14:05:06 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13946-1 https://devapps.diality.us/cru/DG-DEN-13946-1 Dara Navaei Closed DG-DEN-13946-1 ]]> DG-DEN-13946-1: reviewers finished Wed, 18 Jan 2023 14:04:57 -0800 https://devapps.diality.us/cru/DG-DEN-13946-1 https://devapps.diality.us/cru/DG-DEN-13946-1 Dara Navaei , Sean Nash and dcox  (deleted user) finished reviewing DG-DEN-13946-1 DG-DEN-13946_Certain Temperature Sensors Trigger Wrong Alarm ]]> DG-DEN-13946-1: comment by dcox "RESOLVED IN CODE WALKTHROUGH" Wed, 18 Jan 2023 10:43:21 -0800 dcox https://devapps.diality.us/cru/DG-DEN-13946-1/#c16090 https://devapps.diality.us/cru/DG-DEN-13946-1/#c16090 dcox  (deleted user) replied to wbracken  (deleted user) in DG-DEN-13946-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-13946-1: comment by dcox "RESOLVED IN CODE WALKTHROUGH" Tue, 17 Jan 2023 15:32:59 -0800 dcox https://devapps.diality.us/cru/DG-DEN-13946-1/#c16076 https://devapps.diality.us/cru/DG-DEN-13946-1/#c16076 dcox  (deleted user) replied to wbracken  (deleted user) in DG-DEN-13946-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-13946-1: comment by wbracken "Updated comment" Fri, 13 Jan 2023 11:40:25 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-13946-1/#c15987 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15987 wbracken  (deleted user) replied to dcox  (deleted user) in DG-DEN-13946-1

Updated comment

]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13946 Corrections per code review Tue, 17 Jan 2023 14:13:09 -0800 Bill Bracken <bill@criticalsoftwaresolutions.com> https://devapps.diality.us/changelog/dgfirmware?cs=6bf297b685487355fd581f221c59cf9d5a4fa53e https://devapps.diality.us/changelog/dgfirmware?cs=6bf297b685487355fd581f221c59cf9d5a4fa53e Bill Bracken <bill@criticalsoftwaresolutions.com> committed 6bf297b on branch DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13946-certain-temperature-sensors-trigger-wrong-alarm and 167 more in dgfirmware DEN-13946 Corrections per code review

· /firmware/App/Controllers/LoadCell.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.h (-6, +7) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.h (-22, +23) | History | Source | Diff
· /firmware/App/Controllers/Thermistors.c (-4, +4) | History | Source | Diff
· /firmware/App/Controllers/Thermistors.h (-4, +5) | History | Source | Diff
]]> DG-DEN-13946-1: comment by dcox "RESOLVED IN CODE WALKTHROUGH" Tue, 17 Jan 2023 12:03:54 -0800 dcox https://devapps.diality.us/cru/DG-DEN-13946-1/#c16056 https://devapps.diality.us/cru/DG-DEN-13946-1/#c16056 dcox  (deleted user) replied to wbracken  (deleted user) in DG-DEN-13946-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-13946-1: comment by dcox "RESOLVED IN CODE WALKTHROUGH" Tue, 17 Jan 2023 12:00:45 -0800 dcox https://devapps.diality.us/cru/DG-DEN-13946-1/#c16055 https://devapps.diality.us/cru/DG-DEN-13946-1/#c16055 dcox  (deleted user) replied to wbracken  (deleted user) in DG-DEN-13946-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-13946-1: comment by wbracken "Corrected." Fri, 13 Jan 2023 11:39:56 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-13946-1/#c15986 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15986 wbracken  (deleted user) replied to dcox  (deleted user) in DG-DEN-13946-1

Corrected.

]]> DG-DEN-13946-1: comment by wbracken "Only used if Temperature is in alarm." Fri, 13 Jan 2023 11:34:36 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-13946-1/#c15984 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15984 wbracken  (deleted user) replied to dcox  (deleted user) in DG-DEN-13946-1

Only used if Temperature is in alarm.

]]> DG-DEN-13946-1: comment by wbracken "Only used if the load cell is out of range." Fri, 13 Jan 2023 11:31:20 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-13946-1/#c15983 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15983 wbracken  (deleted user) replied to dcox  (deleted user) in DG-DEN-13946-1

Only used if the load cell is out of range.

]]> DG-DEN-13946-1: comment by dcox "No initial value for alarmID. Can it end up no..." Fri, 13 Jan 2023 10:40:56 -0800 dcox https://devapps.diality.us/cru/DG-DEN-13946-1/#c15982 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15982 dcox  (deleted user) commented on DG-DEN-13946-1

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

]]> DG-DEN-13946-1: comment by dcox "Why remove initial value for alarmIndex?" Fri, 13 Jan 2023 10:38:06 -0800 dcox https://devapps.diality.us/cru/DG-DEN-13946-1/#c15981 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15981 dcox  (deleted user) commented on DG-DEN-13946-1

Why remove initial value for alarmIndex?

]]> DG-DEN-13946-1: comment by dcox "Comment does not explain what the numbers are -..." Fri, 13 Jan 2023 10:35:16 -0800 dcox https://devapps.diality.us/cru/DG-DEN-13946-1/#c15980 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15980 dcox  (deleted user) commented on DG-DEN-13946-1

Comment does not explain what the numbers are - 3, 10, 10.

]]> DG-DEN-13946-1: comment by dcox "Comment is 12bit specific, but code updated to ..." Fri, 13 Jan 2023 10:33:56 -0800 dcox https://devapps.diality.us/cru/DG-DEN-13946-1/#c15978 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15978 dcox  (deleted user) commented on DG-DEN-13946-1

Comment is 12bit specific, but code updated to use different references per thermistor.

]]> DG-DEN-13946-1: comment by Sean Nash "Setting first iterator to 0 seems safer (in cas..." Tue, 10 Jan 2023 08:26:39 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-13946-1/#c15873 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15873 Sean Nash replied to wbracken  (deleted user) in DG-DEN-13946-1

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum).
Could also create a redundant 0 enum like below and use the "first" enum to initialize a loop iterator safely:
enum list
{
FIRST_TEMP_SENSOR = 0,
TPI_SENSOR = FIRST_TEMP_SENSOR,
TPO_SENSOR,
TD1_SENSOR,
....
}
RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-13946-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 10 Jan 2023 08:24:35 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-13946-1/#c15872 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15872 Sean Nash replied to wbracken  (deleted user) in DG-DEN-13946-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-13946-1: comment by wbracken "Similar code is in other monitoring functions. ..." Mon, 09 Jan 2023 11:09:41 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-13946-1/#c15871 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15871 wbracken  (deleted user) replied to Sean Nash in DG-DEN-13946-1

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typedef THERMISTORS_TEMP_SENSORS_T. Changed load cells to use U08 to be consistent with temperature and pressure monitoring.

Should probably change temperature, pressure and load cells to use correct typedef.

Also, it looks like why the typedefs weren't used was in order to set the initial value of the iterator to 0 (i.e, the first sensor in the list). Seems like there should be a value that is the first item in the list, i.e. TEMPSENSORS_FIRST_SENSOR.

]]> DG-DEN-13946-1: comment by wbracken "Removed." Mon, 09 Jan 2023 11:07:06 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-13946-1/#c15870 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15870 wbracken  (deleted user) replied to Sean Nash in DG-DEN-13946-1

Removed.

]]> DG-DEN-13946-1: comment by Sean Nash "Remove blank line." Mon, 09 Jan 2023 10:15:48 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-13946-1/#c15869 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15869 Sean Nash commented on DG-DEN-13946-1

Remove blank line.

]]> DG-DEN-13946-1: comment by Sean Nash "Why change this to U08?" Fri, 06 Jan 2023 16:02:52 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-13946-1/#c15868 https://devapps.diality.us/cru/DG-DEN-13946-1/#c15868 Sean Nash commented on DG-DEN-13946-1

Why change this to U08?

]]> DG-DEN-13946-1: started by Dara Navaei Wed, 04 Jan 2023 15:00:42 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13946-1 https://devapps.diality.us/cru/DG-DEN-13946-1 Dara Navaei started review DG-DEN-13946-1 ]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 03 Jan 2023 10:10:54 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=6499ea25921fcf67826fa0c35bb03caf411ba542 https://devapps.diality.us/changelog/dgfirmware?cs=6499ea25921fcf67826fa0c35bb03caf411ba542 Dara Navaei committed 6499ea2 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 174 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
… 84 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 03 Mar 2022 15:32:18 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=a9315539f527b92523b1598ff91e47db4d71dae2 https://devapps.diality.us/changelog/dgfirmware?cs=a9315539f527b92523b1598ff91e47db4d71dae2 Dara Navaei committed a931553 on branch DEN-11928-dg-conductivity-update-den-tbd, DEN-12121-sw_dev-sprint-65-michael-garthwaite and 202 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/DialysateFlow.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DialysateFlow.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
… 45 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 05 Jan 2022 20:16:06 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=025612ad77fe630889a364586de54bffe5262d56 https://devapps.diality.us/changelog/dgfirmware?cs=025612ad77fe630889a364586de54bffe5262d56 Dara Navaei committed 025612a on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 204 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DialysateFlow.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/DialysateFlow.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
… 80 more files in changeset.
]]>