Fisheye on dgfirmware/firmware/App/Modes https://devapps.diality.us/changelog/~br%3DDEN-15791-dg-software-design-description/dgfirmware/firmware/App/Modes Recent activity in "dgfirmware" under directory /firmware/App/Modes dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged staging to DEN-15791. Sat, 30 Sep 2023 11:41:29 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=d371983d84daf213db3e39d21cf30c13161ce062 https://devapps.diality.us/changelog/dgfirmware?cs=d371983d84daf213db3e39d21cf30c13161ce062 Sean Nash committed d371983 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware Merged staging to DEN-15791.

· /firmware/App/Controllers/ROPump.c (-3, +15) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-6, +8) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-67, +84) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-10, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +16) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +118) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +14) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15791: Doxygen comment fixes. Sun, 24 Sep 2023 11:02:14 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=b67373adbc581690febb1e1c2bb521f108d9b92e https://devapps.diality.us/changelog/dgfirmware?cs=b67373adbc581690febb1e1c2bb521f108d9b92e Sean Nash committed b67373a on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware DEN-15791: Doxygen comment fixes.

· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-5, +7) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-5, +5) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-6, +0) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 20 Sep 2023 13:47:14 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=686955d65645ec1f99350150e49f9030d840b4cc https://devapps.diality.us/changelog/dgfirmware?cs=686955d65645ec1f99350150e49f9030d840b4cc Dara Navaei committed 686955d on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'staging' into DEN-16382-alarm-207-dg-flow-meter-check-failure-triggers-after-alarm-282-bicarbonate-volume Wed, 20 Sep 2023 09:53:21 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=2252531a88ffae920ef57f42e29badbd0d6a5491 https://devapps.diality.us/changelog/dgfirmware?cs=2252531a88ffae920ef57f42e29badbd0d6a5491 Dara Navaei committed 2252531 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 59 more in dgfirmware Merge branch 'staging' into DEN-16382-alarm-207-dg-flow-meter-check-failure-triggers-after-alarm-282-bicarbonate-volume

· /firmware/App/Modes/ModeFill.c (-6, +8) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 19 Sep 2023 13:29:01 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=8c22edb621da0832b1e1d9c7b1600dd63c94877d https://devapps.diality.us/changelog/dgfirmware?cs=8c22edb621da0832b1e1d9c7b1600dd63c94877d Dara Navaei committed 8c22edb on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 59 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16382 updated the code to eliminate the extra fill command after the empty bottles alarm Tue, 19 Sep 2023 13:12:21 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=5f1388ca0f6672b9ab90eef649de8dc921c9beb2 https://devapps.diality.us/changelog/dgfirmware?cs=5f1388ca0f6672b9ab90eef649de8dc921c9beb2 Dara Navaei committed 5f1388c on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 59 more in dgfirmware DEN-16382 updated the code to eliminate the extra fill command after the empty bottles alarm

· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-8, +0) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314 added code in the fill mode to set the start fill time if it was 0 even if the previous state in the fill mode... Tue, 19 Sep 2023 11:19:10 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=45b9096cf10c20adfaeac9e182ad75e1bf86d6e3 https://devapps.diality.us/changelog/dgfirmware?cs=45b9096cf10c20adfaeac9e182ad75e1bf86d6e3 Dara Navaei committed 45b9096 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 60 more in dgfirmware DEN-16314 added code in the fill mode to set the start fill time if it was 0 even if the previous state in the fill mode was pause

· /firmware/App/Modes/ModeFill.c (-4, +6) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16382: Prevent empty concentrate bottle alarms when mix with water test config is active. Tue, 19 Sep 2023 09:34:55 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=f10c653a13f97ae3d220e16f7ff1a9558606b56a https://devapps.diality.us/changelog/dgfirmware?cs=f10c653a13f97ae3d220e16f7ff1a9558606b56a Sean Nash committed f10c653 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 59 more in dgfirmware DEN-16382: Prevent empty concentrate bottle alarms when mix with water test config is active.

· /firmware/App/Modes/ModeDrain.c (-2, +4) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 18 Sep 2023 10:50:41 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=cf9f459e2b3fed14f46aeeb95bd70af6abec3122 https://devapps.diality.us/changelog/dgfirmware?cs=cf9f459e2b3fed14f46aeeb95bd70af6abec3122 Dara Navaei committed cf9f459 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 60 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-285: fix to ensure we see transitions of submode. Mon, 18 Sep 2023 08:53:20 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dgfirmware?cs=8a25d5761bfd4f88a8666f9367462dcba934f0a0 https://devapps.diality.us/changelog/dgfirmware?cs=8a25d5761bfd4f88a8666f9367462dcba934f0a0 Michael Garthwaite committed 8a25d57 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware DIAL-285: fix to ensure we see transitions of submode.

· /firmware/App/Modes/OperationModes.c (-0, +3) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 15 Sep 2023 16:38:36 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=8ee01698b926fa62e7bed563b1137144a3cb32c5 https://devapps.diality.us/changelog/dgfirmware?cs=8ee01698b926fa62e7bed563b1137144a3cb32c5 Dara Navaei committed 8ee0169 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 15 Sep 2023 15:32:40 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=becd984764c6f1737369fc7078059c46809f1864 https://devapps.diality.us/changelog/dgfirmware?cs=becd984764c6f1737369fc7078059c46809f1864 Dara Navaei committed becd984 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated the chemical disinfect Fri, 15 Sep 2023 08:50:56 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=3223b2c9784261205928b3ee21edd88df5be8a60 https://devapps.diality.us/changelog/dgfirmware?cs=3223b2c9784261205928b3ee21edd88df5be8a60 Dara Navaei committed 3223b2c on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware DEN-15973 updated the chemical disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +7) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated chem disinfect Thu, 14 Sep 2023 18:04:08 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=3835a004a6ef4a31d740d2532a5aba1683fa9d5a https://devapps.diality.us/changelog/dgfirmware?cs=3835a004a6ef4a31d740d2532a5aba1683fa9d5a Dara Navaei committed 3835a00 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware DEN-15973 updated chem disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +3) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated chemical disinfect Thu, 14 Sep 2023 17:37:21 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=e6ecfc3119487cd10e51be9d5c99d7b4276b9201 https://devapps.diality.us/changelog/dgfirmware?cs=e6ecfc3119487cd10e51be9d5c99d7b4276b9201 Dara Navaei committed e6ecfc3 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware DEN-15973 updated chemical disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16432 fixed the heat disinfect temperature out of range trial count error Thu, 14 Sep 2023 17:01:11 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=efa212739611603d5a3301fdb6511d9fd6fb5599 https://devapps.diality.us/changelog/dgfirmware?cs=efa212739611603d5a3301fdb6511d9fd6fb5599 Dara Navaei committed efa2127 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware DEN-16432 fixed the heat disinfect temperature out of range trial count error

· /firmware/App/Modes/ModeHeatDisinfect.c (-2, +3) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated the chemical disinfect Thu, 14 Sep 2023 15:35:48 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=719abb7d9989e83f750406bb8e284eca8b09f2c7 https://devapps.diality.us/changelog/dgfirmware?cs=719abb7d9989e83f750406bb8e284eca8b09f2c7 Dara Navaei committed 719abb7 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware DEN-15973 updated the chemical disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c (-2, +3) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated chemical disinfect Thu, 14 Sep 2023 13:26:44 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=ddad43bbd6e1708cbb3cf27be80299781f1749cc https://devapps.diality.us/changelog/dgfirmware?cs=ddad43bbd6e1708cbb3cf27be80299781f1749cc Dara Navaei committed ddad43b on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware DEN-15973 updated chemical disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 addressed the code review comments Thu, 14 Sep 2023 10:27:29 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=c47dc6366cfb411149b4003744cf8edf87cac6e5 https://devapps.diality.us/changelog/dgfirmware?cs=c47dc6366cfb411149b4003744cf8edf87cac6e5 Dara Navaei committed c47dc63 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware DEN-15973 addressed the code review comments

· /firmware/App/Modes/ModeStandby.c (-4, +4) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 addressed the code review comments Thu, 14 Sep 2023 09:48:13 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=5379702cf2aba320cad160bef6c381c0c9138a63 https://devapps.diality.us/changelog/dgfirmware?cs=5379702cf2aba320cad160bef6c381c0c9138a63 Dara Navaei committed 5379702 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware DEN-15973 addressed the code review comments

· /firmware/App/Controllers/Pressures.c (-12, +12) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +5) | History | Source | Diff
· /firmware/App/Modes/OperationModes.h (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 14 Sep 2023 09:29:29 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=5459a8a8b011c5956feb83c14fa98091287be7ac https://devapps.diality.us/changelog/dgfirmware?cs=5459a8a8b011c5956feb83c14fa98091287be7ac Dara Navaei committed 5459a8a on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 fixed the inlet water pressure alarm. DEN-16418 added chemical flush done after chemical disinfect prior to st... Wed, 13 Sep 2023 16:47:43 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=f5fae90687cdee9712174e0dc92e34a60eb459bf https://devapps.diality.us/changelog/dgfirmware?cs=f5fae90687cdee9712174e0dc92e34a60eb459bf Dara Navaei committed f5fae90 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware DEN-15973 fixed the inlet water pressure alarm. DEN-16418 added chemical flush done after chemical disinfect prior to starting RO permeate sample mode

· /firmware/App/Controllers/Pressures.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-0, +11) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 added the inlet water pressure limit in flush drain in the cleaning modes Wed, 13 Sep 2023 11:04:59 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=93a5ad88c7754e2d64d11d3425571aa27fe12652 https://devapps.diality.us/changelog/dgfirmware?cs=93a5ad88c7754e2d64d11d3425571aa27fe12652 Dara Navaei committed 93a5ad8 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware DEN-15973 added the inlet water pressure limit in flush drain in the cleaning modes

· /firmware/App/Controllers/Pressures.c (-2, +24) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-0, +12) | History | Source | Diff
· /firmware/App/Modes/OperationModes.h (-0, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low... Wed, 13 Sep 2023 09:52:18 -0700 James Walter Taylor <jtaylor@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=35a1f7d58d013f95108e38674b01a283970e74a2 https://devapps.diality.us/changelog/dgfirmware?cs=35a1f7d58d013f95108e38674b01a283970e74a2 James Walter Taylor <jtaylor@diality.com> committed 35a1f7d on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

On Dara's advice, ifdef'ed code for fill state treatment recovery

· /firmware/App/Modes/ModeFill.c (-17, +12) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low... Tue, 12 Sep 2023 10:55:09 -0700 James Walter Taylor <jtaylor@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=9aacc7bb8138bd2b2485bf628592e845ddf6d400 https://devapps.diality.us/changelog/dgfirmware?cs=9aacc7bb8138bd2b2485bf628592e845ddf6d400 James Walter Taylor <jtaylor@diality.com> committed 9aacc7b on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Reset timers when doing a test recover state, or returning from a (reset) fault condition.

· /firmware/App/Modes/ModeFill.c (-3, +5) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-283: compiler fixes. Mon, 11 Sep 2023 14:00:50 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dgfirmware?cs=3c5e5fb5ef76cab42b85a75d26e4cba663f32059 https://devapps.diality.us/changelog/dgfirmware?cs=3c5e5fb5ef76cab42b85a75d26e4cba663f32059 Michael Garthwaite committed 3c5e5fb on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DIAL-283: compiler fixes.

· /firmware/App/Modes/ModeChemicalDisinfect.h (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-283: message handling for moving average override. Mon, 11 Sep 2023 13:59:11 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dgfirmware?cs=3fc87449b1c5b892a7f86430b7b8c49190ae56a8 https://devapps.diality.us/changelog/dgfirmware?cs=3fc87449b1c5b892a7f86430b7b8c49190ae56a8 Michael Garthwaite committed 3fc8744 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DIAL-283: message handling for moving average override.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-10, +7) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h (-0, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +31) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +3) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-283: chem disinfect moving average override Mon, 11 Sep 2023 12:30:02 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dgfirmware?cs=e4657f6c590eed9c6af43a9739b87b81a34a8144 https://devapps.diality.us/changelog/dgfirmware?cs=e4657f6c590eed9c6af43a9739b87b81a34a8144 Michael Garthwaite committed e4657f6 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DIAL-283: chem disinfect moving average override

· /firmware/App/Modes/ModeChemicalDisinfect.c (-6, +62) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low... Fri, 08 Sep 2023 17:23:49 -0700 James Walter Taylor <jtaylor@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=482a7419b20845a9544d2c79b96b27300a3f00d6 https://devapps.diality.us/changelog/dgfirmware?cs=482a7419b20845a9544d2c79b96b27300a3f00d6 James Walter Taylor <jtaylor@diality.com> committed 482a741 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Reintroduced reservoir data structure change.

Corrected the setModeFillStateTransition semantics.

· /firmware/App/Modes/ModeFill.c (-2, +3) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-3, +0) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low... Fri, 08 Sep 2023 13:27:39 -0700 James Walter Taylor <jtaylor@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=c2684b58df80af6782ff1617f5999fa7ec8a1f64 https://devapps.diality.us/changelog/dgfirmware?cs=c2684b58df80af6782ff1617f5999fa7ec8a1f64 James Walter Taylor <jtaylor@diality.com> committed c2684b5 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Corrected spacing in the file per CR comments

· /firmware/App/Modes/ModeFill.c (-1, +3) | History | Source | Diff
]]>