· /firmware/App/Controllers/AirTrap.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmLamp.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmLamp.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/BloodFlow.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/BloodFlow.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/BloodLeak.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/BloodLeak.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Bubble.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Bubble.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Buttons.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Buttons.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DGInterface.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DGInterface.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DialInFlow.c	(-3, +3)	| History	| Source	| Diff
… 98 more files in changeset.

]]> Wed, 21 Dec 2022 14:54:40 -0800 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=758497628fa5839a2b6661a9d7c32fd3b11db2bd https://devapps.diality.us/changelog/hdfirmware?cs=758497628fa5839a2b6661a9d7c32fd3b11db2bd Dara Navaei committed 7584976 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 299 more in hdfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DGInterface.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DGInterface.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DialInFlow.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/Battery.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/Battery.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/HDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmt.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
… 6 more files in changeset.

]]> Wed, 21 Dec 2022 14:53:40 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14307-1 https://devapps.diality.us/cru/HD-DEN-14307-1 Dara Navaei Closed HD-DEN-14307-1 ]]> Wed, 21 Dec 2022 14:34:32 -0800 https://devapps.diality.us/cru/HD-DEN-14307-1 https://devapps.diality.us/cru/HD-DEN-14307-1 wbracken  (deleted user) and Sean Nash finished reviewing HD-DEN-14307-1 HD-DEN-14307_DG HD Dev HD DG Dvt Update Part 6 ]]> Wed, 21 Dec 2022 13:56:09 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15703 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15703 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-14307-1

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

Done

Data is a local variable but added alarmButtonBlockers

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

data and alarmButtonBlockers?

Should alarmButtonBlockers and ALARM_TABLE also be added.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

I think we still want to keep the comment. It has not been implemented yet.

Done

Done

Done

Fixed the setServiceTime function. Thanks.

Done.

Agree, though this comment belongs in NVDataMgmt.c where setServiceTime() is lives. That function should return TRUE if successful.

All of these terms are integers and cast is coming too late (after division). To prevent loss of precision on division, we want to cast both sides of the division as floats.

Looks like setServiceTime always returns FALSE.

Update function header.

Update function header.

Update function header.