Fisheye on dgfirmware/

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Merge branch 'staging' into DEN-15921-when-cap-is-open-dg-transition-to-cancel-basic-path-instead-of-cancel-water-path

Dara Navaei — Wed, 26 Jul 2023 11:06:34 -0700

Dara Navaei committed ce107b8 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

Merge branch 'staging' into DEN-15921-when-cap-is-open-dg-transition-to-cancel-basic-path-instead-of-cancel-water-path

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15921 code clean up

Dara Navaei — Wed, 26 Jul 2023 10:58:51 -0700

Dara Navaei committed a7c2d1b on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

DEN-15921 code clean up

· /firmware/App/Modes/ModeStandby.c

(-5, +5)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 26 Jul 2023 10:57:41 -0700

Dara Navaei committed 785f7fc on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 26 Jul 2023 10:57:35 -0700

Dara Navaei committed 726a133 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemCommMessages.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Merge branch 'DEN-15714-ee-alarm-84-hd-rtc-time-after-cycling-dg-and-hd-dvt-021' into staging

Wed, 26 Jul 2023 10:55:40 -0700

Bill Bracken committed 91ae574 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

Merge branch 'DEN-15714-ee-alarm-84-hd-rtc-time-after-cycling-dg-and-hd-dvt-021' into staging

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15921, DEN-15916 changed the heat disinfect, heat disinfect active cool, and flush modes to send their start state v...

Dara Navaei — Tue, 25 Jul 2023 15:35:47 -0700

Dara Navaei committed b77808c on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

DEN-15921, DEN-15916 changed the heat disinfect, heat disinfect active cool, and flush modes to send their start state via the events system

· /firmware/App/Controllers/LoadCell.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15921 addressed a code review comment

Dara Navaei — Tue, 25 Jul 2023 13:22:09 -0700

Dara Navaei committed 81be018 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

DEN-15921 addressed a code review comment

· /firmware/App/Modes/ModeROPermeateSample.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15921, DEN-15882 made a change in the code to transition to drain R1 in RO permeate sample mode after the sample col...

Dara Navaei — Tue, 25 Jul 2023 13:14:54 -0700

Dara Navaei committed 0accd81 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

DEN-15921, DEN-15882 made a change in the code to transition to drain R1 in RO permeate sample mode after the sample collection is finished

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-1, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15921, DEN-15868 changed the direction of the pumps in RO permeate sample mode. Changed the code to check the flow i...

Dara Navaei — Tue, 25 Jul 2023 08:49:32 -0700

Dara Navaei committed e240618 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

DEN-15921, DEN-15868 changed the direction of the pumps in RO permeate sample mode. Changed the code to check the flow in heat disinfect and active cool to only when the system is not hot

· /firmware/App/Controllers/DrainPump.c	(-4, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +12)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15921 changed the active cool to transition to cancel water path instead of basic path when caps are not on

Dara Navaei — Mon, 24 Jul 2023 15:07:01 -0700

Dara Navaei committed f62ad14 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

DEN-15921 changed the active cool to transition to cancel water path instead of basic path when caps are not on

· /firmware/App/Modes/ModeFill.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15714 Temporarily remove synching of DG RTC from HD RT.

Mon, 24 Jul 2023 13:47:43 -0700

Bill Bracken committed 972fd66 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 94 more in dgfirmware

DEN-15714 Temporarily remove synching of DG RTC from HD RT.

· /firmware/App/Services/SystemCommMessages.c

(-0, +4)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 21 Jul 2023 18:11:05 -0700

Dara Navaei committed 6a02d68 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 94 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 21 Jul 2023 18:10:58 -0700

Dara Navaei committed 79d12d6 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 94 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Merged DEN-15736

Dara Navaei — Fri, 21 Jul 2023 17:54:34 -0700

Dara Navaei committed 0a4e8ac on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 94 more in dgfirmware

Merged DEN-15736

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'staging' into DEN-15736-concentrate-pump-runs-in-opposite-direction-during-concentrate-self-test

Dara Navaei — Fri, 21 Jul 2023 15:56:29 -0700

Dara Navaei committed f0b4419 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 95 more in dgfirmware

Merge branch 'staging' into DEN-15736-concentrate-pump-runs-in-opposite-direction-during-concentrate-self-test

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 21 Jul 2023 15:02:33 -0700

Dara Navaei committed f963296 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 95 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 21 Jul 2023 15:02:26 -0700

Dara Navaei committed 4fbbd78 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 95 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'DEN-15416-dg-fault-baro-cal-crc-id-233-declares-after-cycling-power-dvt-020' into staging

Fri, 21 Jul 2023 15:01:05 -0700

Bill Bracken committed b86c2b5 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 95 more in dgfirmware

Merge branch 'DEN-15416-dg-fault-baro-cal-crc-id-233-declares-after-cycling-power-dvt-020' into staging

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-1636 removed a blank line

Dara Navaei — Thu, 20 Jul 2023 17:31:11 -0700

Dara Navaei committed 852bff6 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 95 more in dgfirmware

DEN-1636 removed a blank line

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +0)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15736 updated the concentrate pumps to set the control bit if it is not the same as what it should be

Dara Navaei — Thu, 20 Jul 2023 17:28:26 -0700

Dara Navaei committed 62e9a14 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 95 more in dgfirmware

DEN-15736 updated the concentrate pumps to set the control bit if it is not the same as what it should be

· /firmware/App/Controllers/ConcentratePumps.c	(-3, +48)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-7, +45)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-0, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15416 Process baro sensor when not in DG_MODE_INIT

Wed, 19 Jul 2023 16:21:31 -0700

Bill Bracken committed f7c42b9 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 96 more in dgfirmware

DEN-15416 Process baro sensor when not in DG_MODE_INIT

· /firmware/App/Controllers/TemperatureSensors.c

(-3, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 19 Jul 2023 13:32:52 -0700

Dara Navaei committed a17d8a8 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 96 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 19 Jul 2023 13:32:45 -0700

Dara Navaei committed f4f4d01 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 96 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeStandby.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merged DEN-15867 to staging.

Sean Nash — Wed, 19 Jul 2023 13:30:59 -0700

Sean Nash committed df9d470 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 96 more in dgfirmware

Merged DEN-15867 to staging.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15867: Fix for issue where concentrate prime/test was being done twice in pre-tx.

Sean Nash — Tue, 18 Jul 2023 09:54:49 -0700

Sean Nash committed 6747acd on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 97 more in dgfirmware

DEN-15867: Fix for issue where concentrate prime/test was being done twice in pre-tx.

· /firmware/App/Modes/ModeStandby.c

(-4, +4)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Sun, 16 Jul 2023 09:44:59 -0700

Dara Navaei committed 667e090 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 98 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 13 Jul 2023 13:16:56 -0700

Dara Navaei committed fc69a13 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 98 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 13 Jul 2023 13:16:49 -0700

Dara Navaei committed 05718e4 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 98 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'DEN-15702-alarm-150-inlet-water-conductivity-high-does-not-disappear-on-standby-screen-when' into staging

Thu, 13 Jul 2023 13:14:12 -0700

Darren Cox committed 3377c19 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 98 more in dgfirmware

Merge branch 'DEN-15702-alarm-150-inlet-water-conductivity-high-does-not-disappear-on-standby-screen-when' into staging

· /firmware/App/Controllers/TemperatureSensors.c

(-45, +59)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 13 Jul 2023 11:30:17 -0700

Dara Navaei committed ad50d45 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 98 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff