Fisheye on hdfirmware/firmware

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15980 align comment.

Thu, 31 Aug 2023 12:50:02 -0700

Darren Cox committed 2b05010 on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 133 more in hdfirmware

DEN-15980 align comment.

· /firmware/App/Controllers/PresOccl.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15980 Increase short stabilize time from 5sec to 10sec. Air pump pressure not yet stabilized at 5.

Thu, 31 Aug 2023 11:59:01 -0700

Darren Cox committed c6d5d68 on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 133 more in hdfirmware

DEN-15980 Increase short stabilize time from 5sec to 10sec. Air pump pressure not yet stabilized at 5.

· /firmware/App/Controllers/PresOccl.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15980 Code review comment update

Thu, 24 Aug 2023 13:49:30 -0700

Darren Cox committed d28cdff on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more in hdfirmware

DEN-15980 Code review comment update

· /firmware/App/Controllers/PresOccl.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15980 Remove TODO code. Will add time window alarm later if needed.

Wed, 23 Aug 2023 17:22:31 -0700

Darren Cox committed 39ecf9e on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more in hdfirmware

DEN-15980 Remove TODO code. Will add time window alarm later if needed.

· /firmware/App/Controllers/AirTrap.c

(-9, +0)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15980 Code review update 4.

Wed, 23 Aug 2023 15:09:20 -0700

Darren Cox committed c966bb0 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more in hdfirmware

DEN-15980 Code review update 4.

· /firmware/App/Controllers/PresOccl.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15980 Code review update 3.

Wed, 23 Aug 2023 15:04:57 -0700

Darren Cox committed 4446dc2 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more in hdfirmware

DEN-15980 Code review update 3.

· /firmware/App/Controllers/PresOccl.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15980 Code review update 2.

Wed, 23 Aug 2023 14:59:25 -0700

Darren Cox committed d4a7a02 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more in hdfirmware

DEN-15980 Code review update 2.

· /firmware/App/Controllers/PresOccl.c

(-11, +11)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16179 Lock out pressure checks in Treat Recirculate substate.

Wed, 23 Aug 2023 14:53:15 -0700

Darren Cox committed cc248c3 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more in hdfirmware

DEN-16179 Lock out pressure checks in Treat Recirculate substate.

· /firmware/App/Controllers/PresOccl.c

(-1, +5)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15980 Code review comments update 1

Wed, 23 Aug 2023 10:40:34 -0700

Darren Cox committed dd9b6a7 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more in hdfirmware

DEN-15980 Code review comments update 1

· /firmware/App/Controllers/AirTrap.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-10, +11)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15980 Air pump mods: longer ON time, shorter stabilize pressure time, add alarm framework for air pump on too much....

Mon, 21 Aug 2023 17:18:16 -0700

Darren Cox committed da757a9 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more in hdfirmware

DEN-15980 Air pump mods: longer ON time, shorter stabilize pressure time, add alarm framework for air pump on too much.

· /firmware/App/Controllers/AirTrap.c	(-2, +13)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-11, +43)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Fri, 18 Aug 2023 16:45:54 -0700

Dara Navaei committed 1369d81 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 146 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 18 Aug 2023 16:45:47 -0700

Dara Navaei committed 92d7088 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 146 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/Prime.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16278-hd-pretreatment-prime-start-state-does-not-allow-pause...

Fri, 18 Aug 2023 09:01:46 -0700

James Walter Taylor committed f66b4b2 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 147 more in hdfirmware

DEN-16278-hd-pretreatment-prime-start-state-does-not-allow-pause

Added pause/stop property detection in start state.

· /firmware/App/Modes/Prime.c

(-2, +6)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Thu, 17 Aug 2023 10:58:39 -0700

Dara Navaei committed 0b3059f on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 17 Aug 2023 10:58:30 -0700

Dara Navaei committed 3217afc on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/Rinseback.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15994-rinseback-5-minute-timer-does-not-count-down...

Wed, 16 Aug 2023 15:37:30 -0700

James Walter Taylor committed f96b766 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Simplification.

· /firmware/App/Modes/Rinseback.c

(-8, +4)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15994-rinseback-5-minute-timer-does-not-count-down...

Wed, 16 Aug 2023 15:34:03 -0700

James Walter Taylor committed 96b8258 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Updated for CR comments.

· /firmware/App/Modes/Rinseback.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Wed, 16 Aug 2023 14:27:11 -0700

Dara Navaei committed 09f244c on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 14:27:01 -0700

Dara Navaei committed f0c16ca on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/PresOccl.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16200: Addressed DEN-16192 re: confirmation of end treatment request sometimes does not go to post tx mode.

Sean Nash — Wed, 16 Aug 2023 13:47:51 -0700

Sean Nash committed a80f37f on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

DEN-16200: Addressed DEN-16192 re: confirmation of end treatment request sometimes does not go to post tx mode.

· /firmware/App/Modes/OperationModes.c

(-9, +25)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Wed, 16 Aug 2023 11:06:17 -0700

Dara Navaei committed df495dd on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 11:06:02 -0700

Dara Navaei committed 343d62b on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodLeak.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16200: Removed obsolete #define.

Sean Nash — Wed, 16 Aug 2023 10:43:00 -0700

Sean Nash committed f75d40c on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

DEN-16200: Removed obsolete #define.

· /firmware/App/Services/Reservoirs.c

(-1, +0)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Wed, 16 Aug 2023 10:30:45 -0700

Dara Navaei committed 78b780d on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 10:30:34 -0700

Dara Navaei committed 754057a on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Merge remote-tracking branch 'origin/DEN-15996-over-ride-commands-duplicates-the-id-msg_id_valves_states_publish_interva...

Wed, 16 Aug 2023 09:57:34 -0700

James Walter Taylor committed 070bff4 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

Merge remote-tracking branch 'origin/DEN-15996-over-ride-commands-duplicates-the-id-msg_id_valves_states_publish_interval_override' into staging

· /firmware/App/Services/SystemComm.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Wed, 16 Aug 2023 09:55:10 -0700

Dara Navaei committed 95d1781 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 09:54:59 -0700

Dara Navaei committed 0826b00 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16239 added the blood leak alarm disable test configuration

Dara Navaei — Wed, 16 Aug 2023 09:43:53 -0700

Dara Navaei committed aee838e on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

DEN-16239 added the blood leak alarm disable test configuration

· /firmware/App/Controllers/BloodLeak.c

(-9, +7)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16200: Addressed code review comment. Addressed DEN-16229 re: Heparin not dispensing after alarm w/ blood recirc.

Sean Nash — Wed, 16 Aug 2023 09:31:23 -0700

Sean Nash committed 5ea6a78 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

DEN-16200: Addressed code review comment. Addressed DEN-16229 re: Heparin not dispensing after alarm w/ blood recirc.

· /firmware/App/Controllers/SyringePump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	\| History	\| Source	\| Diff