Fisheye on hdfirmware/firmware/App/Modes

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16278-hd-pretreatment-prime-start-state-does-not-allow-pause...

Fri, 18 Aug 2023 09:01:46 -0700

James Walter Taylor committed f66b4b2 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 147 more in hdfirmware

DEN-16278-hd-pretreatment-prime-start-state-does-not-allow-pause

Added pause/stop property detection in start state.

· /firmware/App/Modes/Prime.c

(-2, +6)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 17 Aug 2023 10:58:30 -0700

Dara Navaei committed 3217afc on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/Rinseback.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15994-rinseback-5-minute-timer-does-not-count-down...

Wed, 16 Aug 2023 15:37:30 -0700

James Walter Taylor committed f96b766 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Simplification.

· /firmware/App/Modes/Rinseback.c

(-8, +4)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15994-rinseback-5-minute-timer-does-not-count-down...

Wed, 16 Aug 2023 15:34:03 -0700

James Walter Taylor committed 96b8258 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Updated for CR comments.

· /firmware/App/Modes/Rinseback.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 14:27:01 -0700

Dara Navaei committed f0c16ca on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/PresOccl.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16200: Addressed DEN-16192 re: confirmation of end treatment request sometimes does not go to post tx mode.

Sean Nash — Wed, 16 Aug 2023 13:47:51 -0700

Sean Nash committed a80f37f on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

DEN-16200: Addressed DEN-16192 re: confirmation of end treatment request sometimes does not go to post tx mode.

· /firmware/App/Modes/OperationModes.c

(-9, +25)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16200: Addressed code review comment. Addressed DEN-16229 re: Heparin not dispensing after alarm w/ blood recirc.

Sean Nash — Wed, 16 Aug 2023 09:31:23 -0700

Sean Nash committed 5ea6a78 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

DEN-16200: Addressed code review comment. Addressed DEN-16229 re: Heparin not dispensing after alarm w/ blood recirc.

· /firmware/App/Controllers/SyringePump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15994-rinseback-5-minute-timer-does-not-count-down...

Wed, 16 Aug 2023 09:01:24 -0700

James Walter Taylor committed 9384a36 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Typo. Corrected display enable logic.

· /firmware/App/Modes/Rinseback.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16200: Addressed DEN-15618 re: no resume option in treatment end states.

Sean Nash — Tue, 15 Aug 2023 11:14:24 -0700

Sean Nash committed 6a26a01 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 149 more in hdfirmware

DEN-16200: Addressed DEN-15618 re: no resume option in treatment end states.

· /firmware/App/Modes/ModeTreatment.c	(-5, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-25, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.h	(-1, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15994-rinseback-5-minute-timer-does-not-count-down...

Tue, 15 Aug 2023 10:55:06 -0700

James Walter Taylor committed 6060e1a on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Moved fix to correct message.

· /firmware/App/Modes/Rinseback.c

(-5, +14)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 14 Aug 2023 14:05:31 -0700

Dara Navaei committed a56db46 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 151 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Fans.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Battery.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Battery.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14815: Addressed DEN-15885. Fixed compiler warning.

Sean Nash — Fri, 11 Aug 2023 16:10:38 -0700

Sean Nash committed 2ecbac1 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 152 more in hdfirmware

DEN-14815: Addressed DEN-15885. Fixed compiler warning.

· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-4, +17)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 11 Aug 2023 11:01:33 -0700

Dara Navaei committed 526e890 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 152 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DGInterface.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14815: Addressed code review comment.

Sean Nash — Fri, 11 Aug 2023 10:21:27 -0700

Sean Nash committed c222289 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 152 more in hdfirmware

DEN-14815: Addressed code review comment.

· /firmware/App/Modes/ModePostTreat.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14815: Fixed wet s.t. state change event bug.

Sean Nash — Fri, 11 Aug 2023 10:19:43 -0700

Sean Nash committed 84eb5fb on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 152 more in hdfirmware

DEN-14815: Fixed wet s.t. state change event bug.

· /firmware/App/Modes/SelfTests.c

(-0, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16149 updated the pretreatment expedite reservoir management

Dara Navaei — Fri, 11 Aug 2023 08:46:02 -0700

Dara Navaei committed eb42b90 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 153 more in hdfirmware

DEN-16149 updated the pretreatment expedite reservoir management

· /firmware/App/Modes/ModePreTreat.c

(-43, +47)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 11 Aug 2023 08:10:32 -0700

Dara Navaei committed b550cc9 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 153 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/TreatmentEnd.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16018 added more comment for clarity. DEN-16149 Changed the default active reservoir to reservoir 1 to be matched wi...

Dara Navaei — Thu, 10 Aug 2023 17:09:32 -0700

Dara Navaei committed 14608b2 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 153 more in hdfirmware

DEN-16018 added more comment for clarity. DEN-16149 Changed the default active reservoir to reservoir 1 to be matched with DG on power up

· /firmware/App/Controllers/DGInterface.c	(-4, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-0, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16175: moved end treatment timeout alarm above the substate execution.

Michael Garthwaite — Thu, 10 Aug 2023 13:02:48 -0700

Michael Garthwaite committed fb5af92 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 154 more in hdfirmware

DEN-16175: moved end treatment timeout alarm above the substate execution.

· /firmware/App/Modes/TreatmentEnd.c

(-7, +5)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16175: Moved End Treatment timeout alarm from wait for rinseback substate to general treatment end.

Michael Garthwaite — Thu, 10 Aug 2023 12:48:53 -0700

Michael Garthwaite committed 36d4763 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 154 more in hdfirmware

DEN-16175: Moved End Treatment timeout alarm from wait for rinseback substate to general treatment end.

· /firmware/App/Modes/TreatmentEnd.c

(-5, +6)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16018 added dialin and dialout pumps hard stop commands prior to transitioning to treatment from treatment pause

Dara Navaei — Thu, 10 Aug 2023 11:37:23 -0700

Dara Navaei committed 85d63f6 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 153 more in hdfirmware

DEN-16018 added dialin and dialout pumps hard stop commands prior to transitioning to treatment from treatment pause

· /firmware/App/Modes/ModeTreatment.c

(-0, +3)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14815: Added support for post-tx next button request handling with acceptance and reject reason depending on whether...

Sean Nash — Wed, 09 Aug 2023 17:24:02 -0700

Sean Nash committed fc7328b on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 152 more in hdfirmware

DEN-14815: Added support for post-tx next button request handling with acceptance and reject reason depending on whether reservoirs are drained and valves homed yet.

· /firmware/App/Modes/ModePostTreat.c	(-0, +26)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +53)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +6)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 08 Aug 2023 13:30:49 -0700

Dara Navaei committed 814e18d on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 155 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16102: code review comments

Michael Garthwaite — Tue, 08 Aug 2023 10:23:12 -0700

Michael Garthwaite committed 59726ff on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 156 more in hdfirmware

DEN-16102: code review comments

· /firmware/App/Modes/SelfTests.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 08 Aug 2023 09:22:12 -0700

Dara Navaei committed 6a855fd on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 156 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeTreatment.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Merged staging to DEN-15741.

Sean Nash — Tue, 08 Aug 2023 09:17:17 -0700

Sean Nash committed c3c728b on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 157 more in hdfirmware

Merged staging to DEN-15741.

· /firmware/App/Modes/ModeTreatment.c

(-40, +28)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16102: fixed operation status event to be called after current mode is updating

Michael Garthwaite — Mon, 07 Aug 2023 15:07:21 -0700

Michael Garthwaite committed f658baf on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 156 more in hdfirmware

DEN-16102: fixed operation status event to be called after current mode is updating

· /firmware/App/Modes/OperationModes.c

(-2, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15994-rinseback-5-minute-timer-does-not-count-down...

Fri, 04 Aug 2023 15:03:16 -0700

James Walter Taylor committed f7eb704 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Address CR comments.

· /firmware/App/Modes/Rinseback.c

(-5, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15994-rinseback-5-minute-timer-does-not-count-down...

Fri, 04 Aug 2023 12:31:04 -0700

James Walter Taylor committed 2488c57 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Timer displayed only during a break in rinseback.

· /firmware/App/Modes/Rinseback.c

(-2, +6)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15994-rinseback-5-minute-timer-does-not-count-down...

Fri, 04 Aug 2023 09:21:17 -0700

James Walter Taylor committed 2c76211 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 150 more in hdfirmware

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Reverted. Test and expected behavior incorrect.

· /firmware/App/Modes/Rinseback.c

(-1, +1)

| History

| Source

| Diff