Fisheye on dgfirmware/

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Wed, 13 Sep 2023 09:52:18 -0700

James Walter Taylor committed 35a1f7d on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

On Dara's advice, ifdef'ed code for fill state treatment recovery

· /firmware/App/Modes/ModeFill.c

(-17, +12)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Tue, 12 Sep 2023 10:55:09 -0700

James Walter Taylor committed 9aacc7b on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Reset timers when doing a test recover state, or returning from a (reset) fault condition.

· /firmware/App/Modes/ModeFill.c

(-3, +5)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Fri, 08 Sep 2023 17:23:49 -0700

James Walter Taylor committed 482a741 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Reintroduced reservoir data structure change.

Corrected the setModeFillStateTransition semantics.

· /firmware/App/Modes/ModeFill.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-3, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Fri, 08 Sep 2023 14:57:57 -0700

James Walter Taylor committed abffc09 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Structure out of sync between HD/DG. Corrected.

· /firmware/App/Services/Reservoirs.h

(-0, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Fri, 08 Sep 2023 13:27:39 -0700

James Walter Taylor committed c2684b5 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Corrected spacing in the file per CR comments

· /firmware/App/Modes/ModeFill.c

(-1, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Fri, 08 Sep 2023 10:42:12 -0700

James Walter Taylor committed 66c487d on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Follow up for changes, simplifications suggested by Sean.

· /firmware/App/Modes/ModeFill.c

(-50, +24)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Thu, 07 Sep 2023 15:34:47 -0700

James Walter Taylor committed 6e76184 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Updated headers

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Thu, 07 Sep 2023 15:27:30 -0700

James Walter Taylor committed ade9db1 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

fill time allowance for time spent in pause state

Cleared fill timer on transition to generate

Added removed unused (and uninitialized) variables from broadcast data structure.

· /firmware/App/Modes/ModeFill.c	(-2, +38)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-3, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low...

Fri, 01 Sep 2023 16:38:08 -0700

James Walter Taylor committed 631df81 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Initial changes for alarm 206 timer

· /firmware/App/Modes/ModeFill.c	(-21, +23)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 31 Aug 2023 12:03:47 -0700

Dara Navaei committed a8ddfc7 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 68 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 31 Aug 2023 12:03:32 -0700

Dara Navaei committed 51d6753 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 68 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged DEN-16309

Dara Navaei — Thu, 31 Aug 2023 11:46:25 -0700

Dara Navaei committed bc5246a on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 68 more in dgfirmware

Merged DEN-16309

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16309 merged staging

Dara Navaei — Thu, 31 Aug 2023 09:14:26 -0700

Dara Navaei committed c7a1a88 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

DEN-16309 merged staging

· /firmware/App/Modes/ModeHeatDisinfect.c	(-6, +107)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-2, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16309 addressed a code review comment

Dara Navaei — Thu, 31 Aug 2023 09:12:28 -0700

Dara Navaei committed f4342d0 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

DEN-16309 addressed a code review comment

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 30 Aug 2023 15:49:00 -0700

Dara Navaei committed 7759cee on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 30 Aug 2023 15:48:53 -0700

Dara Navaei committed 16c0f81 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16093 changes merge in to staging

Vinayakam Mani — Wed, 30 Aug 2023 15:25:06 -0700

Vinayakam Mani committed e0ffb87 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

DEN-16093 changes merge in to staging

· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +21)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 30 Aug 2023 14:48:25 -0700

Dara Navaei committed 0a7076d on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 30 Aug 2023 14:48:11 -0700

Dara Navaei committed fd84d51 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeHeatDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'DIAL-281-requesting-heat-disinfect-timer-overrides' into staging

Michael Garthwaite — Wed, 30 Aug 2023 14:25:27 -0700

Michael Garthwaite committed 803b445 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

Merge branch 'DIAL-281-requesting-heat-disinfect-timer-overrides' into staging

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16323, DEN-16277 updated the chemical disinfect to get the level of the reservoir under disinfection more accurately...

Dara Navaei — Tue, 29 Aug 2023 16:56:18 -0700

Dara Navaei committed 7980373 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

DEN-16323, DEN-16277 updated the chemical disinfect to get the level of the reservoir under disinfection more accurately

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-20, +59)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'staging' into DEN-16309-heat-disinfect-has-spikes-in-temperature-near-95c-which-will-cause-water-to-boil-a...

Dara Navaei — Tue, 29 Aug 2023 12:38:31 -0700

Dara Navaei committed 7233fec on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

Merge branch 'staging' into DEN-16309-heat-disinfect-has-spikes-in-temperature-near-95c-which-will-cause-water-to-boil-at

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16309 updated the code. Changed the load cells' full level from 1900 to 1850 mL in heat disinfect to be consistent w...

Dara Navaei — Tue, 29 Aug 2023 12:38:11 -0700

Dara Navaei committed f245559 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

DEN-16309 updated the code. Changed the load cells' full level from 1900 to 1850 mL in heat disinfect to be consistent with the rest of the cleaning modes

· /firmware/App/Modes/ModeFault.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-281: Code review comments.

Michael Garthwaite — Tue, 29 Aug 2023 11:39:00 -0700

Michael Garthwaite committed 0bfc0cf on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

DIAL-281: Code review comments.

· /firmware/App/Modes/ModeHeatDisinfect.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-278: implementation of heat disinfection state timer overrides.

Michael Garthwaite — Tue, 29 Aug 2023 09:34:08 -0700

Michael Garthwaite committed 6703d91 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

DIAL-278: implementation of heat disinfection state timer overrides.

· /firmware/App/Modes/ModeHeatDisinfect.c	(-4, +105)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +64)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +7)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 28 Aug 2023 15:28:57 -0700

Dara Navaei committed ee36092 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 28 Aug 2023 09:36:10 -0700

Dara Navaei committed 0751995 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 28 Aug 2023 09:36:02 -0700

Dara Navaei committed 7ba136c on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'DIAL-276-dg-event-event-id-15-prints-duplicate-events-with-different-state-time' into staging

Michael Garthwaite — Mon, 28 Aug 2023 09:33:39 -0700

Michael Garthwaite committed 6be923e on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

Merge branch 'DIAL-276-dg-event-event-id-15-prints-duplicate-events-with-different-state-time' into staging

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16309 added a new heat disinfect state

Dara Navaei — Mon, 28 Aug 2023 08:43:53 -0700

Dara Navaei committed 12ccb89 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

DEN-16309 added a new heat disinfect state

· /firmware/App/Controllers/Heaters.c	(-7, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-10, +62)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-0, +1)	\| History	\| Source	\| Diff