Fisheye on dgfirmware/firmware

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'staging' into DEN-16382-alarm-207-dg-flow-meter-check-failure-triggers-after-alarm-282-bicarbonate-volume

Dara Navaei — Wed, 20 Sep 2023 09:53:21 -0700

Dara Navaei committed 2252531 on branch master, DEN-15791-dg-software-design-description and 60 more in dgfirmware

Merge branch 'staging' into DEN-16382-alarm-207-dg-flow-meter-check-failure-triggers-after-alarm-282-bicarbonate-volume

· /firmware/App/Modes/ModeFill.c

(-6, +8)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 19 Sep 2023 14:49:45 -0700

Dara Navaei committed f02f1ca on branch master, DEN-15791-dg-software-design-description and 60 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 19 Sep 2023 14:46:14 -0700

Dara Navaei committed b866887 on branch master, DEN-15791-dg-software-design-description and 60 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 19 Sep 2023 14:32:32 -0700

Dara Navaei committed 6afba30 on branch master, DEN-15791-dg-software-design-description and 60 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 19 Sep 2023 13:29:10 -0700

Dara Navaei committed c9984c8 on branch master, DEN-15791-dg-software-design-description and 60 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 19 Sep 2023 13:29:01 -0700

Dara Navaei committed 8c22edb on branch master, DEN-15791-dg-software-design-description and 60 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16382 updated the code to eliminate the extra fill command after the empty bottles alarm

Dara Navaei — Tue, 19 Sep 2023 13:12:21 -0700

Dara Navaei committed 5f1388c on branch master, DEN-15791-dg-software-design-description and 60 more in dgfirmware

DEN-16382 updated the code to eliminate the extra fill command after the empty bottles alarm

· /firmware/App/Modes/ModeDrain.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-8, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314 added code in the fill mode to set the start fill time if it was 0 even if the previous state in the fill mode...

Dara Navaei — Tue, 19 Sep 2023 11:19:10 -0700

Dara Navaei committed 45b9096 on branch master, DEN-15791-dg-software-design-description and 61 more in dgfirmware

DEN-16314 added code in the fill mode to set the start fill time if it was 0 even if the previous state in the fill mode was pause

· /firmware/App/Modes/ModeFill.c

(-4, +6)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16382: Prevent empty concentrate bottle alarms when mix with water test config is active.

Sean Nash — Tue, 19 Sep 2023 09:34:55 -0700

Sean Nash committed f10c653 on branch master, DEN-15791-dg-software-design-description and 60 more in dgfirmware

DEN-16382: Prevent empty concentrate bottle alarms when mix with water test config is active.

· /firmware/App/Modes/ModeDrain.c	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 18 Sep 2023 17:18:33 -0700

Dara Navaei committed 3205006 on branch master, DEN-15791-dg-software-design-description and 61 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 18 Sep 2023 10:50:49 -0700

Dara Navaei committed c2fe488 on branch master, DEN-15791-dg-software-design-description and 61 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 18 Sep 2023 10:50:41 -0700

Dara Navaei committed cf9f459 on branch master, DEN-15791-dg-software-design-description and 61 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-285: fix to ensure we see transitions of submode.

Michael Garthwaite — Mon, 18 Sep 2023 08:53:20 -0700

Michael Garthwaite committed 8a25d57 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

DIAL-285: fix to ensure we see transitions of submode.

· /firmware/App/Modes/OperationModes.c

(-0, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 15 Sep 2023 16:38:43 -0700

Dara Navaei committed b220330 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 15 Sep 2023 16:38:36 -0700

Dara Navaei committed 8ee0169 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 15 Sep 2023 15:32:53 -0700

Dara Navaei committed 57a6c33 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 15 Sep 2023 15:32:40 -0700

Dara Navaei committed becd984 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated the chemical disinfect

Dara Navaei — Fri, 15 Sep 2023 08:50:56 -0700

Dara Navaei committed 3223b2c on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

DEN-15973 updated the chemical disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +7)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated chem disinfect

Dara Navaei — Thu, 14 Sep 2023 18:04:08 -0700

Dara Navaei committed 3835a00 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

DEN-15973 updated chem disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated chemical disinfect

Dara Navaei — Thu, 14 Sep 2023 17:37:21 -0700

Dara Navaei committed e6ecfc3 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

DEN-15973 updated chemical disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16432 fixed the heat disinfect temperature out of range trial count error

Dara Navaei — Thu, 14 Sep 2023 17:01:11 -0700

Dara Navaei committed efa2127 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

DEN-16432 fixed the heat disinfect temperature out of range trial count error

· /firmware/App/Modes/ModeHeatDisinfect.c

(-2, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated the chemical disinfect

Dara Navaei — Thu, 14 Sep 2023 15:35:48 -0700

Dara Navaei committed 719abb7 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

DEN-15973 updated the chemical disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-2, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated chemical disinfect

Dara Navaei — Thu, 14 Sep 2023 13:26:44 -0700

Dara Navaei committed ddad43b on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

DEN-15973 updated chemical disinfect

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 addressed the code review comments

Dara Navaei — Thu, 14 Sep 2023 10:27:29 -0700

Dara Navaei committed c47dc63 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

DEN-15973 addressed the code review comments

· /firmware/App/Modes/ModeStandby.c

(-4, +4)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 addressed the code review comments

Dara Navaei — Thu, 14 Sep 2023 09:48:13 -0700

Dara Navaei committed 5379702 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

DEN-15973 addressed the code review comments

· /firmware/App/Controllers/Pressures.c	(-12, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 14 Sep 2023 09:29:42 -0700

Dara Navaei committed dbb4273 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 14 Sep 2023 09:29:29 -0700

Dara Navaei committed 5459a8a on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated the code

Dara Navaei — Thu, 14 Sep 2023 09:27:33 -0700

Dara Navaei committed 8f3e72f on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

DEN-15973 updated the code

· /firmware/App/Controllers/Pressures.c

(-1, +0)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 changed the minimum inlet pressure to be a variable based on the maximum inlet water pressure set

Dara Navaei — Thu, 14 Sep 2023 08:31:22 -0700

Dara Navaei committed 8e4c986 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

DEN-15973 changed the minimum inlet pressure to be a variable based on the maximum inlet water pressure set

· /firmware/App/Controllers/Pressures.c

(-2, +6)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 fixed the inlet water pressure alarm. DEN-16418 added chemical flush done after chemical disinfect prior to st...

Dara Navaei — Wed, 13 Sep 2023 16:47:43 -0700

Dara Navaei committed f5fae90 on branch master, DEN-15791-dg-software-design-description and 62 more in dgfirmware

DEN-15973 fixed the inlet water pressure alarm. DEN-16418 added chemical flush done after chemical disinfect prior to starting RO permeate sample mode

· /firmware/App/Controllers/Pressures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +11)	\| History	\| Source	\| Diff