Fisheye on application/sources/storage/Settings.cpp

Fisheye on application/sources/storage/Settings.cpp https://devapps.diality.us/changelog/~br%3DDEN-16419-UI-BN-S106/application/sources/storage/Settings.cpp Recent activity in "application" under directory /sources/storage/Settings.cpp UI-LEAH-1924-3: closed by Dara Navaei Tue, 19 Nov 2024 15:28:09 -0800 Dara Navaei https://devapps.diality.us/cru/UI-LEAH-1924-3 https://devapps.diality.us/cru/UI-LEAH-1924-3 Dara Navaei Closed UI-LEAH-1924-3 ]]> UI-LEAH-1924-3: reviewers finished Tue, 19 Nov 2024 14:31:29 -0800 https://devapps.diality.us/cru/UI-LEAH-1924-3 https://devapps.diality.us/cru/UI-LEAH-1924-3 Dara Navaei and Behrouz NematiPour finished reviewing UI-LEAH-1924-3 UI-LEAH-1924_Leahi/Features/Leah 1924 UI AM S4 Translation ]]> UI-LEAH-1924-3: started by Dara Navaei Mon, 18 Nov 2024 11:37:55 -0800 Dara Navaei https://devapps.diality.us/cru/UI-LEAH-1924-3 https://devapps.diality.us/cru/UI-LEAH-1924-3 Dara Navaei started review UI-LEAH-1924-3 ]]> UI-DEN-SUNRISE-1: closed by Dara Navaei Fri, 15 Nov 2024 12:54:28 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 Dara Navaei Closed UI-DEN-SUNRISE-1 ]]> UI-DEN-SUNRISE-1: reviewers removed from UI-DEN-SUNRISE Fri, 07 Jun 2024 09:05:01 -0700 https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 Dara Navaei removed Sean Nash and vduong (deleted user) from UI-DEN-SUNRISE-1 UI-DEN-SUNRISE ]]> UI-DEN-SUNRISE-1: started by Dara Navaei Fri, 07 Jun 2024 09:04:34 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 Dara Navaei started review UI-DEN-SUNRISE-1 ]]> UI-DEN-8705-1: reviewers resumed Thu, 19 Oct 2023 20:26:58 -0700 https://devapps.diality.us/cru/UI-DEN-8705-1 https://devapps.diality.us/cru/UI-DEN-8705-1 pmontazemi (deleted user) resumed reviewing UI-DEN-8705-1 UI-DEN-8705_Pre Treatment Setup Screen ]]> UI-DEN-15279-1: closed by Dara Navaei Thu, 19 Oct 2023 10:36:25 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1 https://devapps.diality.us/cru/UI-DEN-15279-1 Dara Navaei Closed UI-DEN-15279-1 ]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:36:13 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19159 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19159 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:35:11 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19158 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19158 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:33:57 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19157 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19157 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:33:17 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19156 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19156 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:33:12 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19155 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19155 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:33:04 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19154 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19154 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:32:36 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19153 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19153 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: started by Dara Navaei Thu, 19 Oct 2023 10:31:30 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1 https://devapps.diality.us/cru/UI-DEN-15279-1 Dara Navaei started review UI-DEN-15279-1 ]]> UI-DEN-15905-10: closed by Dara Navaei Thu, 19 Oct 2023 10:24:48 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15905-10 https://devapps.diality.us/cru/UI-DEN-15905-10 Dara Navaei Closed UI-DEN-15905-10 ]]> UI-DEN-15905-10: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:24:43 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15905-10/#c19145 https://devapps.diality.us/cru/UI-DEN-15905-10/#c19145 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15905-10

RESOLVED

]]> UI-DEN-15905-10: started by Dara Navaei Thu, 19 Oct 2023 10:24:34 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15905-10 https://devapps.diality.us/cru/UI-DEN-15905-10 Dara Navaei started review UI-DEN-15905-10 ]]> UI-UCOMMITS-5: closed by Dara Navaei Thu, 14 Sep 2023 09:49:54 -0700 Dara Navaei https://devapps.diality.us/cru/UI-UCOMMITS-5 https://devapps.diality.us/cru/UI-UCOMMITS-5 Dara Navaei Closed UI-UCOMMITS-5 ]]> UI-UCOMMITS-5: reviewers finished Thu, 14 Sep 2023 09:34:21 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-5 https://devapps.diality.us/cru/UI-UCOMMITS-5 Dara Navaei finished reviewing UI-UCOMMITS-5 UI Staging Unreviewed Commits ]]> UI-DEN-16335-3: closed by Behrouz NematiPour Mon, 11 Sep 2023 16:11:25 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16335-3 https://devapps.diality.us/cru/UI-DEN-16335-3 Behrouz NematiPour Closed UI-DEN-16335-3 ]]> UI-DEN-16335-3: comment by Behrouz NematiPour "RESOLVED" Mon, 11 Sep 2023 16:09:50 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16335-3/#c18892 https://devapps.diality.us/cru/UI-DEN-16335-3/#c18892 Behrouz NematiPour replied to Behrouz NematiPour in UI-DEN-16335-3

RESOLVED

]]> UI-DEN-16335-3: comment by Behrouz NematiPour "I made myself the moderator to close the review..." Mon, 11 Sep 2023 16:09:34 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16335-3/#c18891 https://devapps.diality.us/cru/UI-DEN-16335-3/#c18891 Behrouz NematiPour commented on UI-DEN-16335-3

I made myself the moderator to close the review after I was done with my 100% no comment left completed review.

]]> UI-DEN-16335-3: started by vduong Wed, 06 Sep 2023 11:35:18 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16335-3 https://devapps.diality.us/cru/UI-DEN-16335-3 vduong (deleted user) started review UI-DEN-16335-3 ]]> UI-DEN-16335-3: closed by vduong Wed, 06 Sep 2023 10:53:52 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16335-3 https://devapps.diality.us/cru/UI-DEN-16335-3 vduong (deleted user) Closed UI-DEN-16335-3 ]]> UI-DEN-16335-3: reviewers finished Wed, 06 Sep 2023 09:50:30 -0700 https://devapps.diality.us/cru/UI-DEN-16335-3 https://devapps.diality.us/cru/UI-DEN-16335-3 msuleiman (deleted user) finished reviewing UI-DEN-16335-3 UI-DEN-16335_UI VD S105 Disable confirm device config - [READY] ]]> application (release/stagingmerge-DEN-16786-ui-dn-s119): DEN-16235: Updated - UI Device Setup - Device Configuration screen "Confirm" button should not be allowed to be pressed ... Wed, 06 Sep 2023 08:21:52 -0700 Vy <vduong@sunriselabs.com> https://devapps.diality.us/changelog/application?cs=f3fa6fc6db9af49b39a22ca6584bd388caec407c https://devapps.diality.us/changelog/application?cs=f3fa6fc6db9af49b39a22ca6584bd388caec407c Vy <vduong@sunriselabs.com> committed f3fa6fc on branch master, @Environement_Swith and 94 more in application DEN-16235: Updated - UI Device Setup - Device Configuration screen "Confirm" button should not be allowed to be pressed more than once

Per Code Review Discussions:

- Remove the directory comparison function

- Remove the added variables from last commit (isExited, etc)

- Change logic for cryptSetupEnabled property setting

· /sources/device/DeviceController.cpp (-2, +0) | History | Source | Diff

· /sources/device/DeviceModels.h (-1, +0) | History | Source | Diff

· /sources/device/DeviceView.cpp (-2, +3) | History | Source | Diff

· /sources/device/DeviceView.h (-1, +0) | History | Source | Diff

· /sources/gui/qml/pages/settings/SettingsManufacturingSetup.qml (-1, +1) | History | Source | Diff

· /sources/storage/FileHandler.cpp (-29, +0) | History | Source | Diff

· /sources/storage/FileHandler.h (-1, +0) | History | Source | Diff

· /sources/storage/Settings.cpp (-1, +0) | History | Source | Diff

]]> UI-DEN-16335-3: started by Dara Navaei Fri, 01 Sep 2023 12:05:35 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16335-3 https://devapps.diality.us/cru/UI-DEN-16335-3 Dara Navaei started review UI-DEN-16335-3 ]]> application (release/stagingmerge-DEN-16786-ui-dn-s119): DEN-16235: Fixed - UI Device Setup - Device Configuration screen "Confirm" button should not be allowed to be pressed mo... Fri, 01 Sep 2023 10:17:29 -0700 Vy <vduong@sunriselabs.com> https://devapps.diality.us/changelog/application?cs=4fc7cdc599de191e91296623ec783542b7a3c7b8 https://devapps.diality.us/changelog/application?cs=4fc7cdc599de191e91296623ec783542b7a3c7b8 Vy <vduong@sunriselabs.com> committed 4fc7cdc on branch master, @Environement_Swith and 94 more in application DEN-16235: Fixed - UI Device Setup - Device Configuration screen "Confirm" button should not be allowed to be pressed more than once

Add logic to properly handle disabling the confirm button when the device configuration is complete

Add a command to compare two directories for sameness

Add correct displaying of the completion of the device configurations

· /sources/device/DeviceController.cpp (-0, +3) | History | Source | Diff

· /sources/device/DeviceModels.h (-0, +1) | History | Source | Diff

· /sources/device/DeviceView.cpp (-1, +2) | History | Source | Diff

· /sources/device/DeviceView.h (-0, +1) | History | Source | Diff

· /sources/gui/qml/pages/settings/SettingsManufacturingSetup.qml (-1, +1) | History | Source | Diff

· /sources/storage/FileHandler.cpp (-0, +30) | History | Source | Diff

· /sources/storage/FileHandler.h (-0, +1) | History | Source | Diff

· /sources/storage/Settings.cpp (-0, +1) | History | Source | Diff

]]>