Fisheye on hdfirmware/firmware/App/Drivers/Battery.h https://devapps.diality.us/changelog/~br%3DDEN-16446-dg-dev-test-clean-up/hdfirmware/firmware/App/Drivers/Battery.h Recent activity in "hdfirmware" under directory /firmware/App/Drivers/Battery.h HD-DEN-13834-1: closed by Dara Navaei Wed, 18 Oct 2023 21:14:51 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-13834-1 https://devapps.diality.us/cru/HD-DEN-13834-1 Dara Navaei Closed HD-DEN-13834-1 ]]> HD-DEN-13834-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:13:46 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-13834-1/#c19061 https://devapps.diality.us/cru/HD-DEN-13834-1/#c19061 Dara Navaei replied to Sean Nash in HD-DEN-13834-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-13834-1: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH" Wed, 18 Oct 2023 21:07:43 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-13834-1/#c19060 https://devapps.diality.us/cru/HD-DEN-13834-1/#c19060 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-13834-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-13834-1: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH" Wed, 18 Oct 2023 21:07:15 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-13834-1/#c19059 https://devapps.diality.us/cru/HD-DEN-13834-1/#c19059 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-13834-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-13834-1: started by Dara Navaei Wed, 18 Oct 2023 21:05:58 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-13834-1 https://devapps.diality.us/cru/HD-DEN-13834-1 Dara Navaei started review HD-DEN-13834-1 ]]> HD-DEN-14815-1: closed by Sean Nash Mon, 14 Aug 2023 13:41:35 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-14815-1 https://devapps.diality.us/cru/HD-DEN-14815-1 Sean Nash Closed HD-DEN-14815-1 ]]> HD-DEN-14815-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Fri, 11 Aug 2023 17:06:52 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-14815-1/#c18557 https://devapps.diality.us/cru/HD-DEN-14815-1/#c18557 wbracken  (deleted user) replied to Sean Nash in HD-DEN-14815-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-14815-1: comment by Sean Nash "Done." Fri, 11 Aug 2023 16:20:20 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-14815-1/#c18555 https://devapps.diality.us/cru/HD-DEN-14815-1/#c18555 Sean Nash replied to wbracken  (deleted user) in HD-DEN-14815-1

Done.

]]> HD-DEN-14815-1: reviewers resumed Fri, 11 Aug 2023 10:20:36 -0700 https://devapps.diality.us/cru/HD-DEN-14815-1 https://devapps.diality.us/cru/HD-DEN-14815-1 Behrouz NematiPour resumed reviewing HD-DEN-14815-1 HD-DEN-14815_Cartridge Removal Screen IS Displayed Prematurely ]]> HD-DEN-14815-1: reviewers joined HD-DEN-14815_Cartridge Removal Screen IS Displayed... Fri, 11 Aug 2023 04:24:18 -0700 https://devapps.diality.us/cru/HD-DEN-14815-1 https://devapps.diality.us/cru/HD-DEN-14815-1 Behrouz NematiPour joined HD-DEN-14815-1 HD-DEN-14815_Cartridge Removal Screen IS Displayed Prematurely ]]> HD-DEN-14815-1: comment by wbracken "Add currentPostTreatmentState to header" Thu, 10 Aug 2023 09:47:58 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-14815-1/#c18531 https://devapps.diality.us/cru/HD-DEN-14815-1/#c18531 wbracken  (deleted user) commented on HD-DEN-14815-1

Add currentPostTreatmentState to header

]]> HD-DEN-14815-1: started by Dara Navaei Wed, 09 Aug 2023 18:04:13 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14815-1 https://devapps.diality.us/cru/HD-DEN-14815-1 Dara Navaei started review HD-DEN-14815-1 ]]> HD-DEN-15306-3: closed by Dara Navaei Wed, 14 Jun 2023 12:59:39 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-15306-3 https://devapps.diality.us/cru/HD-DEN-15306-3 Dara Navaei Closed HD-DEN-15306-3 ]]> HD-DEN-15306-3: reviewers finished Wed, 14 Jun 2023 12:57:52 -0700 https://devapps.diality.us/cru/HD-DEN-15306-3 https://devapps.diality.us/cru/HD-DEN-15306-3 Sean Nash finished reviewing HD-DEN-15306-3 HD-DEN-15306_HD Fault Valve Position Alarm After Restoring AC Power 4 - Ready ]]> HD-DEN-15306-3: reviewers finished Tue, 13 Jun 2023 11:48:56 -0700 https://devapps.diality.us/cru/HD-DEN-15306-3 https://devapps.diality.us/cru/HD-DEN-15306-3 wbracken  (deleted user) finished reviewing HD-DEN-15306-3 HD-DEN-15306_HD Fault Valve Position Alarm After Restoring AC Power 4 - Ready ]]> HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 02 Jun 2023 18:27:34 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15306-3/#c17753 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17753 Sean Nash replied to jtaylor  (deleted user) in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15306-3: comment by jtaylor "Done." Fri, 02 Jun 2023 17:54:30 -0700 jtaylor https://devapps.diality.us/cru/HD-DEN-15306-3/#c17752 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17752 jtaylor  (deleted user) replied to Sean Nash in HD-DEN-15306-3

Done.

]]> HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 02 Jun 2023 17:21:13 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15306-3/#c17751 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17751 Sean Nash replied to jtaylor  (deleted user) in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 02 Jun 2023 17:20:43 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15306-3/#c17750 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17750 Sean Nash replied to jtaylor  (deleted user) in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 02 Jun 2023 17:20:09 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15306-3/#c17749 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17749 Sean Nash replied to jtaylor  (deleted user) in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15306-3: comment by jtaylor "Done." Fri, 02 Jun 2023 17:08:02 -0700 jtaylor https://devapps.diality.us/cru/HD-DEN-15306-3/#c17748 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17748 jtaylor  (deleted user) replied to Sean Nash in HD-DEN-15306-3

Done.

]]> HD-DEN-15306-3: comment by jtaylor "Oops. DeMorganized and done." Fri, 02 Jun 2023 17:06:48 -0700 jtaylor https://devapps.diality.us/cru/HD-DEN-15306-3/#c17747 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17747 jtaylor  (deleted user) replied to Sean Nash in HD-DEN-15306-3

Oops. DeMorganized and done.

]]> HD-DEN-15306-3: comment by jtaylor "Done." Fri, 02 Jun 2023 16:58:49 -0700 jtaylor https://devapps.diality.us/cru/HD-DEN-15306-3/#c17746 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17746 jtaylor  (deleted user) replied to Sean Nash in HD-DEN-15306-3

Done.

]]> HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 02 Jun 2023 16:53:28 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15306-3/#c17745 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17745 Sean Nash replied to jtaylor  (deleted user) in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15306-3: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Fri, 02 Jun 2023 16:51:40 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15306-3/#c17744 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17744 wbracken  (deleted user) replied to jtaylor  (deleted user) in HD-DEN-15306-3

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-15306-3: comment by Sean Nash "Remove space between ()." Fri, 02 Jun 2023 16:51:00 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15306-3/#c17743 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17743 Sean Nash commented on HD-DEN-15306-3

Remove space between ().

]]> HD-DEN-15306-3: comment by Sean Nash "Add blank line between declaration and code. ..." Fri, 02 Jun 2023 16:43:27 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15306-3/#c17742 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17742 Sean Nash commented on HD-DEN-15306-3

Add blank line between declaration and code.

Prefer we not assume bool and BOOL are the same. Use if statement and explicit assignment of TRUE to result if all conditions are true.

First condition seems backward.

Second and third conditions seem problematic. You will never trigger an AC power loss alarm. Should remove them I think.

]]> HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 02 Jun 2023 16:41:05 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15306-3/#c17741 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17741 Sean Nash replied to jtaylor  (deleted user) in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 02 Jun 2023 16:40:13 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15306-3/#c17740 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17740 Sean Nash replied to Sean Nash in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 02 Jun 2023 16:39:45 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15306-3/#c17739 https://devapps.diality.us/cru/HD-DEN-15306-3/#c17739 Sean Nash replied to jtaylor  (deleted user) in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

]]>