Fisheye on hdfirmware/firmware/App/Modes/SampleWater.c https://devapps.diality.us/changelog/~br%3DDEN-16446-dg-dev-test-clean-up/hdfirmware/firmware/App/Modes/SampleWater.c Recent activity in "hdfirmware" under directory /firmware/App/Modes/SampleWater.c HD-DEN-11750-2: closed by Dara Navaei Thu, 19 Oct 2023 09:48:02 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2 https://devapps.diality.us/cru/HD-DEN-11750-2 Dara Navaei Closed HD-DEN-11750-2 ]]> HD-DEN-11750-2: started by Dara Navaei Thu, 19 Oct 2023 09:43:27 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2 https://devapps.diality.us/cru/HD-DEN-11750-2 Dara Navaei started review HD-DEN-11750-2 ]]> HD-DEN-11750-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:40:54 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2/#c19140 https://devapps.diality.us/cru/HD-DEN-11750-2/#c19140 Dara Navaei replied to Michael Garthwaite in HD-DEN-11750-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-11750-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:40:30 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2/#c19139 https://devapps.diality.us/cru/HD-DEN-11750-2/#c19139 Dara Navaei replied to Michael Garthwaite in HD-DEN-11750-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-11750-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:28:53 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2/#c19136 https://devapps.diality.us/cru/HD-DEN-11750-2/#c19136 Dara Navaei replied to Michael Garthwaite in HD-DEN-11750-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-11750-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:28:44 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2/#c19135 https://devapps.diality.us/cru/HD-DEN-11750-2/#c19135 Dara Navaei replied to Michael Garthwaite in HD-DEN-11750-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-11750-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:27:40 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2/#c19134 https://devapps.diality.us/cru/HD-DEN-11750-2/#c19134 Dara Navaei replied to Michael Garthwaite in HD-DEN-11750-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-11750-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:27:30 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2/#c19133 https://devapps.diality.us/cru/HD-DEN-11750-2/#c19133 Dara Navaei replied to Michael Garthwaite in HD-DEN-11750-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-11750-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:27:01 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2/#c19132 https://devapps.diality.us/cru/HD-DEN-11750-2/#c19132 Dara Navaei replied to Michael Garthwaite in HD-DEN-11750-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-11750-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:25:47 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2/#c19131 https://devapps.diality.us/cru/HD-DEN-11750-2/#c19131 Dara Navaei replied to Michael Garthwaite in HD-DEN-11750-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-11750-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:24:57 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2/#c19130 https://devapps.diality.us/cru/HD-DEN-11750-2/#c19130 Dara Navaei replied to Michael Garthwaite in HD-DEN-11750-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-11750-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:24:18 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2/#c19129 https://devapps.diality.us/cru/HD-DEN-11750-2/#c19129 Dara Navaei replied to Michael Garthwaite in HD-DEN-11750-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-11750-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:24:06 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2/#c19128 https://devapps.diality.us/cru/HD-DEN-11750-2/#c19128 Dara Navaei replied to Michael Garthwaite in HD-DEN-11750-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-15196-3: closed by Dara Navaei Thu, 19 Oct 2023 09:02:04 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-15196-3 https://devapps.diality.us/cru/HD-DEN-15196-3 Dara Navaei Closed HD-DEN-15196-3 ]]> HD-DEN-15196-3: reviewers finished Thu, 19 Oct 2023 09:01:58 -0700 https://devapps.diality.us/cru/HD-DEN-15196-3 https://devapps.diality.us/cru/HD-DEN-15196-3 Dara Navaei finished reviewing HD-DEN-15196-3 HD-DEN-15196_DEN-15353_and_DIAL-258 ]]> HD-DEN-15196-3: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:01:44 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-15196-3/#c19117 https://devapps.diality.us/cru/HD-DEN-15196-3/#c19117 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-15196-3

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-15196-3: started by Dara Navaei Thu, 19 Oct 2023 08:59:59 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-15196-3 https://devapps.diality.us/cru/HD-DEN-15196-3 Dara Navaei started review HD-DEN-15196-3 ]]> HD-UCOMMITS-19: closed by Sean Nash Thu, 03 Aug 2023 08:57:40 -0700 Sean Nash https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Sean Nash Closed HD-UCOMMITS-19 ]]> HD-UCOMMITS-19: reviewers finished Wed, 02 Aug 2023 21:26:40 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Dara Navaei and Sean Nash finished reviewing HD-UCOMMITS-19 HD Staging Unreviewed Commits ]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 02 Jun 2023 14:05:13 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=5fcae5901d466789c329256f5532cf64be549c83 https://devapps.diality.us/changelog/hdfirmware?cs=5fcae5901d466789c329256f5532cf64be549c83 Dara Navaei committed 5fcae59 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 208 more in hdfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ConsumableSelfTest.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModePostTreat.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeTreatmentParams.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/PreTreatmentRecirc.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/SampleWater.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/SelfTests.c (-2, +2) | History | Source | Diff
]]> HD-DEN-15196-3: closed by Michael Garthwaite Fri, 02 Jun 2023 12:10:09 -0700 Michael Garthwaite https://devapps.diality.us/cru/HD-DEN-15196-3 https://devapps.diality.us/cru/HD-DEN-15196-3 Michael Garthwaite Closed HD-DEN-15196-3 ]]> HD-DEN-15196-3: reviewers finished Fri, 02 Jun 2023 12:03:21 -0700 https://devapps.diality.us/cru/HD-DEN-15196-3 https://devapps.diality.us/cru/HD-DEN-15196-3 jtaylor  (deleted user) and Sean Nash finished reviewing HD-DEN-15196-3 HD-DEN-15196_DEN-15353_and_DIAL-258 ]]> HD-DEN-15196-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 02 Jun 2023 11:26:47 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15196-3/#c17707 https://devapps.diality.us/cru/HD-DEN-15196-3/#c17707 Sean Nash replied to Michael Garthwaite in HD-DEN-15196-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15196-3: comment by Michael Garthwaite "fixed. set to no sub state (0xFF) once we trans..." Fri, 02 Jun 2023 11:24:28 -0700 Michael Garthwaite https://devapps.diality.us/cru/HD-DEN-15196-3/#c17706 https://devapps.diality.us/cru/HD-DEN-15196-3/#c17706 Michael Garthwaite replied to Sean Nash in HD-DEN-15196-3

fixed. set to no sub state (0xFF) once we transition to pretx recirc

]]> HD-DEN-15196-3: comment by Sean Nash "Looks like this is only being set in wet self-t..." Fri, 02 Jun 2023 11:11:40 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15196-3/#c17705 https://devapps.diality.us/cru/HD-DEN-15196-3/#c17705 Sean Nash commented on HD-DEN-15196-3

Looks like this is only being set in wet self-tests substate of pre-tx prime. Once we leave wet self-tests, should this 4th level state be set back to zero or something?

]]> HD-DEN-15196-3: comment by wbracken "FIXED IN CODE WALKTHROUGH" Thu, 01 Jun 2023 15:38:56 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15196-3/#c17692 https://devapps.diality.us/cru/HD-DEN-15196-3/#c17692 wbracken  (deleted user) replied to Michael Garthwaite in HD-DEN-15196-3

FIXED IN CODE WALKTHROUGH

]]> HD-DEN-15196-3: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Thu, 01 Jun 2023 15:38:23 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15196-3/#c17691 https://devapps.diality.us/cru/HD-DEN-15196-3/#c17691 wbracken  (deleted user) replied to Michael Garthwaite in HD-DEN-15196-3

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-15196-3: comment by Michael Garthwaite "Fixed. Thanks!" Thu, 01 Jun 2023 15:34:02 -0700 Michael Garthwaite https://devapps.diality.us/cru/HD-DEN-15196-3/#c17689 https://devapps.diality.us/cru/HD-DEN-15196-3/#c17689 Michael Garthwaite replied to wbracken  (deleted user) in HD-DEN-15196-3

Fixed. Thanks!

]]> HD-DEN-15196-3: comment by Michael Garthwaite "Fixed. Thanks!" Thu, 01 Jun 2023 15:33:59 -0700 Michael Garthwaite https://devapps.diality.us/cru/HD-DEN-15196-3/#c17688 https://devapps.diality.us/cru/HD-DEN-15196-3/#c17688 Michael Garthwaite replied to wbracken  (deleted user) in HD-DEN-15196-3

Fixed. Thanks!

]]> HD-DEN-15196-3: comment by wbracken "Add current4thLevleState to header." Thu, 01 Jun 2023 15:29:57 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15196-3/#c17687 https://devapps.diality.us/cru/HD-DEN-15196-3/#c17687 wbracken  (deleted user) commented on HD-DEN-15196-3

Add current4thLevleState to header.

]]>