Fisheye on hdfirmware/firmware/source/adc.c

HD-DEN-1312-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 09:33:22 -0700

Dara Navaei Closed HD-DEN-1312-1

HD-DEN-1312-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 09:32:52 -0700

Dara Navaei replied to Sean Nash in HD-DEN-1312-1

RESOLVED in CODE WALKTHROUGH

HD-DEN-1312-1: reviewers resumed

Thu, 19 Oct 2023 09:31:46 -0700

Dara Navaei resumed reviewing HD-DEN-1312-1

HD-DEN-1312_HD Dialysate Inlet Pump/Drive, Flow Sensor, Control

HD-DEN-1312-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 09:31:28 -0700

Dara Navaei started review HD-DEN-1312-1

HD-DEN-3115-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:40:42 -0700

Dara Navaei Closed HD-DEN-3115-1

HD-DEN-3115-1: reviewers finished

Thu, 19 Oct 2023 08:40:34 -0700

Dara Navaei finished reviewing HD-DEN-3115-1

HD-DEN-3115_HD Blood Flow 3 of 3

HD-DEN-3115-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:40:25 -0700

Dara Navaei replied to qnguyen (deleted user) in HD-DEN-3115-1

RESOLVED in CODE WALKTHROUGH

HD-DEN-3115-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:39:15 -0700

Dara Navaei started review HD-DEN-3115-1

HD-DEN-7605-2: closed by Sean Nash

Sean Nash — Thu, 10 Jun 2021 15:22:25 -0700

Sean Nash Closed HD-DEN-7605-2

HD-DEN-7605-2: reviewers finished

Thu, 10 Jun 2021 15:04:53 -0700

qnguyen (deleted user) , Dara Navaei and pmontazemi (deleted user) finished reviewing HD-DEN-7605-2

HD-DEN-7605_HD DG Self Tests

HD-DEN-7605-2: comment by qnguyen "RESOLVED in CODE WALKTHROUGH."

qnguyen — Mon, 07 Jun 2021 10:32:45 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-7605-2

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2: comment by Sean Nash "Good point. Test will need to be longer than 5..."

Sean Nash — Mon, 07 Jun 2021 09:26:24 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-7605-2

Good point. Test will need to be longer than 50ms anyway - FPGA ramps the sound and there is a ~250ms time constant in the electronics. But I will want the sound to at least get started immediately.

HD-DEN-7605-2: comment by qnguyen "Should we call setAlarmAudio here? This test i..."

qnguyen — Fri, 04 Jun 2021 10:31:16 -0700

qnguyen (deleted user) commented on HD-DEN-7605-2

Should we call setAlarmAudio here?
This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

HD-DEN-7605-2: comment by qnguyen "RESOLVED in CODE WALKTHROUGH."

qnguyen — Fri, 28 May 2021 10:34:03 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-7605-2

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2: comment by qnguyen "RESOLVED in CODE WALKTHROUGH."

qnguyen — Fri, 28 May 2021 10:33:43 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-7605-2

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH."

pmontazemi — Thu, 27 May 2021 10:31:01 -0700

pmontazemi (deleted user) replied to qnguyen (deleted user) in HD-DEN-7605-2

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2: comment by qnguyen "This will be addressed in DEN-8103."

qnguyen — Tue, 18 May 2021 10:42:42 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-7605-2

This will be addressed in DEN-8103.

HD-DEN-7605-2: comment by qnguyen "RESOLVED in CODE WALKTHROUGH."

qnguyen — Tue, 18 May 2021 10:40:24 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-7605-2

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2: comment by qnguyen "RESOLVED in CODE WALKTHROUGH."

qnguyen — Tue, 18 May 2021 10:40:00 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-7605-2

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2: comment by qnguyen "RESOLVED in CODE WALKTHROUGH."

qnguyen — Tue, 18 May 2021 10:39:29 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-7605-2

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2: comment by Sean Nash "Agreed. This is for me to add a check for this..."

Sean Nash — Tue, 11 May 2021 14:54:49 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-7605-2

Agreed. This is for me to add a check for this error. Will remove comment when I'm done.

HD-DEN-7605-2: comment by Sean Nash "Is this still an issue?"

Sean Nash — Tue, 11 May 2021 14:54:20 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-7605-2

Is this still an issue?

HD-DEN-7605-2: comment by Sean Nash "Agreed. This is for me to add a check for this..."

Sean Nash — Tue, 11 May 2021 14:53:53 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-7605-2

Agreed. This is for me to add a check for this error. I'll remove comment when I'm done.

HD-DEN-7605-2: comment by Sean Nash "Is this still an issue?"

Sean Nash — Tue, 11 May 2021 14:53:06 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-7605-2

Is this still an issue?

HD-DEN-7605-2: comment by qnguyen "Need to remove this comment."

qnguyen — Fri, 07 May 2021 00:00:30 -0700

qnguyen (deleted user) commented on HD-DEN-7605-2

Need to remove this comment.

HD-DEN-7605-2: comment by qnguyen "Need to remove this comment."

qnguyen — Fri, 07 May 2021 00:07:09 -0700

qnguyen (deleted user) commented on HD-DEN-7605-2

Need to remove this comment.

HD-DEN-7605-2: comment by qnguyen "Same as comment from DialinFlow.c"

qnguyen — Fri, 07 May 2021 00:06:54 -0700

qnguyen (deleted user) commented on HD-DEN-7605-2

Same as comment from DialinFlow.c

HD-DEN-7605-2: comment by qnguyen "We can't have 3 calls to isPersistentAlarmTrigg..."

qnguyen — Fri, 07 May 2021 00:01:50 -0700

qnguyen (deleted user) commented on HD-DEN-7605-2

We can't have 3 calls to isPersistentAlarmTriggered() on same alarm. If the first call starts the timer and the second or third call is good, it will reset the timer to 0 again.
Suggest creating a BOOL variable to have all three conditions or with each other and call isPersistentAlarmTriggered() only once.

HD-DEN-7605-2: comment by Sean Nash "initBloodPrime() is called every time we transi..."

Sean Nash — Thu, 06 May 2021 10:27:32 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-7605-2

initBloodPrime() is called every time we transition to blood prime sub-mode.

HD-DEN-7605-2: comment by qnguyen "Blood prime last motor count does not seem to g..."

qnguyen — Wed, 05 May 2021 19:57:05 -0700

qnguyen (deleted user) commented on HD-DEN-7605-2

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?