Fisheye on dgfirmware/

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 addressed the code review comments

Dara Navaei — Tue, 30 Jan 2024 09:12:27 -0800

Dara Navaei committed d2df61e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 addressed the code review comments

· /firmware/App/Services/SystemCommMessages.c

(-5, +5)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 removed the name from the typedef structs for doxygen

Dara Navaei — Tue, 23 Jan 2024 10:44:33 -0800

Dara Navaei committed f26f805 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 removed the name from the typedef structs for doxygen

· /firmware/App/Services/PIControllers.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 merged staging

Dara Navaei — Tue, 23 Jan 2024 10:21:40 -0800

Dara Navaei committed 105970a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 merged staging

· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 08 Jan 2024 14:00:12 -0800

Dara Navaei committed 4697a3f on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Jan 2024 14:00:04 -0800

Dara Navaei committed 7d4711e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Merged DEN-16595 to staging.

Sean Nash — Mon, 08 Jan 2024 13:56:54 -0800

Sean Nash committed f25deb8 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

Merged DEN-16595 to staging.

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16595: Initialized local variable in Fans.c.

Sean Nash — Mon, 08 Jan 2024 10:21:19 -0800

Sean Nash committed 2744d03 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 29 more in dgfirmware

DEN-16595: Initialized local variable in Fans.c.

· /firmware/App/Controllers/Fans.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 05 Dec 2023 12:43:25 -0800

Dara Navaei committed 9bd1afe on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 30 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 05 Dec 2023 12:43:17 -0800

Dara Navaei committed fac0c72 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 30 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Merged DENBUG-201 to staging.

Sean Nash — Tue, 05 Dec 2023 12:42:10 -0800

Sean Nash committed d934f56 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 30 more in dgfirmware

Merged DENBUG-201 to staging.

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-201: Addressed DENBUG-201 - prevent empty concentrate alarms in post-tx mode.

Sean Nash — Mon, 04 Dec 2023 12:30:45 -0800

Sean Nash committed fadef92 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 31 more in dgfirmware

DENBUG-201: Addressed DENBUG-201 - prevent empty concentrate alarms in post-tx mode.

· /firmware/App/Modes/ModeDrain.c

(-0, +6)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 changed the name of message AA that goes to memcpy

Dara Navaei — Tue, 21 Nov 2023 10:05:31 -0800

Dara Navaei committed 2a437c0 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 changed the name of message AA that goes to memcpy

· /firmware/App/Services/SystemCommMessages.c

(-2, +7)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 matched the DG even message function to HD for FW messages list script

Dara Navaei — Tue, 21 Nov 2023 09:43:38 -0800

Dara Navaei committed 26a1ca7 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 matched the DG even message function to HD for FW messages list script

· /firmware/App/Services/SystemCommMessages.c

(-17, +10)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 updated the messages typo

Dara Navaei — Mon, 20 Nov 2023 11:06:27 -0800

Dara Navaei committed 24ccd2c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 updated the messages typo

· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 updated the message 0x70 payload for messageslistscript

Dara Navaei — Mon, 20 Nov 2023 08:59:35 -0800

Dara Navaei committed 5e39149 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 updated the message 0x70 payload for messageslistscript

· /firmware/App/Services/SystemCommMessages.c

(-4, +5)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 updated the VectorCAST and fans.c

Dara Navaei — Wed, 15 Nov 2023 11:46:41 -0800

Dara Navaei committed 4cb0c49 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 updated the VectorCAST and fans.c

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 removed the DG usage record response from the standby mode

Dara Navaei — Sun, 12 Nov 2023 16:27:46 -0800

Dara Navaei committed a3aaf56 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 removed the DG usage record response from the standby mode

· /firmware/App/Modes/ModeStandby.c

(-1, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 10 Nov 2023 15:05:49 -0800

Dara Navaei committed 4efac00 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 10 Nov 2023 15:05:40 -0800

Dara Navaei committed fee3414 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged DENBUG-187

Dara Navaei — Fri, 10 Nov 2023 14:59:03 -0800

Dara Navaei committed 7aecf28 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Merged DENBUG-187

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-187 changed the code to set the chem disinfect start date at the prime state and changed the other DG modes to ch...

Dara Navaei — Fri, 10 Nov 2023 09:43:45 -0800

Dara Navaei committed c39ed7a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

DENBUG-187 changed the code to set the chem disinfect start date at the prime state and changed the other DG modes to check against the chem disinfect start date

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-17, +16)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-8, +8)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 30 Oct 2023 13:15:48 -0700

Dara Navaei committed a333e92 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 30 Oct 2023 13:15:38 -0700

Dara Navaei committed 7e66c21 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged master into staging

Dara Navaei — Mon, 30 Oct 2023 13:14:50 -0700

Dara Navaei committed 9ffd5ad on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Merged master into staging

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 30 Oct 2023 12:34:48 -0700

Dara Navaei committed 27422b2 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 30 Oct 2023 10:39:35 -0700

Dara Navaei committed faa056c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Fixed the VectorCAST test cases and .gitignore in the results folder

Dara Navaei — Mon, 30 Oct 2023 10:38:31 -0700

Dara Navaei committed fe05345 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Fixed the VectorCAST test cases and .gitignore in the results folder

· /results/.gitignore

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 27 Oct 2023 09:35:37 -0700

Dara Navaei committed 58398f3 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 27 Oct 2023 09:35:29 -0700

Dara Navaei committed 7492840 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged staging

Dara Navaei — Fri, 27 Oct 2023 09:34:45 -0700

Dara Navaei committed 85d2c24 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Merged staging

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff