Fisheye on dgfirmware/firmware/App/Modes

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function.

Thu, 15 Feb 2024 12:16:52 -0800

Darren Cox committed 3a007e0 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function.

· /firmware/App/Modes/ModeGenIdle.c	(-19, +31)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-0, +24)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 fix typo.

Tue, 13 Feb 2024 16:26:29 -0800

Darren Cox committed 4366794 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 fix typo.

· /firmware/App/Modes/ModeGenIdle.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Only check for unwanted full in treatment mode. Pretreat has transfers from one reservoir to other.

Tue, 13 Feb 2024 15:04:49 -0800

Darren Cox committed dcb42b5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 Only check for unwanted full in treatment mode. Pretreat has transfers from one reservoir to other.

· /firmware/App/Modes/ModeGenIdle.c

(-2, +5)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 09 Feb 2024 13:49:14 -0800

Dara Navaei committed d00c946 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16666 added DG events

Dara Navaei — Thu, 08 Feb 2024 13:32:33 -0800

Dara Navaei committed e7071f6 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 27 more in dgfirmware

DEN-16666 added DG events

· /firmware/App/Modes/ModeFill.c

(-2, +7)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Only call getInactiveReservoir() one time when checking for unwanted filling.

Thu, 08 Feb 2024 11:00:41 -0800

Darren Cox committed ae27d75 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 Only call getInactiveReservoir() one time when checking for unwanted filling.

· /firmware/App/Modes/ModeGenIdle.c

(-3, +4)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Added check for change of inactive reservoir.

Wed, 07 Feb 2024 14:22:56 -0800

Darren Cox committed 6952b22 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 Added check for change of inactive reservoir.

· /firmware/App/Modes/ModeGenIdle.c

(-1, +10)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 code review comment update 2.

Mon, 05 Feb 2024 15:10:54 -0800

Darren Cox committed 6f43437 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 code review comment update 2.

· /firmware/App/Modes/ModeGenIdle.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 code review comment update 1.

Mon, 05 Feb 2024 12:36:32 -0800

Darren Cox committed 7577b0a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 code review comment update 1.

· /firmware/App/Modes/ModeGenIdle.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 02 Feb 2024 14:17:21 -0800

Dara Navaei committed 6330949 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 27 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Add alarm check in Gen Idle for inactive reservoir filling up.

Wed, 31 Jan 2024 15:49:39 -0800

Darren Cox committed 9512e64 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 Add alarm check in Gen Idle for inactive reservoir filling up.

· /firmware/App/Modes/ModeGenIdle.c

(-0, +11)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 merged staging

Dara Navaei — Tue, 23 Jan 2024 10:21:40 -0800

Dara Navaei committed 105970a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 merged staging

· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Jan 2024 14:00:04 -0800

Dara Navaei committed 7d4711e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 05 Dec 2023 12:43:17 -0800

Dara Navaei committed fac0c72 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 30 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-201: Addressed DENBUG-201 - prevent empty concentrate alarms in post-tx mode.

Sean Nash — Mon, 04 Dec 2023 12:30:45 -0800

Sean Nash committed fadef92 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 31 more in dgfirmware

DENBUG-201: Addressed DENBUG-201 - prevent empty concentrate alarms in post-tx mode.

· /firmware/App/Modes/ModeDrain.c

(-0, +6)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 removed the DG usage record response from the standby mode

Dara Navaei — Sun, 12 Nov 2023 16:27:46 -0800

Dara Navaei committed a3aaf56 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 removed the DG usage record response from the standby mode

· /firmware/App/Modes/ModeStandby.c

(-1, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 10 Nov 2023 15:05:40 -0800

Dara Navaei committed fee3414 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-187 changed the code to set the chem disinfect start date at the prime state and changed the other DG modes to ch...

Dara Navaei — Fri, 10 Nov 2023 09:43:45 -0800

Dara Navaei committed c39ed7a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

DENBUG-187 changed the code to set the chem disinfect start date at the prime state and changed the other DG modes to check against the chem disinfect start date

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-17, +16)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-8, +8)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 24 Oct 2023 13:32:19 -0700

Dara Navaei committed a82bf19 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-119 removed the transition from the service mode to ro permeate sample

Dara Navaei — Tue, 24 Oct 2023 12:38:17 -0700

Dara Navaei committed c4e161c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 49 more in dgfirmware

DENBUG-119 removed the transition from the service mode to ro permeate sample

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 23 Oct 2023 16:50:34 -0700

Dara Navaei committed 2df80d5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 49 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 23 Oct 2023 16:24:44 -0700

Dara Navaei committed f1dc6eb on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 50 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-116 merged staging

Dara Navaei — Mon, 23 Oct 2023 16:21:40 -0700

Dara Navaei committed 9d1a6f6 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 51 more in dgfirmware

DENBUG-116 merged staging

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-116 changed the transition from service mode to fault mode to be illegal

Dara Navaei — Mon, 23 Oct 2023 15:27:16 -0700

Dara Navaei committed 679310f on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 51 more in dgfirmware

DENBUG-116 changed the transition from service mode to fault mode to be illegal

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-124 added code to reinitialize the drain parameters chemical disinfect, chemical disinfect flush and flush in can...

Dara Navaei — Sat, 21 Oct 2023 13:06:11 -0700

Dara Navaei committed be920d1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 50 more in dgfirmware

DENBUG-124 added code to reinitialize the drain parameters chemical disinfect, chemical disinfect flush and flush in cancel water path

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-5, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-3, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Sat, 21 Oct 2023 12:54:48 -0700

Dara Navaei committed 1214da9 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 51 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-119 changed the operation modes table to prevent a mode transition from service mode to RO permeate sample mode

Dara Navaei — Fri, 20 Oct 2023 10:54:35 -0700

Dara Navaei committed 09da19b on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 52 more in dgfirmware

DENBUG-119 changed the operation modes table to prevent a mode transition from service mode to RO permeate sample mode

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 17 Oct 2023 10:32:13 -0700

Dara Navaei committed 4950894 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446: Address DENBUG-105 to reset concentrate volume used when priming conc lines.

Sean Nash — Mon, 16 Oct 2023 10:26:58 -0700

Sean Nash committed 506f3f5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

DEN-16446: Address DENBUG-105 to reset concentrate volume used when priming conc lines.

· /firmware/App/Modes/ModeFill.c

(-0, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-76 added code to not check the temperature sensors drift until a couple of minutes into R1 to R2

Dara Navaei — Sat, 14 Oct 2023 17:17:03 -0700

Dara Navaei committed 77f5c03 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

DENBUG-76 added code to not check the temperature sensors drift until a couple of minutes into R1 to R2

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +10)

| History

| Source

| Diff