Fisheye on dgfirmware/firmware/App/Modes

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 05 Dec 2023 12:43:17 -0800

Dara Navaei committed fac0c72 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 30 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-201: Addressed DENBUG-201 - prevent empty concentrate alarms in post-tx mode.

Sean Nash — Mon, 04 Dec 2023 12:30:45 -0800

Sean Nash committed fadef92 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 31 more in dgfirmware

DENBUG-201: Addressed DENBUG-201 - prevent empty concentrate alarms in post-tx mode.

· /firmware/App/Modes/ModeDrain.c

(-0, +6)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 10 Nov 2023 15:05:40 -0800

Dara Navaei committed fee3414 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-187 changed the code to set the chem disinfect start date at the prime state and changed the other DG modes to ch...

Dara Navaei — Fri, 10 Nov 2023 09:43:45 -0800

Dara Navaei committed c39ed7a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

DENBUG-187 changed the code to set the chem disinfect start date at the prime state and changed the other DG modes to check against the chem disinfect start date

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-17, +16)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-8, +8)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 24 Oct 2023 13:32:19 -0700

Dara Navaei committed a82bf19 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-119 removed the transition from the service mode to ro permeate sample

Dara Navaei — Tue, 24 Oct 2023 12:38:17 -0700

Dara Navaei committed c4e161c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 49 more in dgfirmware

DENBUG-119 removed the transition from the service mode to ro permeate sample

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 23 Oct 2023 16:50:34 -0700

Dara Navaei committed 2df80d5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 49 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 23 Oct 2023 16:24:44 -0700

Dara Navaei committed f1dc6eb on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 50 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-116 merged staging

Dara Navaei — Mon, 23 Oct 2023 16:21:40 -0700

Dara Navaei committed 9d1a6f6 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 51 more in dgfirmware

DENBUG-116 merged staging

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-116 changed the transition from service mode to fault mode to be illegal

Dara Navaei — Mon, 23 Oct 2023 15:27:16 -0700

Dara Navaei committed 679310f on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 51 more in dgfirmware

DENBUG-116 changed the transition from service mode to fault mode to be illegal

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-124 added code to reinitialize the drain parameters chemical disinfect, chemical disinfect flush and flush in can...

Dara Navaei — Sat, 21 Oct 2023 13:06:11 -0700

Dara Navaei committed be920d1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 50 more in dgfirmware

DENBUG-124 added code to reinitialize the drain parameters chemical disinfect, chemical disinfect flush and flush in cancel water path

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-5, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-3, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Sat, 21 Oct 2023 12:54:48 -0700

Dara Navaei committed 1214da9 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 51 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-119 changed the operation modes table to prevent a mode transition from service mode to RO permeate sample mode

Dara Navaei — Fri, 20 Oct 2023 10:54:35 -0700

Dara Navaei committed 09da19b on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 52 more in dgfirmware

DENBUG-119 changed the operation modes table to prevent a mode transition from service mode to RO permeate sample mode

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 17 Oct 2023 10:32:13 -0700

Dara Navaei committed 4950894 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446: Address DENBUG-105 to reset concentrate volume used when priming conc lines.

Sean Nash — Mon, 16 Oct 2023 10:26:58 -0700

Sean Nash committed 506f3f5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

DEN-16446: Address DENBUG-105 to reset concentrate volume used when priming conc lines.

· /firmware/App/Modes/ModeFill.c

(-0, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-76 added code to not check the temperature sensors drift until a couple of minutes into R1 to R2

Dara Navaei — Sat, 14 Oct 2023 17:17:03 -0700

Dara Navaei committed 77f5c03 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

DENBUG-76 added code to not check the temperature sensors drift until a couple of minutes into R1 to R2

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +10)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 11 Oct 2023 22:32:58 -0700

Dara Navaei committed ba9d98d on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-96: Addressed DENBUG-97.

Sean Nash — Wed, 11 Oct 2023 12:36:08 -0700

Sean Nash committed e6e0513 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DENBUG-96: Addressed DENBUG-97.

· /firmware/App/Modes/ModeGenIdle.c	(-0, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-96: Addressed DENBUG-98.

Sean Nash — Wed, 11 Oct 2023 12:22:01 -0700

Sean Nash committed 6243741 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DENBUG-96: Addressed DENBUG-98.

· /firmware/App/Modes/ModeStandby.c

(-0, +7)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 09 Oct 2023 11:23:57 -0700

Dara Navaei committed d32f890 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the chemical disinfect flush for VectorCAST

Dara Navaei — Tue, 03 Oct 2023 08:52:30 -0700

Dara Navaei committed 1cff40f on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 updated the chemical disinfect flush for VectorCAST

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c

(-2, +5)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

Dara Navaei — Sat, 30 Sep 2023 13:06:29 -0700

Dara Navaei committed 1ada953 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

· /firmware/App/Controllers/ROPump.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-7, +9)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-3, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Sat, 30 Sep 2023 13:02:28 -0700

Dara Navaei committed 164e1a3 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 57 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FluidLeak.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged staging to DEN-15791.

Sean Nash — Sat, 30 Sep 2023 11:41:29 -0700

Sean Nash committed d371983 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware

Merged staging to DEN-15791.

· /firmware/App/Controllers/ROPump.c	(-3, +15)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-6, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-67, +84)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-10, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +16)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +118)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +14)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code and VectorCAST test cases

Dara Navaei — Thu, 28 Sep 2023 11:18:52 -0700

Dara Navaei committed fa508da on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 updated the code and VectorCAST test cases

· /firmware/App/Controllers/Pressures.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 addressed the code review comment

Dara Navaei — Thu, 28 Sep 2023 08:56:02 -0700

Dara Navaei committed 1d97505 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 addressed the code review comment

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +4)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code for VectorCAST

Dara Navaei — Wed, 27 Sep 2023 15:32:59 -0700

Dara Navaei committed 2f7745c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 updated the code for VectorCAST

· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code and VectorCAST test cases

Dara Navaei — Wed, 27 Sep 2023 08:57:19 -0700

Dara Navaei committed 1854144 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 updated the code and VectorCAST test cases

· /firmware/App/Modes/ModeFill.c

(-1, +5)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code based on the VectorCAST tests

Dara Navaei — Mon, 25 Sep 2023 14:55:38 -0700

Dara Navaei committed 98543f7 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 updated the code based on the VectorCAST tests

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-7, +7)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code and the VectorCAST test cases

Dara Navaei — Sun, 24 Sep 2023 13:36:30 -0700

Dara Navaei committed b0c448e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 updated the code and the VectorCAST test cases

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +2)

| History

| Source

| Diff