Fisheye on dgfirmware/firmware/App/Services https://devapps.diality.us/changelog/~br%3DDEN-16595-vectorcast-unit-and-integration-testing/dgfirmware/firmware/App/Services Recent activity in "dgfirmware" under directory /firmware/App/Services dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 23 Oct 2023 16:24:44 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=f1dc6eb108b54d0187f26a44d2e5784a1a4f46df https://devapps.diality.us/changelog/dgfirmware?cs=f1dc6eb108b54d0187f26a44d2e5784a1a4f46df Dara Navaei committed f1dc6eb on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 50 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-116 changed the code to only allow write to service, calibration, and system records when DG is in service mode Fri, 20 Oct 2023 13:39:17 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=9fea55e5fa58ce75b251b84e08c9b11210cbc288 https://devapps.diality.us/changelog/dgfirmware?cs=9fea55e5fa58ce75b251b84e08c9b11210cbc288 Dara Navaei committed 9fea55e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 51 more in dgfirmware DENBUG-116 changed the code to only allow write to service, calibration, and system records when DG is in service mode

· /firmware/App/Services/SystemCommMessages.c (-3, +6) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 11 Oct 2023 22:32:58 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=ba9d98d32561f9e9fb62068c3e08e1993d39462a https://devapps.diality.us/changelog/dgfirmware?cs=ba9d98d32561f9e9fb62068c3e08e1993d39462a Dara Navaei committed ba9d98d on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeGenIdle.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-96: Addressed DENBUG-97. Wed, 11 Oct 2023 12:36:08 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=e6e05130918b0aa7cd742d88e3b2cd850316cde7 https://devapps.diality.us/changelog/dgfirmware?cs=e6e05130918b0aa7cd742d88e3b2cd850316cde7 Sean Nash committed e6e0513 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DENBUG-96: Addressed DENBUG-97.

· /firmware/App/Modes/ModeGenIdle.c (-0, +8) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-3, +3) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 10 Oct 2023 15:59:22 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=3024adb7a36bc2741f7644ec72e809582bc50ff1 https://devapps.diality.us/changelog/dgfirmware?cs=3024adb7a36bc2741f7644ec72e809582bc50ff1 Dara Navaei committed 3024adb on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16487 added code to set the dialin expiration time stamp once the user has logged in until the first checkin from di... Tue, 10 Oct 2023 09:09:23 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=46dc6530881c0d2a8dc46a6fceb2be43f5d7ca27 https://devapps.diality.us/changelog/dgfirmware?cs=46dc6530881c0d2a8dc46a6fceb2be43f5d7ca27 Dara Navaei committed 46dc653 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DEN-16487 added code to set the dialin expiration time stamp once the user has logged in until the first checkin from dialin is received

· /firmware/App/Services/SystemCommMessages.c (-0, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 09 Oct 2023 11:23:57 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=d32f890bb6c238c95bcaca54da79d7aa4a1898cb https://devapps.diality.us/changelog/dgfirmware?cs=d32f890bb6c238c95bcaca54da79d7aa4a1898cb Dara Navaei committed d32f890 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/Interrupts.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 addressed the code review comments Mon, 09 Oct 2023 09:21:11 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=4c992d223269b589edf3e60f01bfaeaf2307488a https://devapps.diality.us/changelog/dgfirmware?cs=4c992d223269b589edf3e60f01bfaeaf2307488a Dara Navaei committed 4c992d2 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DEN-16446 addressed the code review comments

· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code for VectorCAST Sun, 08 Oct 2023 10:49:17 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=fd87688d38be3ed2453ad210728ad95b5dcfd118 https://devapps.diality.us/changelog/dgfirmware?cs=fd87688d38be3ed2453ad210728ad95b5dcfd118 Dara Navaei committed fd87688 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DEN-16446 updated the code for VectorCAST

· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 06 Oct 2023 12:10:02 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=3390017d18249d64a45f4d7b89dffb4ef1ae93e6 https://devapps.diality.us/changelog/dgfirmware?cs=3390017d18249d64a45f4d7b89dffb4ef1ae93e6 Dara Navaei committed 3390017 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 55 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/WatchdogMgmt.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16372: Turn off trimmer heater if HD communication is lost. Thu, 05 Oct 2023 08:26:12 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=5c8d32c848b9dbbdbb992a981efd97393444144d https://devapps.diality.us/changelog/dgfirmware?cs=5c8d32c848b9dbbdbb992a981efd97393444144d Sean Nash committed 5c8d32c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware DEN-16372: Turn off trimmer heater if HD communication is lost.

· /firmware/App/Services/SystemComm.c (-4, +6) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16372: fixed typo - wrong alarm triggered for watchdog expired. Wed, 04 Oct 2023 08:54:36 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=67cbaca208940f58d1f347d1296eeff325dd15db https://devapps.diality.us/changelog/dgfirmware?cs=67cbaca208940f58d1f347d1296eeff325dd15db Sean Nash committed 67cbaca on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware DEN-16372: fixed typo - wrong alarm triggered for watchdog expired.

· /firmware/App/Services/WatchdogMgmt.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16372: Matched watchdog expired alarm to requirement. Tue, 03 Oct 2023 15:00:51 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=5f1eb7d49fc2965ea93ca8028ed1b749a5f44e6d https://devapps.diality.us/changelog/dgfirmware?cs=5f1eb7d49fc2965ea93ca8028ed1b749a5f44e6d Sean Nash committed 5f1eb7d on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware DEN-16372: Matched watchdog expired alarm to requirement.

· /firmware/App/Services/WatchdogMgmt.c (-11, +21) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Sat, 30 Sep 2023 13:02:28 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=164e1a3ffca18c703676bc7f57f5903c76050600 https://devapps.diality.us/changelog/dgfirmware?cs=164e1a3ffca18c703676bc7f57f5903c76050600 Dara Navaei committed 164e1a3 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 57 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged staging to DEN-15791. Sat, 30 Sep 2023 11:41:29 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=d371983d84daf213db3e39d21cf30c13161ce062 https://devapps.diality.us/changelog/dgfirmware?cs=d371983d84daf213db3e39d21cf30c13161ce062 Sean Nash committed d371983 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware Merged staging to DEN-15791.

· /firmware/App/Controllers/ROPump.c (-3, +15) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-6, +8) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-67, +84) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-10, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +16) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +118) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +14) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code and the VectorCAST projects Tue, 26 Sep 2023 11:28:47 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=bf6ba3f180d1f8d1e89060e8c281297d206df582 https://devapps.diality.us/changelog/dgfirmware?cs=bf6ba3f180d1f8d1e89060e8c281297d206df582 Dara Navaei committed bf6ba3f on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DEN-16446 updated the code and the VectorCAST projects

· /firmware/App/Services/FPGA.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15791: Doxygen comment fixes. Sun, 24 Sep 2023 11:02:14 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=b67373adbc581690febb1e1c2bb521f108d9b92e https://devapps.diality.us/changelog/dgfirmware?cs=b67373adbc581690febb1e1c2bb521f108d9b92e Sean Nash committed b67373a on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware DEN-15791: Doxygen comment fixes.

· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-5, +7) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-5, +5) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-6, +0) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code and VectorCAST tests Sat, 23 Sep 2023 16:48:53 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=d06df4604f433cfd5f03146f4b22bba2d5854756 https://devapps.diality.us/changelog/dgfirmware?cs=d06df4604f433cfd5f03146f4b22bba2d5854756 Dara Navaei committed d06df46 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DEN-16446 updated the code and VectorCAST tests

· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/Interrupts.c (-1, +4) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15791: Doxygen comment fixes. Fri, 22 Sep 2023 15:32:16 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=d2ec7bf847131ad0f044fc122aef360d726a2dc5 https://devapps.diality.us/changelog/dgfirmware?cs=d2ec7bf847131ad0f044fc122aef360d726a2dc5 Sean Nash committed d2ec7bf on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware DEN-15791: Doxygen comment fixes.

· /firmware/App/Controllers/ConductivitySensors.h (-3, +0) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-3, +0) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-8, +9) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-4, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 15 Sep 2023 16:38:36 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=8ee01698b926fa62e7bed563b1137144a3cb32c5 https://devapps.diality.us/changelog/dgfirmware?cs=8ee01698b926fa62e7bed563b1137144a3cb32c5 Dara Navaei committed 8ee0169 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 14 Sep 2023 09:29:29 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=5459a8a8b011c5956feb83c14fa98091287be7ac https://devapps.diality.us/changelog/dgfirmware?cs=5459a8a8b011c5956feb83c14fa98091287be7ac Dara Navaei committed 5459a8a on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-283: message handling for moving average override. Mon, 11 Sep 2023 13:59:11 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dgfirmware?cs=3fc87449b1c5b892a7f86430b7b8c49190ae56a8 https://devapps.diality.us/changelog/dgfirmware?cs=3fc87449b1c5b892a7f86430b7b8c49190ae56a8 Michael Garthwaite committed 3fc8744 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DIAL-283: message handling for moving average override.

· /firmware/App/Modes/ModeChemicalDisinfect.c (-10, +7) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h (-0, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +31) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +3) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low... Fri, 08 Sep 2023 17:23:49 -0700 James Walter Taylor <jtaylor@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=482a7419b20845a9544d2c79b96b27300a3f00d6 https://devapps.diality.us/changelog/dgfirmware?cs=482a7419b20845a9544d2c79b96b27300a3f00d6 James Walter Taylor <jtaylor@diality.com> committed 482a741 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Reintroduced reservoir data structure change.

Corrected the setModeFillStateTransition semantics.

· /firmware/App/Modes/ModeFill.c (-2, +3) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-3, +0) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low... Fri, 08 Sep 2023 14:57:57 -0700 James Walter Taylor <jtaylor@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=abffc090d778e4632df90d902a0326d05611da31 https://devapps.diality.us/changelog/dgfirmware?cs=abffc090d778e4632df90d902a0326d05611da31 James Walter Taylor <jtaylor@diality.com> committed abffc09 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Structure out of sync between HD/DG. Corrected.

· /firmware/App/Services/Reservoirs.h (-0, +3) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low... Thu, 07 Sep 2023 15:27:30 -0700 James Walter Taylor <jtaylor@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=ade9db1aa022146c405a2aeca846cd9bd15b05ce https://devapps.diality.us/changelog/dgfirmware?cs=ade9db1aa022146c405a2aeca846cd9bd15b05ce James Walter Taylor <jtaylor@diality.com> committed ade9db1 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

fill time allowance for time spent in pause state

Cleared fill timer on transition to generate

Added removed unused (and uninitialized) variables from broadcast data structure.

· /firmware/App/Modes/ModeFill.c (-2, +38) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-3, +0) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 06 Sep 2023 07:40:03 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=f910ec24ca3b5b5756aafa88d9121317433ec1f3 https://devapps.diality.us/changelog/dgfirmware?cs=f910ec24ca3b5b5756aafa88d9121317433ec1f3 Dara Navaei committed f910ec2 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 65 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-14706: fixed compiler errors Tue, 05 Sep 2023 08:11:21 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dgfirmware?cs=0ae5f0f0bff2b3ddfe4727c7b286d280a42dead6 https://devapps.diality.us/changelog/dgfirmware?cs=0ae5f0f0bff2b3ddfe4727c7b286d280a42dead6 Michael Garthwaite committed 0ae5f0f on branch DEN-14706-can-messge-not-acked-fix, DEN-15791-dg-software-design-description and 66 more in dgfirmware DEN-14706: fixed compiler errors

· /firmware/App/Services/SystemComm.c (-3, +3) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low... Fri, 01 Sep 2023 16:38:08 -0700 James Walter Taylor <jtaylor@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=631df8130cb75938e0f496f0518ad52134bc5656 https://devapps.diality.us/changelog/dgfirmware?cs=631df8130cb75938e0f496f0518ad52134bc5656 James Walter Taylor <jtaylor@diality.com> committed 631df81 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Initial changes for alarm 206 timer

· /firmware/App/Modes/ModeFill.c (-21, +23) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-14706: code review comments. Fri, 01 Sep 2023 10:01:45 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dgfirmware?cs=e23b440e0a076a9e76edd057a98d1b16270129bc https://devapps.diality.us/changelog/dgfirmware?cs=e23b440e0a076a9e76edd057a98d1b16270129bc Michael Garthwaite committed e23b440 on branch DEN-14706-can-messge-not-acked-fix, DEN-15791-dg-software-design-description and 66 more in dgfirmware DEN-14706: code review comments.

· /firmware/App/Services/SystemComm.c (-7, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-14706: wip of code review comments. Thu, 31 Aug 2023 14:12:34 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dgfirmware?cs=ceccf84de0d3518691abcf0ed94389777c6fd055 https://devapps.diality.us/changelog/dgfirmware?cs=ceccf84de0d3518691abcf0ed94389777c6fd055 Michael Garthwaite committed ceccf84 on branch DEN-14706-can-messge-not-acked-fix, DEN-15791-dg-software-design-description and 66 more in dgfirmware DEN-14706: wip of code review comments.

· /firmware/App/Services/SystemComm.c (-9, +9) | History | Source | Diff
]]>