Fisheye on dgfirmware/firmware/App/Modes

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 updated the comments

Dara Navaei — Wed, 06 Mar 2024 14:47:44 -0800

Dara Navaei committed 8d0fc6d on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

DEN-16682 updated the comments

· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-28, +30)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 changed the fill mode to get the target conductivity values from the bicarb values of the fill conductivities ...

Dara Navaei — Wed, 06 Mar 2024 13:32:02 -0800

Dara Navaei committed 9d47686 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

DEN-16682 changed the fill mode to get the target conductivity values from the bicarb values of the fill conductivities in the non-volaitle memory. Updated the VectorCAST test cases

· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 removed CD1 check in the fill mode

Dara Navaei — Tue, 05 Mar 2024 15:41:18 -0800

Dara Navaei committed 7cd8a55 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

DEN-16682 removed CD1 check in the fill mode

· /firmware/App/Modes/ModeFill.c

(-16, +3)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 upaded the drivers to get the calibration values once the signal is emitted. DENBUG-199 updated the drain pump...

Dara Navaei — Tue, 05 Mar 2024 08:14:46 -0800

Dara Navaei committed 7c5eba5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

DEN-16682 upaded the drivers to get the calibration values once the signal is emitted. DENBUG-199 updated the drain pump driver

· /firmware/App/Controllers/ConductivitySensors.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-0, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 added the alarm for the fill acid/bicarb target conductivities in the DG calibration record

Dara Navaei — Sat, 02 Mar 2024 15:58:22 -0800

Dara Navaei committed 581064e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

DEN-16682 added the alarm for the fill acid/bicarb target conductivities in the DG calibration record

· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 changed the acid pumps speed in mode fill

Dara Navaei — Fri, 01 Mar 2024 16:52:32 -0800

Dara Navaei committed 166097c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

DEN-16682 changed the acid pumps speed in mode fill

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 29 Feb 2024 15:04:39 -0800

Dara Navaei committed e3839e1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 addressed the code reivew comment

Dara Navaei — Thu, 29 Feb 2024 13:04:22 -0800

Dara Navaei committed 9663d70 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16674 addressed the code reivew comment

· /firmware/App/Modes/ModeFill.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 addressed the code review comments

Dara Navaei — Thu, 29 Feb 2024 10:59:06 -0800

Dara Navaei committed 63c6107 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16674 addressed the code review comments

· /firmware/App/Modes/ModeFill.c

(-30, +33)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 updated the code for mode fill calibration check command

Dara Navaei — Thu, 29 Feb 2024 08:36:29 -0800

Dara Navaei committed 8e62ede on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16674 updated the code for mode fill calibration check command

· /firmware/App/Modes/ModeFill.c	(-0, +80)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +33)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 changed the speed of the acid concentrate pump. CD2 will be used for acid check in the Mode Fill

Dara Navaei — Fri, 23 Feb 2024 09:33:58 -0800

Dara Navaei committed b41ffef on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16682 changed the speed of the acid concentrate pump. CD2 will be used for acid check in the Mode Fill

· /firmware/App/Modes/ModeFill.c

(-6, +7)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16681 addressed the code review comment

Dara Navaei — Thu, 22 Feb 2024 10:57:31 -0800

Dara Navaei committed 3acd796 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16681 addressed the code review comment

· /firmware/App/Modes/ModeFill.c

(-4, +4)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16681 changed the tolerances of acid and bicarb check in Mdoe Fill

Dara Navaei — Thu, 22 Feb 2024 09:17:18 -0800

Dara Navaei committed 8432595 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

DEN-16681 changed the tolerances of acid and bicarb check in Mdoe Fill

· /firmware/App/Modes/ModeFill.c

(-2, +4)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 15 Feb 2024 15:46:48 -0800

Dara Navaei committed 84989e1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function.

Thu, 15 Feb 2024 12:16:52 -0800

Darren Cox committed 3a007e0 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function.

· /firmware/App/Modes/ModeGenIdle.c	(-19, +31)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-0, +24)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 fix typo.

Tue, 13 Feb 2024 16:26:29 -0800

Darren Cox committed 4366794 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 fix typo.

· /firmware/App/Modes/ModeGenIdle.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Only check for unwanted full in treatment mode. Pretreat has transfers from one reservoir to other.

Tue, 13 Feb 2024 15:04:49 -0800

Darren Cox committed dcb42b5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 Only check for unwanted full in treatment mode. Pretreat has transfers from one reservoir to other.

· /firmware/App/Modes/ModeGenIdle.c

(-2, +5)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 09 Feb 2024 13:49:14 -0800

Dara Navaei committed d00c946 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16666 added DG events

Dara Navaei — Thu, 08 Feb 2024 13:32:33 -0800

Dara Navaei committed e7071f6 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 27 more in dgfirmware

DEN-16666 added DG events

· /firmware/App/Modes/ModeFill.c

(-2, +7)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Only call getInactiveReservoir() one time when checking for unwanted filling.

Thu, 08 Feb 2024 11:00:41 -0800

Darren Cox committed ae27d75 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 Only call getInactiveReservoir() one time when checking for unwanted filling.

· /firmware/App/Modes/ModeGenIdle.c

(-3, +4)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Added check for change of inactive reservoir.

Wed, 07 Feb 2024 14:22:56 -0800

Darren Cox committed 6952b22 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 Added check for change of inactive reservoir.

· /firmware/App/Modes/ModeGenIdle.c

(-1, +10)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 code review comment update 2.

Mon, 05 Feb 2024 15:10:54 -0800

Darren Cox committed 6f43437 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 code review comment update 2.

· /firmware/App/Modes/ModeGenIdle.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 code review comment update 1.

Mon, 05 Feb 2024 12:36:32 -0800

Darren Cox committed 7577b0a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 code review comment update 1.

· /firmware/App/Modes/ModeGenIdle.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 02 Feb 2024 14:17:21 -0800

Dara Navaei committed 6330949 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 27 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Add alarm check in Gen Idle for inactive reservoir filling up.

Wed, 31 Jan 2024 15:49:39 -0800

Darren Cox committed 9512e64 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware

DEN-16587 Add alarm check in Gen Idle for inactive reservoir filling up.

· /firmware/App/Modes/ModeGenIdle.c

(-0, +11)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 merged staging

Dara Navaei — Tue, 23 Jan 2024 10:21:40 -0800

Dara Navaei committed 105970a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 merged staging

· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Jan 2024 14:00:04 -0800

Dara Navaei committed 7d4711e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 05 Dec 2023 12:43:17 -0800

Dara Navaei committed fac0c72 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 30 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-201: Addressed DENBUG-201 - prevent empty concentrate alarms in post-tx mode.

Sean Nash — Mon, 04 Dec 2023 12:30:45 -0800

Sean Nash committed fadef92 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 31 more in dgfirmware

DENBUG-201: Addressed DENBUG-201 - prevent empty concentrate alarms in post-tx mode.

· /firmware/App/Modes/ModeDrain.c

(-0, +6)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 removed the DG usage record response from the standby mode

Dara Navaei — Sun, 12 Nov 2023 16:27:46 -0800

Dara Navaei committed a3aaf56 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

DEN-16499 removed the DG usage record response from the standby mode

· /firmware/App/Modes/ModeStandby.c

(-1, +3)

| History

| Source

| Diff