Fisheye on dgfirmware/firmware/App/Services https://devapps.diality.us/changelog/~br%3DDEN-16682-use-cd2-values-for-acid-check/dgfirmware/firmware/App/Services Recent activity in "dgfirmware" under directory /firmware/App/Services dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 added the alarm for the fill acid/bicarb target conductivities in the DG calibration record Sat, 02 Mar 2024 15:58:22 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=581064e4188c15307a70bc4265974d61dea23ff8 https://devapps.diality.us/changelog/dgfirmware?cs=581064e4188c15307a70bc4265974d61dea23ff8 Dara Navaei committed 581064e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware DEN-16682 added the alarm for the fill acid/bicarb target conductivities in the DG calibration record

· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +4) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 29 Feb 2024 15:04:39 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=e3839e10decfadf12a8fb2b9f8c049d8a30e945b https://devapps.diality.us/changelog/dgfirmware?cs=e3839e10decfadf12a8fb2b9f8c049d8a30e945b Dara Navaei committed e3839e1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 addressed the code reivew comment Thu, 29 Feb 2024 13:04:22 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=9663d70ce482c819bb67cf0724a6a88009df49cc https://devapps.diality.us/changelog/dgfirmware?cs=9663d70ce482c819bb67cf0724a6a88009df49cc Dara Navaei committed 9663d70 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware DEN-16674 addressed the code reivew comment

· /firmware/App/Modes/ModeFill.c (-0, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-5, +0) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16674 updated the code for mode fill calibration check command Thu, 29 Feb 2024 08:36:29 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=8e62ede02d0f1d4bfc8aebbfa75a5ce308c994bd https://devapps.diality.us/changelog/dgfirmware?cs=8e62ede02d0f1d4bfc8aebbfa75a5ce308c994bd Dara Navaei committed 8e62ede on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware DEN-16674 updated the code for mode fill calibration check command

· /firmware/App/Modes/ModeFill.c (-0, +80) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-0, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +33) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +3) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 15 Feb 2024 15:46:48 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=84989e158824d6cc8d8747ca80c6419315cc951c https://devapps.diality.us/changelog/dgfirmware?cs=84989e158824d6cc8d8747ca80c6419315cc951c Dara Navaei committed 84989e1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function. Thu, 15 Feb 2024 12:16:52 -0800 Darren Cox <darren_m@cox.net> https://devapps.diality.us/changelog/dgfirmware?cs=3a007e014c41538a1256ce5f42093763db82e84d https://devapps.diality.us/changelog/dgfirmware?cs=3a007e014c41538a1256ce5f42093763db82e84d Darren Cox <darren_m@cox.net> committed 3a007e0 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function.

· /firmware/App/Modes/ModeGenIdle.c (-19, +31) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-0, +24) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-0, +1) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 02 Feb 2024 14:17:21 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=6330949b9dd72e81c3a8405617f27df98acfc3e6 https://devapps.diality.us/changelog/dgfirmware?cs=6330949b9dd72e81c3a8405617f27df98acfc3e6 Dara Navaei committed 6330949 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 27 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 addressed the code review comments Tue, 30 Jan 2024 09:12:27 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=d2df61eaf8d65a95eb20ff96137d1b60fca55d99 https://devapps.diality.us/changelog/dgfirmware?cs=d2df61eaf8d65a95eb20ff96137d1b60fca55d99 Dara Navaei committed d2df61e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware DEN-16499 addressed the code review comments

· /firmware/App/Services/SystemCommMessages.c (-5, +5) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 removed the name from the typedef structs for doxygen Tue, 23 Jan 2024 10:44:33 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=f26f80511ab882d5b5dd28b2b8201ca8abde96d3 https://devapps.diality.us/changelog/dgfirmware?cs=f26f80511ab882d5b5dd28b2b8201ca8abde96d3 Dara Navaei committed f26f805 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware DEN-16499 removed the name from the typedef structs for doxygen

· /firmware/App/Services/PIControllers.h (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 merged staging Tue, 23 Jan 2024 10:21:40 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=105970aa96eba9c852413f832f6a25be1d21f5fd https://devapps.diality.us/changelog/dgfirmware?cs=105970aa96eba9c852413f832f6a25be1d21f5fd Dara Navaei committed 105970a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware DEN-16499 merged staging

· /firmware/App/Modes/ModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 08 Jan 2024 14:00:04 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=7d4711edd7b40cd3e29f43e766f79a8a09586fe9 https://devapps.diality.us/changelog/dgfirmware?cs=7d4711edd7b40cd3e29f43e766f79a8a09586fe9 Dara Navaei committed 7d4711e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
… 86 more files in changeset.
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 changed the name of message AA that goes to memcpy Tue, 21 Nov 2023 10:05:31 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=2a437c0b6461a17c6474d7d3c7964463abc4651b https://devapps.diality.us/changelog/dgfirmware?cs=2a437c0b6461a17c6474d7d3c7964463abc4651b Dara Navaei committed 2a437c0 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware DEN-16499 changed the name of message AA that goes to memcpy

· /firmware/App/Services/SystemCommMessages.c (-2, +7) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 matched the DG even message function to HD for FW messages list script Tue, 21 Nov 2023 09:43:38 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=26a1ca768a98655b83457493b4e2eeed104efeb5 https://devapps.diality.us/changelog/dgfirmware?cs=26a1ca768a98655b83457493b4e2eeed104efeb5 Dara Navaei committed 26a1ca7 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware DEN-16499 matched the DG even message function to HD for FW messages list script

· /firmware/App/Services/SystemCommMessages.c (-17, +10) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 updated the messages typo Mon, 20 Nov 2023 11:06:27 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=24ccd2ca1586d0dd699d3cb0081ff18d5df4c5df https://devapps.diality.us/changelog/dgfirmware?cs=24ccd2ca1586d0dd699d3cb0081ff18d5df4c5df Dara Navaei committed 24ccd2c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware DEN-16499 updated the messages typo

· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16499 updated the message 0x70 payload for messageslistscript Mon, 20 Nov 2023 08:59:35 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=5e391490ea45379eca7c6c30faa0c210a176a7e3 https://devapps.diality.us/changelog/dgfirmware?cs=5e391490ea45379eca7c6c30faa0c210a176a7e3 Dara Navaei committed 5e39149 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware DEN-16499 updated the message 0x70 payload for messageslistscript

· /firmware/App/Services/SystemCommMessages.c (-4, +5) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 23 Oct 2023 16:24:44 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=f1dc6eb108b54d0187f26a44d2e5784a1a4f46df https://devapps.diality.us/changelog/dgfirmware?cs=f1dc6eb108b54d0187f26a44d2e5784a1a4f46df Dara Navaei committed f1dc6eb on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 50 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-116 changed the code to only allow write to service, calibration, and system records when DG is in service mode Fri, 20 Oct 2023 13:39:17 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=9fea55e5fa58ce75b251b84e08c9b11210cbc288 https://devapps.diality.us/changelog/dgfirmware?cs=9fea55e5fa58ce75b251b84e08c9b11210cbc288 Dara Navaei committed 9fea55e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 51 more in dgfirmware DENBUG-116 changed the code to only allow write to service, calibration, and system records when DG is in service mode

· /firmware/App/Services/SystemCommMessages.c (-3, +6) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 11 Oct 2023 22:32:58 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=ba9d98d32561f9e9fb62068c3e08e1993d39462a https://devapps.diality.us/changelog/dgfirmware?cs=ba9d98d32561f9e9fb62068c3e08e1993d39462a Dara Navaei committed ba9d98d on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeGenIdle.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-96: Addressed DENBUG-97. Wed, 11 Oct 2023 12:36:08 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=e6e05130918b0aa7cd742d88e3b2cd850316cde7 https://devapps.diality.us/changelog/dgfirmware?cs=e6e05130918b0aa7cd742d88e3b2cd850316cde7 Sean Nash committed e6e0513 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DENBUG-96: Addressed DENBUG-97.

· /firmware/App/Modes/ModeGenIdle.c (-0, +8) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-3, +3) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 10 Oct 2023 15:59:22 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=3024adb7a36bc2741f7644ec72e809582bc50ff1 https://devapps.diality.us/changelog/dgfirmware?cs=3024adb7a36bc2741f7644ec72e809582bc50ff1 Dara Navaei committed 3024adb on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16487 added code to set the dialin expiration time stamp once the user has logged in until the first checkin from di... Tue, 10 Oct 2023 09:09:23 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=46dc6530881c0d2a8dc46a6fceb2be43f5d7ca27 https://devapps.diality.us/changelog/dgfirmware?cs=46dc6530881c0d2a8dc46a6fceb2be43f5d7ca27 Dara Navaei committed 46dc653 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DEN-16487 added code to set the dialin expiration time stamp once the user has logged in until the first checkin from dialin is received

· /firmware/App/Services/SystemCommMessages.c (-0, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 09 Oct 2023 11:23:57 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=d32f890bb6c238c95bcaca54da79d7aa4a1898cb https://devapps.diality.us/changelog/dgfirmware?cs=d32f890bb6c238c95bcaca54da79d7aa4a1898cb Dara Navaei committed d32f890 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/Interrupts.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 addressed the code review comments Mon, 09 Oct 2023 09:21:11 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=4c992d223269b589edf3e60f01bfaeaf2307488a https://devapps.diality.us/changelog/dgfirmware?cs=4c992d223269b589edf3e60f01bfaeaf2307488a Dara Navaei committed 4c992d2 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DEN-16446 addressed the code review comments

· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code for VectorCAST Sun, 08 Oct 2023 10:49:17 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=fd87688d38be3ed2453ad210728ad95b5dcfd118 https://devapps.diality.us/changelog/dgfirmware?cs=fd87688d38be3ed2453ad210728ad95b5dcfd118 Dara Navaei committed fd87688 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DEN-16446 updated the code for VectorCAST

· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 06 Oct 2023 12:10:02 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=3390017d18249d64a45f4d7b89dffb4ef1ae93e6 https://devapps.diality.us/changelog/dgfirmware?cs=3390017d18249d64a45f4d7b89dffb4ef1ae93e6 Dara Navaei committed 3390017 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 55 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/WatchdogMgmt.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16372: Turn off trimmer heater if HD communication is lost. Thu, 05 Oct 2023 08:26:12 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=5c8d32c848b9dbbdbb992a981efd97393444144d https://devapps.diality.us/changelog/dgfirmware?cs=5c8d32c848b9dbbdbb992a981efd97393444144d Sean Nash committed 5c8d32c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware DEN-16372: Turn off trimmer heater if HD communication is lost.

· /firmware/App/Services/SystemComm.c (-4, +6) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16372: fixed typo - wrong alarm triggered for watchdog expired. Wed, 04 Oct 2023 08:54:36 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=67cbaca208940f58d1f347d1296eeff325dd15db https://devapps.diality.us/changelog/dgfirmware?cs=67cbaca208940f58d1f347d1296eeff325dd15db Sean Nash committed 67cbaca on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware DEN-16372: fixed typo - wrong alarm triggered for watchdog expired.

· /firmware/App/Services/WatchdogMgmt.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16372: Matched watchdog expired alarm to requirement. Tue, 03 Oct 2023 15:00:51 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=5f1eb7d49fc2965ea93ca8028ed1b749a5f44e6d https://devapps.diality.us/changelog/dgfirmware?cs=5f1eb7d49fc2965ea93ca8028ed1b749a5f44e6d Sean Nash committed 5f1eb7d on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware DEN-16372: Matched watchdog expired alarm to requirement.

· /firmware/App/Services/WatchdogMgmt.c (-11, +21) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Sat, 30 Sep 2023 13:02:28 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=164e1a3ffca18c703676bc7f57f5903c76050600 https://devapps.diality.us/changelog/dgfirmware?cs=164e1a3ffca18c703676bc7f57f5903c76050600 Dara Navaei committed 164e1a3 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 57 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged staging to DEN-15791. Sat, 30 Sep 2023 11:41:29 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=d371983d84daf213db3e39d21cf30c13161ce062 https://devapps.diality.us/changelog/dgfirmware?cs=d371983d84daf213db3e39d21cf30c13161ce062 Sean Nash committed d371983 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware Merged staging to DEN-15791.

· /firmware/App/Controllers/ROPump.c (-3, +15) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-6, +8) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-67, +84) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-10, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +16) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +118) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +14) | History | Source | Diff
]]>