Fisheye on hdfirmware/firmware/App/Controllers/AirPump.h

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 02 Jan 2024 10:53:49 -0800

Dara Navaei committed 736cc5b on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 56 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-3, +3)

| History

| Source

| Diff

… 102 more files in changeset.

HD-DEN-14344-3: closed by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 20:49:50 -0700

Dara Navaei Closed HD-DEN-14344-3

HD-DEN-14344-3: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 20:49:40 -0700

Dara Navaei replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14344-3: reviewers resumed

Wed, 18 Oct 2023 20:48:20 -0700

Dara Navaei resumed reviewing HD-DEN-14344-3

HD-DEN-14344_SW S85 MG Air Pump

HD-DEN-14344-3: started by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 20:47:55 -0700

Dara Navaei started review HD-DEN-14344-3

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 03 Jan 2023 16:28:56 -0800

Dara Navaei committed da7e8c1 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 293 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/AirPump.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/AirTrap.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-1, +1)	\| History	\| Source	\| Diff

HD-DEN-14344-3: reviewers finished

Tue, 03 Jan 2023 16:18:53 -0800

wbracken (deleted user) and Sean Nash finished reviewing HD-DEN-14344-3

HD-DEN-14344_SW S85 MG Air Pump

HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 29 Dec 2022 11:23:15 -0800

Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 29 Dec 2022 11:22:51 -0800

Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3: comment by Michael Garthwaite "Fixed. Thanks!"

Michael Garthwaite — Thu, 29 Dec 2022 11:10:27 -0800

Michael Garthwaite replied to Sean Nash in HD-DEN-14344-3

Fixed. Thanks!

HD-DEN-14344-3: comment by Michael Garthwaite "Fixed. Thanks!"

Michael Garthwaite — Thu, 29 Dec 2022 11:10:20 -0800

Michael Garthwaite replied to Sean Nash in HD-DEN-14344-3

Fixed. Thanks!

HD-DEN-14344-3: reviewers resumed

Thu, 29 Dec 2022 11:09:02 -0800

jtaylor (deleted user) resumed reviewing HD-DEN-14344-3

HD-DEN-14344_SW S85 MG Air Pump

HD-DEN-14344-3: comment by Sean Nash "For a release build, looks like we would do not..."

Sean Nash — Thu, 29 Dec 2022 09:47:53 -0800

Sean Nash commented on HD-DEN-14344-3

For a release build, looks like we would do nothing and get stuck in this state.

HD-DEN-14344-3: comment by Sean Nash "Add doxygen comment for persistence. Try to ca..."

Sean Nash — Thu, 29 Dec 2022 09:44:46 -0800

Sean Nash commented on HD-DEN-14344-3

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

HD-DEN-14344-3: comment by Michael Garthwaite "Fixed. Thanks!"

Michael Garthwaite — Thu, 22 Dec 2022 13:35:37 -0800

Michael Garthwaite replied to Dara Navaei in HD-DEN-14344-3

Fixed. Thanks!

HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 22 Dec 2022 13:33:32 -0800

Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3: comment by Michael Garthwaite "The only time we would be adding more states is..."

Michael Garthwaite — Thu, 22 Dec 2022 13:28:29 -0800

Michael Garthwaite replied to Sean Nash in HD-DEN-14344-3

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

HD-DEN-14344-3: comment by Sean Nash "Would rather you set a BOOL based on state and ..."

Sean Nash — Thu, 22 Dec 2022 13:26:22 -0800

Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 22 Dec 2022 13:25:08 -0800

Sean Nash replied to Sean Nash in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 22 Dec 2022 13:24:53 -0800

Sean Nash replied to Sean Nash in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14344: code review fixes.

Michael Garthwaite — Thu, 22 Dec 2022 13:21:14 -0800

Michael Garthwaite committed 3451ff7 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 294 more in hdfirmware

DEN-14344: code review fixes.

· /firmware/App/Controllers/AirPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/AirPump.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/AirTrap.c	(-1, +1)	\| History	\| Source	\| Diff

HD-DEN-14344-3: comment by Michael Garthwaite "It can only be 0 or 1 in a U32 for the time bei..."

Michael Garthwaite — Thu, 22 Dec 2022 13:19:52 -0800

Michael Garthwaite replied to Sean Nash in HD-DEN-14344-3

It can only be 0 or 1 in a U32 for the time being. I can cast it as a bool

HD-DEN-14344-3: comment by wbracken "RESOLVED IN CODE WALKTHROUGH."

wbracken — Thu, 22 Dec 2022 13:19:46 -0800

wbracken (deleted user) replied to wbracken (deleted user) in HD-DEN-14344-3

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 22 Dec 2022 13:15:07 -0800

Sean Nash replied to Sean Nash in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 22 Dec 2022 13:14:43 -0800

Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 22 Dec 2022 13:13:20 -0800

Sean Nash replied to Sean Nash in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 22 Dec 2022 13:12:48 -0800

Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 22 Dec 2022 13:12:25 -0800

Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 22 Dec 2022 13:11:57 -0800

Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 22 Dec 2022 13:11:28 -0800

Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.