Fisheye on hdfirmware/firmware/App/Controllers/Valves.h https://devapps.diality.us/changelog/~br%3DDEN-16693-institutional-settings-implementation/hdfirmware/firmware/App/Controllers/Valves.h Recent activity in "hdfirmware" under directory /firmware/App/Controllers/Valves.h HD-DEN-4308-3: closed by Dara Navaei Thu, 19 Oct 2023 08:26:20 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-4308-3 https://devapps.diality.us/cru/HD-DEN-4308-3 Dara Navaei Closed HD-DEN-4308-3 ]]> HD-DEN-4308-3: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:26:04 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-4308-3/#c19104 https://devapps.diality.us/cru/HD-DEN-4308-3/#c19104 Dara Navaei replied to Dara Navaei in HD-DEN-4308-3

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-4308-3: started by Dara Navaei Thu, 19 Oct 2023 08:18:34 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-4308-3 https://devapps.diality.us/cru/HD-DEN-4308-3 Dara Navaei started review HD-DEN-4308-3 ]]> HD-UCOMMITS-19: closed by Sean Nash Thu, 03 Aug 2023 08:57:40 -0700 Sean Nash https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Sean Nash Closed HD-UCOMMITS-19 ]]> HD-UCOMMITS-19: reviewers finished Wed, 02 Aug 2023 21:26:40 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Dara Navaei and Sean Nash finished reviewing HD-UCOMMITS-19 HD Staging Unreviewed Commits ]]> HD-UCOMMITS-19: started by Dara Navaei Mon, 08 May 2023 09:22:08 -0700 Dara Navaei https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Dara Navaei started review HD-UCOMMITS-19 ]]> HD-DEN-14262-1: closed by Dara Navaei Thu, 04 May 2023 10:27:12 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14262-1 https://devapps.diality.us/cru/HD-DEN-14262-1 Dara Navaei Closed HD-DEN-14262-1 ]]> HD-DEN-14262-1: reviewers finished Thu, 04 May 2023 09:52:41 -0700 https://devapps.diality.us/cru/HD-DEN-14262-1 https://devapps.diality.us/cru/HD-DEN-14262-1 Dara Navaei and Michael Garthwaite finished reviewing HD-DEN-14262-1 HD-DEN-14262_Vba Homing Fails When Cartridge IS Loaded ON Device ]]> HD-DEN-14262-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Wed, 03 May 2023 10:15:32 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-14262-1/#c17314 https://devapps.diality.us/cru/HD-DEN-14262-1/#c17314 wbracken  (deleted user) replied to Sean Nash in HD-DEN-14262-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-14262-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Wed, 03 May 2023 10:15:15 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-14262-1/#c17313 https://devapps.diality.us/cru/HD-DEN-14262-1/#c17313 wbracken  (deleted user) replied to Sean Nash in HD-DEN-14262-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-14262-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Wed, 03 May 2023 10:14:56 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-14262-1/#c17312 https://devapps.diality.us/cru/HD-DEN-14262-1/#c17312 wbracken  (deleted user) replied to Sean Nash in HD-DEN-14262-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-14262-1: comment by Sean Nash "Done." Wed, 03 May 2023 09:25:14 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-14262-1/#c17311 https://devapps.diality.us/cru/HD-DEN-14262-1/#c17311 Sean Nash replied to wbracken  (deleted user) in HD-DEN-14262-1

Done.

]]> HD-DEN-14262-1: comment by Sean Nash "Done." Wed, 03 May 2023 09:25:06 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-14262-1/#c17310 https://devapps.diality.us/cru/HD-DEN-14262-1/#c17310 Sean Nash replied to wbracken  (deleted user) in HD-DEN-14262-1

Done.

]]> HD-DEN-14262-1: comment by Sean Nash "Done." Wed, 03 May 2023 09:24:55 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-14262-1/#c17309 https://devapps.diality.us/cru/HD-DEN-14262-1/#c17309 Sean Nash replied to wbracken  (deleted user) in HD-DEN-14262-1

Done.

]]> HD-DEN-14262-1: comment by wbracken "Add recircEndTreatmentRequested to header." Tue, 02 May 2023 13:28:12 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-14262-1/#c17302 https://devapps.diality.us/cru/HD-DEN-14262-1/#c17302 wbracken  (deleted user) commented on HD-DEN-14262-1

Add recircEndTreatmentRequested to header.

]]> HD-DEN-14262-1: comment by wbracken "Add txEndAlarmEndTreatmentRequested to header." Tue, 02 May 2023 13:26:47 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-14262-1/#c17301 https://devapps.diality.us/cru/HD-DEN-14262-1/#c17301 wbracken  (deleted user) commented on HD-DEN-14262-1

Add txEndAlarmEndTreatmentRequested to header.

]]> HD-DEN-14262-1: comment by wbracken "Add endTreatmentRequested to header" Tue, 02 May 2023 13:23:22 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-14262-1/#c17300 https://devapps.diality.us/cru/HD-DEN-14262-1/#c17300 wbracken  (deleted user) commented on HD-DEN-14262-1

Add endTreatmentRequested to header

]]> HD-DEN-14262-1: started by Dara Navaei Fri, 28 Apr 2023 14:02:12 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14262-1 https://devapps.diality.us/cru/HD-DEN-14262-1 Dara Navaei started review HD-DEN-14262-1 ]]> HD-DEN-14763-1: closed by Dara Navaei Tue, 21 Mar 2023 17:12:35 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14763-1 https://devapps.diality.us/cru/HD-DEN-14763-1 Dara Navaei Closed HD-DEN-14763-1 ]]> HD-DEN-14763-1: reviewers finished Tue, 21 Mar 2023 08:16:18 -0700 https://devapps.diality.us/cru/HD-DEN-14763-1 https://devapps.diality.us/cru/HD-DEN-14763-1 Sean Nash finished reviewing HD-DEN-14763-1 HD-DEN-14763_DG HD Dev HD DG Dvt Update Part 10 ]]> HD-DEN-14763-1: reviewers resumed Mon, 20 Mar 2023 20:35:38 -0700 https://devapps.diality.us/cru/HD-DEN-14763-1 https://devapps.diality.us/cru/HD-DEN-14763-1 wbracken  (deleted user) resumed reviewing HD-DEN-14763-1 HD-DEN-14763_DG HD Dev HD DG Dvt Update Part 10 ]]> HD-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 20 Mar 2023 09:51:08 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-14763-1/#c16894 https://devapps.diality.us/cru/HD-DEN-14763-1/#c16894 Sean Nash replied to Dara Navaei in HD-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 20 Mar 2023 09:50:45 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-14763-1/#c16893 https://devapps.diality.us/cru/HD-DEN-14763-1/#c16893 Sean Nash replied to Dara Navaei in HD-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 20 Mar 2023 09:50:22 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-14763-1/#c16892 https://devapps.diality.us/cru/HD-DEN-14763-1/#c16892 Sean Nash replied to Dara Navaei in HD-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-14763-1: comment by Dara Navaei "Done" Mon, 20 Mar 2023 09:44:51 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14763-1/#c16888 https://devapps.diality.us/cru/HD-DEN-14763-1/#c16888 Dara Navaei replied to Sean Nash in HD-DEN-14763-1

Done

]]> HD-DEN-14763-1: comment by Dara Navaei "Done" Mon, 20 Mar 2023 09:37:39 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14763-1/#c16887 https://devapps.diality.us/cru/HD-DEN-14763-1/#c16887 Dara Navaei replied to Sean Nash in HD-DEN-14763-1

Done

]]> HD-DEN-14763-1: comment by Dara Navaei "Reverted back. Thanks for catching it." Mon, 20 Mar 2023 09:36:53 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14763-1/#c16886 https://devapps.diality.us/cru/HD-DEN-14763-1/#c16886 Dara Navaei replied to Sean Nash in HD-DEN-14763-1

Reverted back. Thanks for catching it.

]]> HD-DEN-14763-1: comment by Sean Nash "Since these are Dialin commands (0x8... msg IDs..." Mon, 20 Mar 2023 09:07:44 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-14763-1/#c16873 https://devapps.diality.us/cru/HD-DEN-14763-1/#c16873 Sean Nash commented on HD-DEN-14763-1

Since these are Dialin commands (0x8... msg IDs), we should require login before calling hard stop functions.

]]> HD-DEN-14763-1: comment by Sean Nash "size was right." Mon, 20 Mar 2023 09:03:50 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-14763-1/#c16872 https://devapps.diality.us/cru/HD-DEN-14763-1/#c16872 Sean Nash commented on HD-DEN-14763-1

size was right.

]]> HD-DEN-14763-1: comment by Sean Nash "Update comment." Mon, 20 Mar 2023 08:58:02 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-14763-1/#c16871 https://devapps.diality.us/cru/HD-DEN-14763-1/#c16871 Sean Nash commented on HD-DEN-14763-1

Update comment.

]]>