Fisheye on hdfirmware/firmware/App/Drivers/Comm.c

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 02 Jan 2024 10:53:49 -0800

Dara Navaei committed 736cc5b on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 56 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-3, +3)

| History

| Source

| Diff

… 102 more files in changeset.

HD-DEN-1312-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 09:33:22 -0700

Dara Navaei Closed HD-DEN-1312-1

HD-DEN-1312-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 09:32:52 -0700

Dara Navaei replied to Sean Nash in HD-DEN-1312-1

RESOLVED in CODE WALKTHROUGH

HD-DEN-1312-1: reviewers resumed

Thu, 19 Oct 2023 09:31:46 -0700

Dara Navaei resumed reviewing HD-DEN-1312-1

HD-DEN-1312_HD Dialysate Inlet Pump/Drive, Flow Sensor, Control

HD-DEN-1312-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 09:31:28 -0700

Dara Navaei started review HD-DEN-1312-1

HD-UCOMMITS-20: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 09:52:03 -0700

Sean Nash Closed HD-UCOMMITS-20

HD-UCOMMITS-20: reviewers finished

Thu, 03 Aug 2023 09:29:51 -0700

Dara Navaei finished reviewing HD-UCOMMITS-20

HD Staging Unreviewed Commits

HD-UCOMMITS-19: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 08:57:40 -0700

Sean Nash Closed HD-UCOMMITS-19

HD-UCOMMITS-19: reviewers finished

Wed, 02 Aug 2023 21:26:40 -0700

Dara Navaei and Sean Nash finished reviewing HD-UCOMMITS-19

HD Staging Unreviewed Commits

HD-UCOMMITS-20: reviewers finished

Wed, 02 Aug 2023 12:17:59 -0700

Sean Nash finished reviewing HD-UCOMMITS-20

HD Staging Unreviewed Commits

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 15 May 2023 14:25:15 -0700

Dara Navaei committed f4f7e0e on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 224 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Comm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Comm.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.h	(-2, +2)	\| History	\| Source	\| Diff

HD-DEN-15104-1: closed by wbracken

wbracken — Mon, 15 May 2023 13:43:03 -0700

wbracken (deleted user) Closed HD-DEN-15104-1

HD-DEN-15104-1: reviewers finished

Mon, 15 May 2023 11:35:15 -0700

dcox (deleted user) , jtaylor (deleted user) and Sean Nash finished reviewing HD-DEN-15104-1

HD-DEN-15104_HD Fpga Communications

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Sun, 14 May 2023 15:11:39 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Sun, 14 May 2023 15:10:56 -0700

Sean Nash replied to Sean Nash in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Sun, 14 May 2023 15:09:10 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1: comment by wbracken "Moved to here from function."

wbracken — Sun, 14 May 2023 12:39:51 -0700

wbracken (deleted user) replied to Sean Nash in HD-DEN-15104-1

Moved to here from function.

HD-DEN-15104-1: comment by wbracken "No longer needed."

wbracken — Sun, 14 May 2023 11:28:55 -0700

wbracken (deleted user) replied to Sean Nash in HD-DEN-15104-1

No longer needed.

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 12 May 2023 17:33:22 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 12 May 2023 17:32:24 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 12 May 2023 17:31:43 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 12 May 2023 17:31:30 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 12 May 2023 17:31:11 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 12 May 2023 17:30:37 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 12 May 2023 17:30:09 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1: comment by Sean Nash "Per my other comment, please avoid in-function ..."

Sean Nash — Fri, 12 May 2023 17:29:26 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

Per my other comment, please avoid in-function static variables.

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 12 May 2023 17:28:47 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1: comment by Sean Nash "Not a fan of in function statics. Probably due..."

Sean Nash — Fri, 12 May 2023 17:28:03 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 12 May 2023 17:27:07 -0700

Sean Nash replied to Sean Nash in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 12 May 2023 17:26:44 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.