Fisheye on hdfirmware/firmware/App/Modes/TreatmentRecirc.h https://devapps.diality.us/changelog/~br%3DDEN-16693-institutional-settings-implementation/hdfirmware/firmware/App/Modes/TreatmentRecirc.h Recent activity in "hdfirmware" under directory /firmware/App/Modes/TreatmentRecirc.h HD-DEN-9906-1: closed by Dara Navaei Thu, 19 Oct 2023 08:03:24 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1 https://devapps.diality.us/cru/HD-DEN-9906-1 Dara Navaei Closed HD-DEN-9906-1 ]]> HD-DEN-9906-1: reviewers finished Thu, 19 Oct 2023 08:02:54 -0700 https://devapps.diality.us/cru/HD-DEN-9906-1 https://devapps.diality.us/cru/HD-DEN-9906-1 Dara Navaei finished reviewing HD-DEN-9906-1 HD-DEN-9906_HD Dev Flow Measurement Changes ]]> HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:02:45 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c19091 https://devapps.diality.us/cru/HD-DEN-9906-1/#c19091 Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:02:38 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c19090 https://devapps.diality.us/cru/HD-DEN-9906-1/#c19090 Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-9906-1: started by Dara Navaei Thu, 19 Oct 2023 08:01:36 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1 https://devapps.diality.us/cru/HD-DEN-9906-1 Dara Navaei started review HD-DEN-9906-1 ]]> HD-DEN-9906-1: reviewers finished Mon, 15 Nov 2021 17:06:24 -0800 https://devapps.diality.us/cru/HD-DEN-9906-1 https://devapps.diality.us/cru/HD-DEN-9906-1 hnguyen  (deleted user) finished reviewing HD-DEN-9906-1 HD-DEN-9906_HD Dev Flow Measurement Changes ]]> HD-DEN-9906-1: comment by hnguyen "RESOLVED in CODE WALKTHROUGH" Mon, 15 Nov 2021 17:05:06 -0800 hnguyen https://devapps.diality.us/cru/HD-DEN-9906-1/#c11429 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11429 hnguyen  (deleted user) replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-9906-1: comment by hnguyen "RESOLVED in CODE WALKTHROUGH" Mon, 15 Nov 2021 17:04:47 -0800 hnguyen https://devapps.diality.us/cru/HD-DEN-9906-1/#c11428 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11428 hnguyen  (deleted user) replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-9906-1: comment by hnguyen "RESOLVED in CODE WALKTHROUGH" Mon, 15 Nov 2021 17:04:34 -0800 hnguyen https://devapps.diality.us/cru/HD-DEN-9906-1/#c11427 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11427 hnguyen  (deleted user) replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-9906-1: comment by hnguyen "RESOLVED in CODE WALKTHROUGH" Mon, 15 Nov 2021 17:03:56 -0800 hnguyen https://devapps.diality.us/cru/HD-DEN-9906-1/#c11426 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11426 hnguyen  (deleted user) replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-9906-1: comment by hnguyen "RESOLVED in CODE WALKTHROUGH" Mon, 15 Nov 2021 17:02:27 -0800 hnguyen https://devapps.diality.us/cru/HD-DEN-9906-1/#c11425 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11425 hnguyen  (deleted user) replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH. (On behalf of Beh..." Mon, 15 Nov 2021 16:59:26 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c11423 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11423 Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH. (On behalf of Behrouz NematiPour who is on vacation)

]]> HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH." Mon, 15 Nov 2021 16:58:51 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c11422 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11422 Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH." Mon, 15 Nov 2021 16:58:38 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c11421 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11421 Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH." Mon, 15 Nov 2021 16:58:15 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c11420 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11420 Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH." Mon, 15 Nov 2021 16:57:56 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c11419 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11419 Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-9906-1: comment by Sean Nash "Done." Mon, 15 Nov 2021 16:49:28 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-9906-1/#c11418 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11418 Sean Nash replied to hnguyen  (deleted user) in HD-DEN-9906-1

Done.

]]> HD-DEN-9906-1: comment by Sean Nash "Done." Mon, 15 Nov 2021 16:48:06 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-9906-1/#c11417 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11417 Sean Nash replied to hnguyen  (deleted user) in HD-DEN-9906-1

Done.

]]> HD-DEN-9906-1: comment by Sean Nash "Done." Mon, 15 Nov 2021 16:46:22 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-9906-1/#c11416 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11416 Sean Nash replied to Dara Navaei in HD-DEN-9906-1

Done.

]]> HD-DEN-9906-1: comment by Sean Nash "Done." Mon, 15 Nov 2021 16:46:06 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-9906-1/#c11415 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11415 Sean Nash replied to Dara Navaei in HD-DEN-9906-1

Done.

]]> HD-DEN-9906-1: comment by Sean Nash "Removed." Mon, 15 Nov 2021 16:44:26 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-9906-1/#c11414 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11414 Sean Nash replied to hnguyen  (deleted user) in HD-DEN-9906-1

Removed.

]]> HD-DEN-9906-1: comment by Dara Navaei "Adjust the space before the equal signs." Mon, 15 Nov 2021 13:10:11 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c11407 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11407 Dara Navaei commented on HD-DEN-9906-1

Adjust the space before the equal signs.

]]> HD-DEN-9906-1: comment by Sean Nash "I adjusted spaces "before" the equal sign." Mon, 15 Nov 2021 15:01:59 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-9906-1/#c11413 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11413 Sean Nash replied to Dara Navaei in HD-DEN-9906-1

I adjusted spaces "before" the equal sign.

]]> HD-DEN-9906-1: comment by Sean Nash "Our coding standard does not require MISRA comp..." Mon, 15 Nov 2021 14:59:06 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-9906-1/#c11412 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11412 Sean Nash replied to hnguyen  (deleted user) in HD-DEN-9906-1

Our coding standard does not require MISRA compliance and I don't think our coding standard includes this if else rule.
If you think it should be added to our standard, let's discuss.

]]> HD-DEN-9906-1: comment by Sean Nash "Added comment." Mon, 15 Nov 2021 14:58:11 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-9906-1/#c11411 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11411 Sean Nash replied to hnguyen  (deleted user) in HD-DEN-9906-1

Added comment.

]]> HD-DEN-9906-1: comment by Sean Nash "I wasn't sure what flow sensor "response" regis..." Mon, 15 Nov 2021 14:55:36 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-9906-1/#c11410 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11410 Sean Nash replied to Dara Navaei in HD-DEN-9906-1

I wasn't sure what flow sensor "response" registers were - moot now that sensors are gone.
Still unsure what to do with processor/pc error counts - will resolve this in a future branch.

]]> HD-DEN-9906-1: comment by Dara Navaei "Why there are TBDs in the comments?" Mon, 15 Nov 2021 14:19:10 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c11409 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11409 Dara Navaei commented on HD-DEN-9906-1

Why there are TBDs in the comments?

]]> HD-DEN-9906-1: comment by hnguyen "Outputs: Alarm may be activated" Mon, 15 Nov 2021 13:45:19 -0800 hnguyen https://devapps.diality.us/cru/HD-DEN-9906-1/#c11408 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11408 hnguyen  (deleted user) commented on HD-DEN-9906-1

Outputs: Alarm may be activated

]]> HD-DEN-9906-1: comment by hnguyen "Some of local variables are not used in this fu..." Mon, 15 Nov 2021 13:04:07 -0800 hnguyen https://devapps.diality.us/cru/HD-DEN-9906-1/#c11406 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11406 hnguyen  (deleted user) commented on HD-DEN-9906-1

Some of local variables are not used in this function, consider removing them.

]]> HD-DEN-9906-1: comment by Dara Navaei "This should be an F64." Mon, 15 Nov 2021 13:01:06 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c11405 https://devapps.diality.us/cru/HD-DEN-9906-1/#c11405 Dara Navaei commented on HD-DEN-9906-1

This should be an F64.

]]>