Fisheye on hdfirmware/firmware/source/het.c https://devapps.diality.us/changelog/~br%3DDEN-16693-institutional-settings-implementation/hdfirmware/firmware/source/het.c Recent activity in "hdfirmware" under directory /firmware/source/het.c HD-DEN-3115-1: closed by Dara Navaei Thu, 19 Oct 2023 08:40:42 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-3115-1 https://devapps.diality.us/cru/HD-DEN-3115-1 Dara Navaei Closed HD-DEN-3115-1 ]]> HD-DEN-3115-1: reviewers finished Thu, 19 Oct 2023 08:40:34 -0700 https://devapps.diality.us/cru/HD-DEN-3115-1 https://devapps.diality.us/cru/HD-DEN-3115-1 Dara Navaei finished reviewing HD-DEN-3115-1 HD-DEN-3115_HD Blood Flow 3 of 3 ]]> HD-DEN-3115-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:40:25 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-3115-1/#c19111 https://devapps.diality.us/cru/HD-DEN-3115-1/#c19111 Dara Navaei replied to qnguyen  (deleted user) in HD-DEN-3115-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-3115-1: started by Dara Navaei Thu, 19 Oct 2023 08:39:15 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-3115-1 https://devapps.diality.us/cru/HD-DEN-3115-1 Dara Navaei started review HD-DEN-3115-1 ]]> HD-DEN-4308-3: closed by Dara Navaei Thu, 19 Oct 2023 08:26:20 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-4308-3 https://devapps.diality.us/cru/HD-DEN-4308-3 Dara Navaei Closed HD-DEN-4308-3 ]]> HD-DEN-4308-3: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:26:04 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-4308-3/#c19104 https://devapps.diality.us/cru/HD-DEN-4308-3/#c19104 Dara Navaei replied to Dara Navaei in HD-DEN-4308-3

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-4308-3: started by Dara Navaei Thu, 19 Oct 2023 08:18:34 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-4308-3 https://devapps.diality.us/cru/HD-DEN-4308-3 Dara Navaei started review HD-DEN-4308-3 ]]> HD-DEN-14344-3: closed by Dara Navaei Wed, 18 Oct 2023 20:49:50 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14344-3 https://devapps.diality.us/cru/HD-DEN-14344-3 Dara Navaei Closed HD-DEN-14344-3 ]]> HD-DEN-14344-3: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH" Wed, 18 Oct 2023 20:49:40 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14344-3/#c19056 https://devapps.diality.us/cru/HD-DEN-14344-3/#c19056 Dara Navaei replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-14344-3: reviewers resumed Wed, 18 Oct 2023 20:48:20 -0700 https://devapps.diality.us/cru/HD-DEN-14344-3 https://devapps.diality.us/cru/HD-DEN-14344-3 Dara Navaei resumed reviewing HD-DEN-14344-3 HD-DEN-14344_SW S85 MG Air Pump ]]> HD-DEN-14344-3: started by Dara Navaei Wed, 18 Oct 2023 20:47:55 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14344-3 https://devapps.diality.us/cru/HD-DEN-14344-3 Dara Navaei started review HD-DEN-14344-3 ]]> HD-DEN-14344-3: reviewers finished Tue, 03 Jan 2023 16:18:53 -0800 https://devapps.diality.us/cru/HD-DEN-14344-3 https://devapps.diality.us/cru/HD-DEN-14344-3 wbracken  (deleted user) and Sean Nash finished reviewing HD-DEN-14344-3 HD-DEN-14344_SW S85 MG Air Pump ]]> HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 29 Dec 2022 11:23:15 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14344-3/#c15800 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15800 Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 29 Dec 2022 11:22:51 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14344-3/#c15799 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15799 Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-14344-3: comment by Michael Garthwaite "Fixed. Thanks!" Thu, 29 Dec 2022 11:10:27 -0800 Michael Garthwaite https://devapps.diality.us/cru/HD-DEN-14344-3/#c15798 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15798 Michael Garthwaite replied to Sean Nash in HD-DEN-14344-3

Fixed. Thanks!

]]> HD-DEN-14344-3: comment by Michael Garthwaite "Fixed. Thanks!" Thu, 29 Dec 2022 11:10:20 -0800 Michael Garthwaite https://devapps.diality.us/cru/HD-DEN-14344-3/#c15797 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15797 Michael Garthwaite replied to Sean Nash in HD-DEN-14344-3

Fixed. Thanks!

]]> HD-DEN-14344-3: reviewers resumed Thu, 29 Dec 2022 11:09:02 -0800 https://devapps.diality.us/cru/HD-DEN-14344-3 https://devapps.diality.us/cru/HD-DEN-14344-3 jtaylor  (deleted user) resumed reviewing HD-DEN-14344-3 HD-DEN-14344_SW S85 MG Air Pump ]]> HD-DEN-14344-3: comment by Sean Nash "For a release build, looks like we would do not..." Thu, 29 Dec 2022 09:47:53 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14344-3/#c15788 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15788 Sean Nash commented on HD-DEN-14344-3

For a release build, looks like we would do nothing and get stuck in this state.

]]> HD-DEN-14344-3: comment by Sean Nash "Add doxygen comment for persistence. Try to ca..." Thu, 29 Dec 2022 09:44:46 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14344-3/#c15787 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15787 Sean Nash commented on HD-DEN-14344-3

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

]]> HD-DEN-14344-3: comment by Michael Garthwaite "Fixed. Thanks!" Thu, 22 Dec 2022 13:35:37 -0800 Michael Garthwaite https://devapps.diality.us/cru/HD-DEN-14344-3/#c15779 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15779 Michael Garthwaite replied to Dara Navaei in HD-DEN-14344-3

Fixed. Thanks!

]]> HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 22 Dec 2022 13:33:32 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14344-3/#c15778 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15778 Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-14344-3: comment by Michael Garthwaite "The only time we would be adding more states is..." Thu, 22 Dec 2022 13:28:29 -0800 Michael Garthwaite https://devapps.diality.us/cru/HD-DEN-14344-3/#c15777 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15777 Michael Garthwaite replied to Sean Nash in HD-DEN-14344-3

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

]]> HD-DEN-14344-3: comment by Sean Nash "Would rather you set a BOOL based on state and ..." Thu, 22 Dec 2022 13:26:22 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14344-3/#c15776 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15776 Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

]]> HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 22 Dec 2022 13:25:08 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14344-3/#c15775 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15775 Sean Nash replied to Sean Nash in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 22 Dec 2022 13:24:53 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14344-3/#c15774 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15774 Sean Nash replied to Sean Nash in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-14344-3: comment by Michael Garthwaite "It can only be 0 or 1 in a U32 for the time bei..." Thu, 22 Dec 2022 13:19:52 -0800 Michael Garthwaite https://devapps.diality.us/cru/HD-DEN-14344-3/#c15769 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15769 Michael Garthwaite replied to Sean Nash in HD-DEN-14344-3

It can only be 0 or 1 in a U32 for the time being. I can cast it as a bool

]]> HD-DEN-14344-3: comment by wbracken "RESOLVED IN CODE WALKTHROUGH." Thu, 22 Dec 2022 13:19:46 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14344-3/#c15768 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15768 wbracken  (deleted user) replied to wbracken  (deleted user) in HD-DEN-14344-3

RESOLVED IN CODE WALKTHROUGH.

]]> HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 22 Dec 2022 13:15:07 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14344-3/#c15766 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15766 Sean Nash replied to Sean Nash in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 22 Dec 2022 13:14:43 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14344-3/#c15765 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15765 Sean Nash replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-14344-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 22 Dec 2022 13:13:20 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14344-3/#c15764 https://devapps.diality.us/cru/HD-DEN-14344-3/#c15764 Sean Nash replied to Sean Nash in HD-DEN-14344-3

RESOLVED in CODE WALKTHROUGH.

]]>