Fisheye on application/sources/view/settings/VDuetRoWaterDG.cpp https://devapps.diality.us/changelog/~br%3DDEN-16924-Remove-QRCode-From-P1/application/sources/view/settings/VDuetRoWaterDG.cpp Recent activity in "application" under directory /sources/view/settings/VDuetRoWaterDG.cpp UI-DEN-SUNRISE-1: closed by Dara Navaei Fri, 15 Nov 2024 12:54:28 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 Dara Navaei Closed UI-DEN-SUNRISE-1 ]]> UI-DEN-SUNRISE-1: reviewers removed from UI-DEN-SUNRISE Fri, 07 Jun 2024 09:05:01 -0700 https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 Dara Navaei removed Sean Nash and vduong  (deleted user) from UI-DEN-SUNRISE-1 UI-DEN-SUNRISE ]]> UI-DEN-SUNRISE-1: started by Dara Navaei Fri, 07 Jun 2024 09:04:34 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 Dara Navaei started review UI-DEN-SUNRISE-1 ]]> UI-DEN-16899-3: closed by Dara Navaei Tue, 14 May 2024 14:17:16 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16899-3 https://devapps.diality.us/cru/UI-DEN-16899-3 Dara Navaei Closed UI-DEN-16899-3 ]]> UI-DEN-16899-3: reviewers finished Tue, 14 May 2024 13:46:01 -0700 https://devapps.diality.us/cru/UI-DEN-16899-3 https://devapps.diality.us/cru/UI-DEN-16899-3 Behrouz NematiPour and Sean Nash finished reviewing UI-DEN-16899-3 UI-DEN-16899_Release/Stagingmerge Den 16899 UI BN R13 Build ]]> UI-DEN-16899-3: reviewers joined UI-DEN-16899_Release/Stagingmerge Den 16899 UI BN ... Tue, 14 May 2024 13:39:56 -0700 https://devapps.diality.us/cru/UI-DEN-16899-3 https://devapps.diality.us/cru/UI-DEN-16899-3 Behrouz NematiPour joined UI-DEN-16899-3 UI-DEN-16899_Release/Stagingmerge Den 16899 UI BN R13 Build ]]> UI-DEN-16899-3: reviewers removed from UI-DEN-16899_Release/Stagingmerge Den 16899 UI BN ... Tue, 14 May 2024 13:39:56 -0700 https://devapps.diality.us/cru/UI-DEN-16899-3 https://devapps.diality.us/cru/UI-DEN-16899-3 Behrouz NematiPour removed Dara Navaei from UI-DEN-16899-3 UI-DEN-16899_Release/Stagingmerge Den 16899 UI BN R13 Build ]]> UI-DEN-16899-3: started by Dara Navaei Tue, 14 May 2024 13:21:18 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16899-3 https://devapps.diality.us/cru/UI-DEN-16899-3 Dara Navaei started review UI-DEN-16899-3 ]]> UI-DEN-16860-1: closed by Dara Navaei Fri, 10 May 2024 14:20:48 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16860-1 https://devapps.diality.us/cru/UI-DEN-16860-1 Dara Navaei Closed UI-DEN-16860-1 ]]> application (release/stagingmerge-DEN-17098-release_18_changes): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 10 May 2024 14:17:25 -0700 Dara Navaei https://devapps.diality.us/changelog/application?cs=38ae7b93679d05a54fc460dac68891562d7da72d https://devapps.diality.us/changelog/application?cs=38ae7b93679d05a54fc460dac68891562d7da72d Dara Navaei committed 38ae7b9 on branch master, DEN-16553-UI-BN-WPA3-Support and 44 more in application Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /sources/canbus/MessageDispatcher.cpp (-1, +1) | History | Source | Diff
· /sources/canbus/MessageDispatcher.h (-1, +1) | History | Source | Diff
· /sources/canbus/MessageGlobals.h (-1, +1) | History | Source | Diff
· /sources/canbus/MessageInterpreter.cpp (-1, +1) | History | Source | Diff
· /sources/gui/GuiGlobals.h (-1, +1) | History | Source | Diff
· /sources/model/MModel.h (-1, +1) | History | Source | Diff
· /sources/model/dg/adjustment/settings/MDuetRoWaterDG.cpp (-2, +2) | History | Source | Diff
· /sources/model/dg/adjustment/settings/MDuetRoWaterDG.h (-2, +2) | History | Source | Diff
· /sources/model/dg/data/MDGHeatersData.cpp (-2, +2) | History | Source | Diff
· /sources/model/dg/data/MDGHeatersData.h (-2, +2) | History | Source | Diff
· /sources/model/hd/adjustment/settings/MAdjustHDRequests.h (-1, +1) | History | Source | Diff
· /sources/model/hd/alarm/MAlarmMapping.cpp (-20, +14) | History | Source | Diff
· /sources/model/hd/data/MHDBloodLeakData.cpp (-2, +2) | History | Source | Diff
· /sources/model/hd/data/MHDBloodLeakData.h (-2, +2) | History | Source | Diff
· /sources/model/hd/data/treatment/MTreatmentBloodFlowData.cpp (-2, +2) | History | Source | Diff
… 17 more files in changeset.
]]> UI-DEN-16860-1: reviewers finished Fri, 10 May 2024 14:09:42 -0700 https://devapps.diality.us/cru/UI-DEN-16860-1 https://devapps.diality.us/cru/UI-DEN-16860-1 Behrouz NematiPour and Sean Nash finished reviewing UI-DEN-16860-1 UI-DEN-16860_UI DN S122 ]]> UI-DEN-16860-1: comment by Behrouz NematiPour "RESOLVED" Fri, 10 May 2024 13:54:21 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16860-1/#c19774 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19774 Behrouz NematiPour replied to Dara Navaei in UI-DEN-16860-1

RESOLVED

]]> UI-DEN-16860-1: comment by Behrouz NematiPour "RESOLVED" Fri, 10 May 2024 13:54:13 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16860-1/#c19773 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19773 Behrouz NematiPour replied to Dara Navaei in UI-DEN-16860-1

RESOLVED

]]> UI-DEN-16860-1: comment by Behrouz NematiPour "RESOLVED" Fri, 10 May 2024 13:54:08 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16860-1/#c19772 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19772 Behrouz NematiPour replied to Dara Navaei in UI-DEN-16860-1

RESOLVED

]]> UI-DEN-16860-1: comment by Behrouz NematiPour "RESOLVED" Fri, 10 May 2024 13:43:44 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16860-1/#c19771 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19771 Behrouz NematiPour replied to Dara Navaei in UI-DEN-16860-1

RESOLVED

]]> UI-DEN-16860-1: comment by Behrouz NematiPour "RESOLVED" Fri, 10 May 2024 13:43:04 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16860-1/#c19770 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19770 Behrouz NematiPour replied to Dara Navaei in UI-DEN-16860-1

RESOLVED

]]> application (release/stagingmerge-DEN-17098-release_18_changes): DEN-16204: UI: FW: Pure Water mode turning on intermittently... Fri, 10 May 2024 13:41:47 -0700 Dara Navaei https://devapps.diality.us/changelog/application?cs=22b7b49b9e973ea560eee30ecb48aa982555bf54 https://devapps.diality.us/changelog/application?cs=22b7b49b9e973ea560eee30ecb48aa982555bf54 Dara Navaei committed 22b7b49 on branch master, DEN-16553-UI-BN-WPA3-Support and 45 more in application DEN-16204: UI: FW: Pure Water mode turning on intermittently

- Addressed the code review comments.

· /sources/model/hd/data/treatment/MTreatmentBloodFlowData.cpp (-0, +1) | History | Source | Diff
· /sources/view/VAdjustmentResponseBase.h (-1, +0) | History | Source | Diff
· /sources/view/settings/VDuetRoWaterDG.cpp (-8, +3) | History | Source | Diff
· /sources/view/settings/VDuetRoWaterDG.h (-4, +4) | History | Source | Diff
]]> UI-DEN-16860-1: comment by Dara Navaei "Done" Fri, 10 May 2024 13:39:13 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16860-1/#c19769 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19769 Dara Navaei replied to Behrouz NematiPour in UI-DEN-16860-1

Done

]]> UI-DEN-16860-1: comment by Dara Navaei "Done" Fri, 10 May 2024 13:39:06 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16860-1/#c19768 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19768 Dara Navaei replied to Behrouz NematiPour in UI-DEN-16860-1

Done

]]> UI-DEN-16860-1: comment by Dara Navaei "Done" Fri, 10 May 2024 13:38:57 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16860-1/#c19767 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19767 Dara Navaei replied to Behrouz NematiPour in UI-DEN-16860-1

Done

]]> UI-DEN-16860-1: comment by Dara Navaei "Done" Fri, 10 May 2024 13:38:21 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16860-1/#c19766 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19766 Dara Navaei replied to Behrouz NematiPour in UI-DEN-16860-1

Done

]]> UI-DEN-16860-1: comment by Dara Navaei "Done" Fri, 10 May 2024 13:37:53 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16860-1/#c19765 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19765 Dara Navaei replied to Behrouz NematiPour in UI-DEN-16860-1

Done

]]> UI-DEN-16860-1: comment by Behrouz NematiPour "add the newly added parameter here as well." Fri, 10 May 2024 13:29:18 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16860-1/#c19764 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19764 Behrouz NematiPour commented on UI-DEN-16860-1

add the newly added parameter here as well.

]]> UI-DEN-16860-1: comment by Behrouz NematiPour "remove this from her ( the base class ) and add..." Fri, 10 May 2024 13:23:17 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16860-1/#c19763 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19763 Behrouz NematiPour commented on UI-DEN-16860-1

remove this from her ( the base class ) and add it to the VDuetRoWaterDG.h

]]> UI-DEN-16860-1: comment by Behrouz NematiPour "1 - remove _post from here and the header." Fri, 10 May 2024 13:18:55 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16860-1/#c19759 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19759 Behrouz NematiPour commented on UI-DEN-16860-1

1 - remove _post from here and the header.

]]> UI-DEN-16860-1: comment by Behrouz NematiPour "3 - move this out of if and do it regardless of..." Fri, 10 May 2024 13:19:50 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16860-1/#c19761 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19761 Behrouz NematiPour commented on UI-DEN-16860-1

3 - move this out of if and do it regardless of accept or reject.

]]> UI-DEN-16860-1: comment by Behrouz NematiPour "2 - remove this line and rely on the mFirmwareV..." Fri, 10 May 2024 13:19:17 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16860-1/#c19760 https://devapps.diality.us/cru/UI-DEN-16860-1/#c19760 Behrouz NematiPour commented on UI-DEN-16860-1

2 - remove this line and rely on the mFirmwareValue

]]> application (release/stagingmerge-DEN-17098-release_18_changes): DEN-16204: UI: FW: Pure Water mode turning on intermittently... Wed, 08 May 2024 11:13:05 -0700 Dara Navaei https://devapps.diality.us/changelog/application?cs=f691de7d9e2076c8002c25e874d367fda30a09d5 https://devapps.diality.us/changelog/application?cs=f691de7d9e2076c8002c25e874d367fda30a09d5 Dara Navaei committed f691de7 on branch master, DEN-16553-UI-BN-WPA3-Support and 45 more in application DEN-16204: UI: FW: Pure Water mode turning on intermittently

- Changed the order of the UI response message from firmware so the accept is always the first field.

· /sources/model/dg/adjustment/settings/MDuetRoWaterDG.cpp (-3, +3) | History | Source | Diff
· /sources/model/dg/adjustment/settings/MDuetRoWaterDG.h (-5, +5) | History | Source | Diff
· /sources/view/settings/VDuetRoWaterDG.cpp (-1, +1) | History | Source | Diff
]]> application (release/stagingmerge-DEN-17098-release_18_changes): DEN-16204: UI: FW: Pure Water mode turning on intermittently. - Added a new payload to send the current firmware value ... Sat, 04 May 2024 20:21:57 -0700 Dara Navaei https://devapps.diality.us/changelog/application?cs=988d4037838bb83205e1b98e1323846271e58571 https://devapps.diality.us/changelog/application?cs=988d4037838bb83205e1b98e1323846271e58571 Dara Navaei committed 988d403 on branch master, DEN-16553-UI-BN-WPA3-Support and 45 more in application DEN-16204: UI: FW: Pure Water mode turning on intermittently. - Added a new payload to send the current firmware value with the response to a set from UI - Changed the RO only mode code to not flip the UI RO only status if the firmware rejected the set value and just get the status in the firmware

· /sources/canbus/MessageGlobals.h (-1, +1) | History | Source | Diff
· /sources/model/dg/adjustment/settings/MDuetRoWaterDG.cpp (-6, +10) | History | Source | Diff
· /sources/model/dg/adjustment/settings/MDuetRoWaterDG.h (-6, +9) | History | Source | Diff
· /sources/view/VAdjustmentResponseBase.h (-0, +1) | History | Source | Diff
· /sources/view/settings/VDuetRoWaterDG.cpp (-4, +3) | History | Source | Diff
]]> UI-DEN-16860-1: started by Dara Navaei Fri, 03 May 2024 14:45:18 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16860-1 https://devapps.diality.us/cru/UI-DEN-16860-1 Dara Navaei started review UI-DEN-16860-1 ]]>