Fisheye on dgfirmware/firmware/App/Modes/ModeHeatDisinfectActiveCool.h

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Jan 2024 14:00:04 -0800

Dara Navaei committed 7d4711e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

DG-DEN-14763-1: closed by Dara Navaei

Dara Navaei — Tue, 21 Mar 2023 17:12:45 -0700

Dara Navaei Closed DG-DEN-14763-1

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 21 Mar 2023 16:48:33 -0700

Dara Navaei committed c230be1 on branch DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 142 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfectFlush.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-2, +2)

| History

| Source

| Diff

… 3 more files in changeset.

DG-DEN-14763-1: reviewers resumed

Tue, 21 Mar 2023 08:35:30 -0700

Sean Nash resumed reviewing DG-DEN-14763-1

DG-DEN-14763_DG HD Dev HD DG Dvt Update Part 10

DG-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 21 Mar 2023 08:33:20 -0700

Sean Nash replied to Dara Navaei in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 21 Mar 2023 08:32:48 -0700

Sean Nash replied to Dara Navaei in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14763-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 21 Mar 2023 08:30:01 -0700

Dara Navaei replied to Sean Nash in DG-DEN-14763-1

Done

DG-DEN-14763-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 21 Mar 2023 08:28:22 -0700

Dara Navaei replied to Sean Nash in DG-DEN-14763-1

Done

DG-DEN-14763-1: comment by Sean Nash "This seems wrong."

Sean Nash — Mon, 20 Mar 2023 23:50:50 -0700

Sean Nash commented on DG-DEN-14763-1

This seems wrong.

DG-DEN-14763-1: comment by Sean Nash "This seems wrong."

Sean Nash — Mon, 20 Mar 2023 23:50:13 -0700

Sean Nash commented on DG-DEN-14763-1

This seems wrong.

DG-DEN-14763-1: reviewers resumed

Mon, 20 Mar 2023 20:31:36 -0700

wbracken (deleted user) and jtaylor (deleted user) resumed reviewing DG-DEN-14763-1

DG-DEN-14763_DG HD Dev HD DG Dvt Update Part 10

DG-DEN-14763-1: comment by jtaylor "RESOLVED in CODE WALKTHROUGH."

jtaylor — Mon, 20 Mar 2023 16:34:46 -0700

jtaylor (deleted user) replied to Sean Nash in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14763-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Mon, 20 Mar 2023 13:32:35 -0700

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14763-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Mon, 20 Mar 2023 09:49:15 -0700

Sean Nash replied to Dara Navaei in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Mon, 20 Mar 2023 09:48:46 -0700

Sean Nash replied to Dara Navaei in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Mon, 20 Mar 2023 09:48:22 -0700

Sean Nash replied to Dara Navaei in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14763-1: comment by Dara Navaei "Done. Thanks for catching it."

Dara Navaei — Mon, 20 Mar 2023 09:34:18 -0700

Dara Navaei replied to Sean Nash in DG-DEN-14763-1

Done. Thanks for catching it.

DG-DEN-14763-1: comment by Dara Navaei "Done"

Dara Navaei — Mon, 20 Mar 2023 09:28:53 -0700

Dara Navaei replied to Sean Nash in DG-DEN-14763-1

Done

DG-DEN-14763-1: comment by Dara Navaei "Done"

Dara Navaei — Mon, 20 Mar 2023 09:28:17 -0700

Dara Navaei replied to Sean Nash in DG-DEN-14763-1

Done

DG-DEN-14763-1: comment by Sean Nash "Not all of these are disinfect usage (e.g. RO w..."

Sean Nash — Mon, 20 Mar 2023 08:55:49 -0700

Sean Nash replied to jtaylor (deleted user) in DG-DEN-14763-1

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

DG-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Mon, 20 Mar 2023 08:48:18 -0700

Sean Nash replied to Dara Navaei in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14763-1: comment by Sean Nash "Missing comment?"

Sean Nash — Mon, 20 Mar 2023 08:43:01 -0700

Sean Nash commented on DG-DEN-14763-1

Missing comment?

DG-DEN-14763-1: comment by Sean Nash "Everything else in this function should be in a..."

Sean Nash — Mon, 20 Mar 2023 08:42:12 -0700

Sean Nash commented on DG-DEN-14763-1

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

DG-DEN-14763-1: comment by Sean Nash "Why lower case when others are uppercase?"

Sean Nash — Mon, 20 Mar 2023 08:36:34 -0700

Sean Nash commented on DG-DEN-14763-1

Why lower case when others are uppercase?

DG-DEN-14763-1: comment by Dara Navaei "This is to find the target configuration which ..."

Dara Navaei — Sat, 18 Mar 2023 14:36:22 -0700

Dara Navaei replied to Sean Nash in DG-DEN-14763-1

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this check box being true or false. I set it back to true to be consistent.

DG-DEN-14763-1: comment by Dara Navaei "Done"

Dara Navaei — Fri, 17 Mar 2023 14:42:49 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-14763-1

Done

DG-DEN-14763-1: comment by jtaylor "I would suggest a more consistent naming for th..."

jtaylor — Fri, 17 Mar 2023 08:43:24 -0700

jtaylor (deleted user) commented on DG-DEN-14763-1

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS".
This would be more specific since "USAGE" and "INFO" are redundant, and "DIS" can be confused with "dis-", the Latin prefix.

DG-DEN-14763-1: comment by wbracken "Comment alignment."

wbracken — Thu, 16 Mar 2023 22:08:46 -0700

wbracken (deleted user) commented on DG-DEN-14763-1

Comment alignment.

DG-DEN-14763-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Thu, 16 Mar 2023 12:12:03 -0700

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14763-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14763-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Thu, 16 Mar 2023 12:11:37 -0700

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14763-1

RESOLVED IN CODE WALKTHROUGH