Fisheye on dgfirmware/firmware/checkAlarms.sh

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Jan 2024 14:00:04 -0800

Dara Navaei committed 7d4711e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 15 Feb 2023 20:10:29 -0800

Dara Navaei committed 96b5f96 on branch DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14316-chemical-disinfect and 153 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/checkAlarms.sh	(-2, +2)	\| History	\| Source	\| Diff

DG-DEN-14781-1: closed by Dara Navaei

Dara Navaei — Wed, 15 Feb 2023 20:10:04 -0800

Dara Navaei Closed DG-DEN-14781-1

DG-DEN-14781-1: reviewers finished

Wed, 15 Feb 2023 16:40:24 -0800

wbracken (deleted user) , Sean Nash and Michael Garthwaite finished reviewing DG-DEN-14781-1

DG-DEN-14781_Alarm 117 DG Can Message Not Acked

DG-DEN-14781-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Wed, 15 Feb 2023 13:03:16 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14781-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14781-1: comment by Dara Navaei "There is not a #define for 0.0F."

Dara Navaei — Wed, 15 Feb 2023 12:54:36 -0800

Dara Navaei replied to wbracken (deleted user) in DG-DEN-14781-1

There is not a #define for 0.0F.

DG-DEN-14781-1: comment by wbracken "Should be #define"

wbracken — Wed, 15 Feb 2023 12:53:28 -0800

wbracken (deleted user) commented on DG-DEN-14781-1

Should be #define

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14781 updated the code to be able to support Nelson modes

Dara Navaei — Wed, 15 Feb 2023 08:45:34 -0800

Dara Navaei committed a391639 on branch DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14316-chemical-disinfect and 154 more in dgfirmware

DEN-14781 updated the code to be able to support Nelson modes

· /firmware/App/Controllers/ConcentratePumps.c	(-13, +12)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-2, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-34, +16)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-25, +31)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +0)	\| History	\| Source	\| Diff
· /firmware/checkAlarms.sh	(-2, +2)	\| History	\| Source	\| Diff

DG-DEN-14781-1: started by Dara Navaei

Dara Navaei — Mon, 13 Feb 2023 12:01:32 -0800

Dara Navaei started review DG-DEN-14781-1

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 03 Jan 2023 10:10:54 -0800

Dara Navaei committed 6499ea2 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 174 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 84 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 21 Dec 2022 15:02:37 -0800

Dara Navaei committed 81769c6 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-2, +2)

| History

| Source

| Diff

… 12 more files in changeset.

DG-DEN-14307-1: closed by Dara Navaei

Dara Navaei — Wed, 21 Dec 2022 15:02:13 -0800

Dara Navaei Closed DG-DEN-14307-1

DG-DEN-14307-1: reviewers finished

Wed, 21 Dec 2022 14:57:24 -0800

wbracken (deleted user) and Sean Nash finished reviewing DG-DEN-14307-1

DG-DEN-14307_DG HD Dev HD DG Dvt Update Part 6

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODE WALKTRHOUGH."

wbracken — Wed, 21 Dec 2022 14:56:32 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODE WALKTRHOUGH.

DG-DEN-14307-1: comment by Dara Navaei "These two variables are local."

Dara Navaei — Wed, 21 Dec 2022 14:55:29 -0800

Dara Navaei replied to wbracken (deleted user) in DG-DEN-14307-1

These two variables are local.

DG-DEN-14307-1: comment by wbracken "Add concCap and diaCap to header."

wbracken — Wed, 21 Dec 2022 14:52:49 -0800

wbracken (deleted user) commented on DG-DEN-14307-1

Add concCap and diaCap to header.

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH."

wbracken — Wed, 21 Dec 2022 14:44:32 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

DG-DEN-14307-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 21 Dec 2022 13:04:50 -0800

Dara Navaei replied to wbracken (deleted user) in DG-DEN-14307-1

Done

DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 21 Dec 2022 13:04:04 -0800

Sean Nash replied to Sean Nash in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH."

wbracken — Wed, 21 Dec 2022 12:13:27 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

DG-DEN-14307-1: comment by wbracken "Should add alarmDetectedPendingTrigger and preF..."

wbracken — Wed, 21 Dec 2022 12:12:19 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14307-1

Should add alarmDetectedPendingTrigger and preFlushState.

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH."

wbracken — Wed, 21 Dec 2022 12:10:54 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH."

wbracken — Wed, 21 Dec 2022 12:09:54 -0800

wbracken (deleted user) replied to wbracken (deleted user) in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH."

wbracken — Wed, 21 Dec 2022 12:06:24 -0800

wbracken (deleted user) replied to wbracken (deleted user) in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH."

wbracken — Wed, 21 Dec 2022 12:05:23 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 21 Dec 2022 11:36:38 -0800

Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 21 Dec 2022 11:35:14 -0800

Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 21 Dec 2022 11:34:45 -0800

Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 21 Dec 2022 11:34:37 -0800

Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 21 Dec 2022 11:34:19 -0800

Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.