Fisheye on dgfirmware/firmware/source/etpwm.c https://devapps.diality.us/changelog/~br%3DDEN-17047-remove-uv-reactors-from-code-bases/dgfirmware/firmware/source/etpwm.c Recent activity in "dgfirmware" under directory /firmware/source/etpwm.c DG-DEN-2650-1: closed by Dara Navaei Thu, 19 Oct 2023 08:42:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei Closed DG-DEN-2650-1 ]]> DG-DEN-2650-1: reviewers finished Thu, 19 Oct 2023 08:42:03 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei finished reviewing DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:41:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2650-1: started by Dara Navaei Thu, 19 Oct 2023 08:41:19 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei started review DG-DEN-2650-1 ]]> DG-DEN-2379-1: closed by Dara Navaei Thu, 19 Oct 2023 08:38:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2379-1 https://devapps.diality.us/cru/DG-DEN-2379-1 Dara Navaei Closed DG-DEN-2379-1 ]]> DG-DEN-2379-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:38:39 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2379-1/#c19110 https://devapps.diality.us/cru/DG-DEN-2379-1/#c19110 Dara Navaei replied to Dara Navaei in DG-DEN-2379-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2379-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:38:04 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2379-1/#c19109 https://devapps.diality.us/cru/DG-DEN-2379-1/#c19109 Dara Navaei replied to Dara Navaei in DG-DEN-2379-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2379-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:36:42 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2379-1/#c19108 https://devapps.diality.us/cru/DG-DEN-2379-1/#c19108 Dara Navaei replied to Dara Navaei in DG-DEN-2379-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2379-1: reviewers resumed Thu, 19 Oct 2023 08:35:24 -0700 https://devapps.diality.us/cru/DG-DEN-2379-1 https://devapps.diality.us/cru/DG-DEN-2379-1 pmontazemi  (deleted user) and Sean Nash resumed reviewing DG-DEN-2379-1 DG-DEN-2379_DG Dialysate Temperature 1 of 2 ]]> DG-DEN-2379-1: started by Dara Navaei Thu, 19 Oct 2023 08:35:23 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2379-1 https://devapps.diality.us/cru/DG-DEN-2379-1 Dara Navaei started review DG-DEN-2379-1 ]]> DG-DEN-4217-1: closed by Dara Navaei Thu, 19 Oct 2023 08:28:36 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei Closed DG-DEN-4217-1 ]]> DG-DEN-4217-1: reviewers finished Thu, 19 Oct 2023 08:28:27 -0700 https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei , qnguyen  (deleted user) and pmontazemi  (deleted user) finished reviewing DG-DEN-4217-1 DG-DEN-4217_Level and Shock Detection ]]> DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:28:18 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1/#c19106 https://devapps.diality.us/cru/DG-DEN-4217-1/#c19106 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:27:53 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1/#c19105 https://devapps.diality.us/cru/DG-DEN-4217-1/#c19105 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-4217-1: started by Dara Navaei Thu, 19 Oct 2023 08:26:45 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei started review DG-DEN-4217-1 ]]> DG-DEN-4217-1: closed by Sean Nash Thu, 20 Aug 2020 19:18:01 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Sean Nash Closed DG-DEN-4217-1 ]]> DG-DEN-4217-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 20 Aug 2020 15:09:03 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3619 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3619 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4217-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 20 Aug 2020 15:08:54 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3618 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3618 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4217-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 20 Aug 2020 15:08:25 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3617 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3617 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4217-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 20 Aug 2020 15:06:26 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3616 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3616 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4217-1: comment by Sean Nash "Agreed. Will address in another branch - maybe..." Thu, 20 Aug 2020 14:58:41 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4217-1/#c3615 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3615 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-4217-1

Agreed. Will address in another branch - maybe Dara's?

]]> DG-DEN-4217-1: comment by pmontazemi "Recommend replacing 2 with DG and do the same f..." Thu, 20 Aug 2020 14:54:57 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3614 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3614 pmontazemi  (deleted user) commented on DG-DEN-4217-1

Recommend replacing 2 with DG and do the same for other Software Items (HD, etc.).

]]> DG-DEN-4217-1: comment by Sean Nash "It's a test build #. They may do several lab r..." Thu, 20 Aug 2020 14:49:02 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4217-1/#c3613 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3613 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-4217-1

It's a test build #. They may do several lab revisions before test results looks good, then roll minor revision.

]]> DG-DEN-4217-1: comment by Sean Nash "This isn't code - it's a commented equation exp..." Thu, 20 Aug 2020 14:46:20 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4217-1/#c3611 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3611 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-4217-1

This isn't code - it's a commented equation explaining next 2 lines of code. That said, Dara can add spaces for readability on his branch.

]]> DG-DEN-4217-1: comment by pmontazemi "What is lab rev number and how it is different ..." Thu, 20 Aug 2020 14:46:27 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3612 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3612 pmontazemi  (deleted user) commented on DG-DEN-4217-1

What is lab rev number and how it is different from minor rev number?

]]> DG-DEN-4217-1: comment by Sean Nash "This isn't code - it's a commented equation exp..." Thu, 20 Aug 2020 14:45:00 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4217-1/#c3610 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3610 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-4217-1

This isn't code - it's a commented equation explaining next 2 lines of code. That said, Dara can add spaces for readability on his branch.

]]> DG-DEN-4217-1: comment by pmontazemi "Spaces between arithmetic operation signs." Thu, 20 Aug 2020 14:40:20 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3609 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3609 pmontazemi  (deleted user) commented on DG-DEN-4217-1

Spaces between arithmetic operation signs.

]]> DG-DEN-4217-1: comment by pmontazemi "Spaces between arithmetic operation signs." Thu, 20 Aug 2020 14:40:13 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3608 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3608 pmontazemi  (deleted user) commented on DG-DEN-4217-1

Spaces between arithmetic operation signs.

]]> DG-DEN-4217-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Wed, 19 Aug 2020 10:45:56 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3606 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3606 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4217-1: comment by Sean Nash "Waiting for DG FPGA fix to remove comment perma..." Wed, 19 Aug 2020 10:44:12 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4217-1/#c3605 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3605 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-4217-1

Waiting for DG FPGA fix to remove comment permanently as this is a common module.

]]>