Fisheye on hdfirmware/results/execution

HD-UCOMMITS-20: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 09:52:03 -0700

Sean Nash Closed HD-UCOMMITS-20

HD-UCOMMITS-20: reviewers finished

Thu, 03 Aug 2023 09:29:51 -0700

Dara Navaei finished reviewing HD-UCOMMITS-20

HD Staging Unreviewed Commits

HD-UCOMMITS-20: reviewers finished

Wed, 02 Aug 2023 12:17:59 -0700

Sean Nash finished reviewing HD-UCOMMITS-20

HD Staging Unreviewed Commits

HD-UCOMMITS-20: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 09:26:10 -0700

Dara Navaei started review HD-UCOMMITS-20

HD-DEN-759-1: closed by Dara Navaei

Dara Navaei — Fri, 13 Dec 2019 12:39:00 -0800

Dara Navaei Closed HD-DEN-759-1

HD-DEN-759-1: reviewers finished

Fri, 13 Dec 2019 10:24:32 -0800

lbaloa (deleted user) , Behrouz NematiPour and Dara Navaei finished reviewing HD-DEN-759-1

HD-DEN-759_BloodFlow

HD-DEN-759-1: reviewers finished

Thu, 12 Dec 2019 15:47:13 -0800

pmontazemi (deleted user) finished reviewing HD-DEN-759-1

HD-DEN-759_BloodFlow

HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH."

pmontazemi — Thu, 12 Dec 2019 10:07:49 -0800

pmontazemi (deleted user) replied to pmontazemi (deleted user) in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH."

pmontazemi — Thu, 12 Dec 2019 10:05:49 -0800

pmontazemi (deleted user) replied to pmontazemi (deleted user) in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Removed Vectorcast results. +review HD-DEN-759-1

Sean Nash — Wed, 11 Dec 2019 16:09:32 -0800

Sean Nash committed a1f70ea on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 395 more in hdfirmware

Removed Vectorcast results. +review HD-DEN-759-1

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_ALARMLAMP_execution_results_report.html

(-5314, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_ALARMMGMT_execution_results_report.html

(-12108, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_BLOODFLOW_execution_results_report.html

(-19216, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_BUTTONS_execution_results_report.html

(-9196, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_COMMBUFFERS_execution_results_report.html

(-5106, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_COMM_execution_results_report.html

(-3636, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_CPLD_execution_results_report.html

(-2074, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_FPGA_execution_results_report.html

(-13552, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INTERRUPTS_execution_results_report.html

(-3450, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMLAMP_execution_results_report.html

(-1736, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMMGMT_execution_results_report.html

(-1298, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INT_BLOODFLOW_execution_results_report.html

(-1134, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INT_BUTTONS_execution_results_report.html

(-2694, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INT_COMMBUFFERS_execution_results_report.html

(-1706, +0)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INT_CPLD_execution_results_report.html

(-1442, +0)

| History

| Source

| Diff

… 49 more files in changeset.

HD-DEN-759-1: comment by pmontazemi "Spaces between 0s."

pmontazemi — Wed, 11 Dec 2019 14:16:03 -0800

pmontazemi (deleted user) commented on HD-DEN-759-1

Spaces between 0s.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Code review fix. Adding rounding to BloodFlow module. +review HD-DEN-759-1

Sean Nash — Wed, 11 Dec 2019 09:56:49 -0800

Sean Nash committed 197ee67 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 395 more in hdfirmware

Code review fix. Adding rounding to BloodFlow module. +review HD-DEN-759-1

· /firmware/App/Common.h

(-0, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.c

(-1, +1)

| History

| Source

| Diff

· /results/VectorCAST.log

(-1040, +533)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_ALARMLAMP_execution_results_report.html

(-52, +53)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_ALARMMGMT_execution_results_report.html

(-116, +117)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_BLOODFLOW_execution_results_report.html

(-192, +193)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_BUTTONS_execution_results_report.html

(-100, +101)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_COMMBUFFERS_execution_results_report.html

(-42, +43)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_COMM_execution_results_report.html

(-48, +49)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_CPLD_execution_results_report.html

(-26, +27)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_FPGA_execution_results_report.html

(-110, +111)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INTERRUPTS_execution_results_report.html

(-42, +43)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMLAMP_execution_results_report.html

(-14, +15)

| History

| Source

| Diff

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMMGMT_execution_results_report.html

(-10, +11)

| History

| Source

| Diff

… 53 more files in changeset.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Fixed white space between brackets throughout. Added some debug code to help troubleshoot comm issue. Updated power of...

Sean Nash — Tue, 10 Dec 2019 18:20:10 -0800

Sean Nash committed 1bbf9da on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 395 more in hdfirmware

Fixed white space between brackets throughout. Added some debug code to help troubleshoot comm issue. Updated power off messaging. +review HD-DEN-759-1

· /firmware/App/Controllers/AlarmLamp.c

(-9, +9)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-14, +59)

| History

| Source

| Diff

· /firmware/App/Drivers/Comm.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/InternalADC.c

(-20, +20)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-9, +9)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.c

(-33, +41)

| History

| Source

| Diff

· /firmware/App/Services/CommBuffers.c

(-27, +27)

| History

| Source

| Diff

· /firmware/App/Services/FPGA.c

(-33, +33)

| History

| Source

| Diff

· /firmware/App/Services/Interrupts.c

(-0, +51)

| History

| Source

| Diff

· /firmware/App/Services/MsgQueues.c

(-16, +16)

| History

| Source

| Diff

· /firmware/App/Services/MsgQueues.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Services/SystemComm.c

(-17, +17)

| History

| Source

| Diff

· /firmware/App/Services/SystemCommMessages.c

(-41, +41)

| History

| Source

| Diff

· /firmware/App/Services/SystemCommMessages.h

(-1, +1)

| History

| Source

| Diff

… 70 more files in changeset.

HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH."

pmontazemi — Tue, 10 Dec 2019 16:44:17 -0800

pmontazemi (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1: comment by pmontazemi "In group setting, decision was made to use the ..."

pmontazemi — Tue, 10 Dec 2019 16:43:01 -0800

pmontazemi (deleted user) replied to pmontazemi (deleted user) in HD-DEN-759-1

In group setting, decision was made to use the () rules applied to [].

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Ran the test suite. Added test suite results folder.

Sean Nash — Fri, 06 Dec 2019 18:38:43 -0800

Sean Nash committed 38f2656 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 395 more in hdfirmware

Ran the test suite. Added test suite results folder.

· /results/VectorCAST.log

(-0, +12306)

| History

| Source

· /results/cppcheck.log

(-0, +122)

| History

| Source

· /results/cppcheckError.log

(-0, +569)

| History

| Source

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_ALARMLAMP_execution_results_report.html

(-0, +5313)

| History

| Source

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_ALARMMGMT_execution_results_report.html

(-0, +12107)

| History

| Source

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_BLOODFLOW_execution_results_report.html

(-0, +16851)

| History

| Source

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_BUTTONS_execution_results_report.html

(-0, +8833)

| History

| Source

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_COMMBUFFERS_execution_results_report.html

(-0, +5105)

| History

| Source

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_COMM_execution_results_report.html

(-0, +3635)

| History

| Source

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_CPLD_execution_results_report.html

(-0, +2073)

| History

| Source

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_FPGA_execution_results_report.html

(-0, +13551)

| History

| Source

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INTERRUPTS_execution_results_report.html

(-0, +3449)

| History

| Source

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMLAMP_execution_results_report.html

(-0, +1735)

| History

| Source

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INT_ALARMMGMT_execution_results_report.html

(-0, +1297)

| History

| Source

· /results/execution/VectorCAST_MinGW_C_LinuxTestSuite_INT_BLOODFLOW_execution_results_report.html

(-0, +1101)

| History

| Source

… 48 more files in changeset.

HD-DEN-759-1: comment by lbaloa "RESOLVED IN CODE WALKTHROUGH"

lbaloa — Fri, 06 Dec 2019 10:12:49 -0800

lbaloa (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH."

pmontazemi — Fri, 06 Dec 2019 10:10:41 -0800

pmontazemi (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH."

pmontazemi — Fri, 06 Dec 2019 10:08:14 -0800

pmontazemi (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH."

pmontazemi — Fri, 06 Dec 2019 10:07:21 -0800

pmontazemi (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH."

pmontazemi — Fri, 06 Dec 2019 10:06:39 -0800

pmontazemi (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH."

pmontazemi — Fri, 06 Dec 2019 10:06:18 -0800

pmontazemi (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH."

pmontazemi — Fri, 06 Dec 2019 10:05:38 -0800

pmontazemi (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1: comment by pmontazemi "What is the rule for arguments between [ ] ? D..."

pmontazemi — Fri, 06 Dec 2019 08:33:55 -0800

pmontazemi (deleted user) commented on HD-DEN-759-1

What is the rule for arguments between [ ] ? Does it need spacing like ( ) ?

HD-DEN-759-1: comment by Sean Nash "Done."

Sean Nash — Fri, 06 Dec 2019 07:45:41 -0800

Sean Nash replied to pmontazemi (deleted user) in HD-DEN-759-1

Done.

HD-DEN-759-1: comment by Sean Nash "Agreed."

Sean Nash — Fri, 06 Dec 2019 07:44:21 -0800

Sean Nash replied to pmontazemi (deleted user) in HD-DEN-759-1

Agreed.

HD-DEN-759-1: comment by Sean Nash "Fixed."

Sean Nash — Thu, 05 Dec 2019 08:45:23 -0800

Sean Nash replied to pmontazemi (deleted user) in HD-DEN-759-1

Fixed.

HD-DEN-759-1: comment by Sean Nash "Sorry - must have changed a different line of c..."

Sean Nash — Thu, 05 Dec 2019 08:43:43 -0800

Sean Nash replied to pmontazemi (deleted user) in HD-DEN-759-1

Sorry - must have changed a different line of code. Now done.

HD-DEN-759-1: comment by pmontazemi "Spaces between arithmetic sign and arguments, a..."

pmontazemi — Thu, 05 Dec 2019 08:42:47 -0800

pmontazemi (deleted user) commented on HD-DEN-759-1

Spaces between arithmetic sign and arguments, also did you want to add spaces between (v, l, and u)? If so, we need to do it everywhere in this code and everywhere else.

HD-DEN-759-1: comment by pmontazemi "I thought we agreed to have spaced between argu..."

pmontazemi — Thu, 05 Dec 2019 08:36:52 -0800

pmontazemi (deleted user) commented on HD-DEN-759-1

I thought we agreed to have spaced between arguments and parentheses?