RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Updated.

They didn't intended to be removed.
Commented for a while and forget to revert back.
Updated.

modified.

OCD?
They where not aligned.

What was wrong with the ; at the end of each line?

Misspelling in word "application", also what is voved?

Remove commented lines.

What is this comment line for?

- Added concurrent in Project as document says. I don't know why it's required since it was working event without adding it. Added anyway.

- Added required fonts as part of the repo. They should not be added as resources since they are huge and make application unnecessary big and is not required and should be referred to as a real file not as a qrc:/ .

· /denali.pro	(-1, +1)	| History	| Source	| Diff
· /resources/fonts/Barlow-Black.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-BlackItalic.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-Bold.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-BoldItalic.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-ExtraBold.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-ExtraBoldItalic.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-ExtraLight.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-ExtraLightItalic.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-Italic.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-Light.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-LightItalic.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-Medium.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-MediumItalic.ttf	(binary)	| History	| Source
· /resources/fonts/Barlow-Regular.ttf	(binary)	| History	| Source	| Diff
… 4 more files in changeset.

]]> Sat, 07 Dec 2019 11:49:30 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Dara Navaei Closed UI-DEN-626-1 ]]> Sat, 07 Dec 2019 11:37:35 -0800 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Dara Navaei finished reviewing UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> Thu, 05 Dec 2019 10:02:56 -0800 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 pmontazemi  (deleted user) finished reviewing UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> Wed, 04 Dec 2019 08:52:51 -0800 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 lbaloa  (deleted user) finished reviewing UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> Wed, 04 Dec 2019 08:51:51 -0800 lbaloa https://devapps.diality.us/cru/UI-DEN-626-1/#c450 https://devapps.diality.us/cru/UI-DEN-626-1/#c450 lbaloa  (deleted user) replied to lbaloa  (deleted user) in UI-DEN-626-1

RESOLVED

Leo,

Resolving the case in not enough, you also need to reply to Behrouz's last comment and mention the word "RESOLVED", otherwise, Dara's Crucible script won't pick this code review up. We will review this next week during the training.

seems like when I replied the emails were not working
Just as a reminder.

Thanks for the comment.

static class member variable can not be initialized in header.
Please take a look at the applicationcontroller.cpp@21.
It has been initialized with nullptr.

Note : To see the whole file content on the top right click on the "View" menu and select "Full Context"

initialize with nullptr for consistency