Fisheye on dgfirmware/firmware/App/Services/SystemComm.c https://devapps.diality.us/changelog/~br%3DDEN-3421-dg-heat-disinfection/dgfirmware/firmware/App/Services/SystemComm.c Recent activity in "dgfirmware" under directory /firmware/App/Services/SystemComm.c dgfirmware (DEN-3421-dg-heat-disinfection): DEN-3421 addressed the code review comments. Worke on the thermistors and fans drivers Sat, 21 Nov 2020 10:09:40 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=f9b3862d01ce6c64bd05b8649e69b44fa155b8e0 https://devapps.diality.us/changelog/dgfirmware?cs=f9b3862d01ce6c64bd05b8649e69b44fa155b8e0 Dara Navaei committed f9b3862 on branch DEN-3421-dg-heat-disinfection in dgfirmware DEN-3421 addressed the code review comments. Worke on the thermistors and fans drivers

· /firmware/App/Controllers/DrainPump.c (-97, +48) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-7, +8) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-17, +28) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-123, +24) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-9, +4) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +0) | History | Source | Diff
· /firmware/App/Controllers/Thermistors.c (-14, +16) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-0, +6) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-7, +5) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-66, +26) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-4, +1) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-1, +4) | History | Source | Diff
]]> dgfirmware (DEN-3421-dg-heat-disinfection): DEN-3421 continued adding more details to the drivers and addressed code review comments Mon, 16 Nov 2020 22:25:27 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=58129c9bb3053c39efa07f60e975f17e2a04755a https://devapps.diality.us/changelog/dgfirmware?cs=58129c9bb3053c39efa07f60e975f17e2a04755a Dara Navaei committed 58129c9 on branch DEN-3421-dg-heat-disinfection in dgfirmware DEN-3421 continued adding more details to the drivers and addressed code review comments

· /firmware/App/Controllers/DrainPump.c (-182, +188) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-5, +6) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-152, +158) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-8, +12) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +13) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-35, +100) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-3, +9) | History | Source | Diff
]]> dgfirmware (DEN-3421-dg-heat-disinfection): DEN-3421 addressed code review comments and reviewed all the doxygen texts in RO pump Sun, 15 Nov 2020 17:59:03 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=62a4d7b976107f7ac4d5013ce06f38f4a0bf65bd https://devapps.diality.us/changelog/dgfirmware?cs=62a4d7b976107f7ac4d5013ce06f38f4a0bf65bd Dara Navaei committed 62a4d7b on branch DEN-3421-dg-heat-disinfection in dgfirmware DEN-3421 addressed code review comments and reviewed all the doxygen texts in RO pump

· /firmware/App/Controllers/Fans.c (-16, +12) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-2, +0) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-298, +377) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-5, +8) | History | Source | Diff
· /firmware/App/Controllers/Thermistors.c (-10, +10) | History | Source | Diff
· /firmware/App/Controllers/Thermistors.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.c (-71, +64) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.h (-1, +1) | History | Source | Diff
· /firmware/App/DGCommon.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-2, +7) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.h (-0, +10) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-1, +2) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-2, +12) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +18) | History | Source | Diff
… 3 more files in changeset.
]]> dgfirmware (DEN-3421-dg-heat-disinfection): DEN-3421 addressed code review comments Fri, 13 Nov 2020 09:37:27 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=d00ad426d849083922332f832e88e7137a1cad60 https://devapps.diality.us/changelog/dgfirmware?cs=d00ad426d849083922332f832e88e7137a1cad60 Dara Navaei committed d00ad42 on branch DEN-3421-dg-heat-disinfection in dgfirmware DEN-3421 addressed code review comments

· /firmware/App/Controllers/Fans.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/Thermistors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.c (-26, +48) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.h (-6, +6) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-3, +4) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-19, +38) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-2, +5) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-13, +50) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +5) | History | Source | Diff
]]> dgfirmware (DEN-3421-dg-heat-disinfection): DEN-3421 addressed code review comments and worked on UV reactors driver Mon, 26 Oct 2020 09:02:34 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=1538c71d0c6b97469d599befce15f068d9acf5d4 https://devapps.diality.us/changelog/dgfirmware?cs=1538c71d0c6b97469d599befce15f068d9acf5d4 Dara Navaei committed 1538c71 on branch DEN-3421-dg-heat-disinfection in dgfirmware DEN-3421 addressed code review comments and worked on UV reactors driver

· /firmware/App/Controllers/DrainPump.c (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-2, +0) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.c (-38, +371) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.h (-8, +9) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-8, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +8) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +63) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +6) | History | Source | Diff
]]> dgfirmware (DEN-3421-dg-heat-disinfection): DEN-3421 merged master Thu, 08 Oct 2020 17:56:21 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=ab304e2ca6e3e40ed8cb12650e9855ae0b9649d8 https://devapps.diality.us/changelog/dgfirmware?cs=ab304e2ca6e3e40ed8cb12650e9855ae0b9649d8 Dara Navaei committed ab304e2 on branch DEN-3421-dg-heat-disinfection in dgfirmware DEN-3421 merged master

· /firmware/App/Controllers/DrainPump.c (-45, +67) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-46, +154) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-4, +7) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-431, +414) | History | Source | Diff
· /firmware/App/DGCommon.h (-3, +9) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-10, +14) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.h (-2, +3) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-21, +43) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-24, +33) | History | Source | Diff
· /firmware/App/Services/MessagePayloads.h (-0, +141) | History | Source
· /firmware/App/Services/PIControllers.c (-40, +35) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-15, +14) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-353, +402) | History | Source | Diff
· /firmware/App/Services/SystemComm.h (-37, +43) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-367, +919) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-4, +49) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces Mon, 31 Aug 2020 13:43:47 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=54f45c387430e440ab4607451fc84dea61f273f1 https://devapps.diality.us/changelog/dgfirmware?cs=54f45c387430e440ab4607451fc84dea61f273f1 Dara Navaei committed 54f45c3 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 231 more in dgfirmware Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff
… 61 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4322: Addressed code review Wed, 26 Aug 2020 11:43:58 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=2505e43eaab426e0de49f67ebb9b78efcfd13f55 https://devapps.diality.us/changelog/dgfirmware?cs=2505e43eaab426e0de49f67ebb9b78efcfd13f55 Quang Nguyen <qnguyen@diality.com> committed 2505e43 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 232 more in dgfirmware DEN-4322: Addressed code review

· /firmware/App/Controllers/ConductivitySensors.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +4) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-0, +1) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-9, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4534: Updated doxygen for App/Services Mon, 24 Aug 2020 19:44:13 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=5e0cd9b5be11ff4b2acaadbdcafc4ffe05172aa1 https://devapps.diality.us/changelog/dgfirmware?cs=5e0cd9b5be11ff4b2acaadbdcafc4ffe05172aa1 Quang Nguyen <qnguyen@diality.com> committed 5e0cd9b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 233 more in dgfirmware DEN-4534: Updated doxygen for App/Services

· /firmware/App/Services/AlarmMgmt.c (-51, +43) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-21, +18) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-59, +58) | History | Source | Diff
· /firmware/App/Services/CommBuffers.h (-18, +30) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-195, +193) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-1, +11) | History | Source | Diff
· /firmware/App/Services/Interrupts.c (-18, +19) | History | Source | Diff
· /firmware/App/Services/MessagePayloads.h (-50, +65) | History | Source | Diff
· /firmware/App/Services/MsgQueues.c (-25, +31) | History | Source | Diff
· /firmware/App/Services/MsgQueues.h (-15, +30) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-20, +19) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-17, +16) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-40, +31) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-5, +4) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-63, +58) | History | Source | Diff
… 5 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces Wed, 19 Aug 2020 14:56:33 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=dc0d9b087c609e71cacdb7f0395cccf29d749c00 https://devapps.diality.us/changelog/dgfirmware?cs=dc0d9b087c609e71cacdb7f0395cccf29d749c00 Dara Navaei committed dc0d9b0 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 233 more in dgfirmware Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /firmware/App/Controllers/DrainPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff
· /firmware/App/DGCommon.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/CPLD.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/Comm.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-2, +2) | History | Source | Diff
… 24 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4217: Fixed merge conflicts and Vectorcast issues. Wed, 19 Aug 2020 14:41:45 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=f308cc4c35eab630ebbbde405cfe47d049afeafb https://devapps.diality.us/changelog/dgfirmware?cs=f308cc4c35eab630ebbbde405cfe47d049afeafb Sean Nash committed f308cc4 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 234 more in dgfirmware DEN-4217: Fixed merge conflicts and Vectorcast issues.

· /firmware/App/Controllers/DrainPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-15, +16) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-53, +121) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-286, +297) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +10) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-4, +11) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-2, +6) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-5, +14) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-2, +2) | History | Source | Diff
… 17 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4322: Addressed code reviews Mon, 17 Aug 2020 09:56:15 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=66c624837b7b915415810e67249048ce5a46c163 https://devapps.diality.us/changelog/dgfirmware?cs=66c624837b7b915415810e67249048ce5a46c163 Quang Nguyen <qnguyen@diality.com> committed 66c6248 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 233 more in dgfirmware DEN-4322: Addressed code reviews

· /firmware/App/Controllers/ConductivitySensors.c (-88, +19) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-5, +7) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/PersistentAlarm.c (-174, +0) | History | Source | Diff
· /firmware/App/Services/PersistentAlarm.h (-39, +0) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4217: Updated @param formats in all modules. Thu, 13 Aug 2020 17:03:55 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=8e6488e189349e0f87f2fb21fa8176aced0b5a43 https://devapps.diality.us/changelog/dgfirmware?cs=8e6488e189349e0f87f2fb21fa8176aced0b5a43 Sean Nash committed 8e6488e on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 234 more in dgfirmware DEN-4217: Updated @param formats in all modules.

· /firmware/App/Controllers/DrainPump.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-24, +6) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-4, +4) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-9, +6) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-22, +25) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-10, +10) | History | Source | Diff
· /firmware/App/Drivers/CPLD.c (-6, +3) | History | Source | Diff
· /firmware/App/Drivers/Comm.c (-17, +0) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-6, +5) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-16, +14) | History | Source | Diff
… 10 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces Thu, 13 Aug 2020 15:01:06 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=8c3db9c2d3957a1a9d53ad5d20d9594a09bc21be https://devapps.diality.us/changelog/dgfirmware?cs=8c3db9c2d3957a1a9d53ad5d20d9594a09bc21be Dara Navaei committed 8c3db9c on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 234 more in dgfirmware Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-3421-dg-heat-disinfection): DEN-3421 Addressed code review comments Wed, 12 Aug 2020 15:08:22 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=daf8d5b60c753becab80cbaf164aac0e49d533a2 https://devapps.diality.us/changelog/dgfirmware?cs=daf8d5b60c753becab80cbaf164aac0e49d533a2 Dara Navaei committed daf8d5b on branch DEN-3421-dg-heat-disinfection in dgfirmware DEN-3421 Addressed code review comments

· /firmware/App/Controllers/DrainPump.c (-74, +72) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-0, +5) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-99, +93) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-226, +226) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-3, +2) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-3, +3) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-2, +0) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-34, +40) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4217: Addressed code review comments. Tue, 11 Aug 2020 15:15:18 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=56b304f221d78b5b34e1431fba3544cf9e0b40a9 https://devapps.diality.us/changelog/dgfirmware?cs=56b304f221d78b5b34e1431fba3544cf9e0b40a9 Sean Nash committed 56b304f on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 234 more in dgfirmware DEN-4217: Addressed code review comments.

· /firmware/App/Services/SystemComm.c (-3, +3) | History | Source | Diff
· /results/Build_Status_Report.csv (-4, +4) | History | Source | Diff
· /results/VectorCAST.log (-3380, +5767) | History | Source | Diff
· /results/cppcheck.log (-58, +65) | History | Source | Diff
· /results/cppcheckError.csv (-80, +81) | History | Source | Diff
]]> dgfirmware (DEN-3421-dg-heat-disinfection): DEN-3421 added commands and messages for heat disinfection mode Tue, 04 Aug 2020 11:26:19 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=44cc25461e4936f7928904640c87a03ef7cf3c16 https://devapps.diality.us/changelog/dgfirmware?cs=44cc25461e4936f7928904640c87a03ef7cf3c16 Dara Navaei committed 44cc254 on branch DEN-3421-dg-heat-disinfection in dgfirmware DEN-3421 added commands and messages for heat disinfection mode

· /firmware/App/Controllers/TemperatureSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-63, +360) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.h (-1, +16) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +16) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-10, +131) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +20) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Updated message id for drain pump set rpm override Mon, 03 Aug 2020 09:19:00 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=d28fcb7b6b6a09dc3c11cba64b786e270e39ec41 https://devapps.diality.us/changelog/dgfirmware?cs=d28fcb7b6b6a09dc3c11cba64b786e270e39ec41 Quang Nguyen <qnguyen@diality.com> committed d28fcb7 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 234 more in dgfirmware Updated message id for drain pump set rpm override

· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Updated message id for drain pump set rpm override Mon, 03 Aug 2020 09:19:00 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=2a88e9acf15658fb4ed6515c486a230cb4490452 https://devapps.diality.us/changelog/dgfirmware?cs=2a88e9acf15658fb4ed6515c486a230cb4490452 Quang Nguyen <qnguyen@diality.com> committed 2a88e9a on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 235 more in dgfirmware Updated message id for drain pump set rpm override

· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4217: Added and implemented accelerometer module. Increased fan PWM frequency to 25KHz. Wed, 29 Jul 2020 17:20:26 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=73113d51d6ca20fd4e34d69d241fbb18bb70dc1e https://devapps.diality.us/changelog/dgfirmware?cs=73113d51d6ca20fd4e34d69d241fbb18bb70dc1e Sean Nash committed 73113d5 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 234 more in dgfirmware DEN-4217: Added and implemented accelerometer module. Increased fan PWM frequency to 25KHz.

· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
· /firmware/App/DGCommon.h (-0, +1) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-2, +10) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-0, +56) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-0, +4) | History | Source | Diff
· /firmware/App/Services/MessagePayloads.h (-0, +131) | History | Source
· /firmware/App/Services/Reservoirs.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +17) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-83, +113) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +15) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-1, +7) | History | Source | Diff
· /firmware/DG.dil (-7, +7) | History | Source | Diff
· /firmware/include/etpwm.h (-1, +1) | History | Source | Diff
· /firmware/source/etpwm.c (-1, +1) | History | Source | Diff
· /firmware/source/sys_main.c (-0, +2) | History | Source | Diff
]]> dgfirmware (DEN-3421-dg-heat-disinfection): DEN-3421 added functions to DrainPump.c/h and ROPump.c/h to support open loop and closed loop control modes. Added the c... Mon, 27 Jul 2020 21:08:53 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=1d235091e158221f1fa8b1579140905a13249a54 https://devapps.diality.us/changelog/dgfirmware?cs=1d235091e158221f1fa8b1579140905a13249a54 Dara Navaei committed 1d23509 on branch DEN-3421-dg-heat-disinfection in dgfirmware DEN-3421 added functions to DrainPump.c/h and ROPump.c/h to support open loop and closed loop control modes. Added the command functions for Dialin

· /firmware/App/Controllers/DrainPump.c (-48, +124) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-2, +6) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-124, +117) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-13, +6) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +9) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-8, +48) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +8) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces Fri, 24 Jul 2020 14:02:27 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=0dec8744af40d0c87a6d7cd1923920c1c2bd1d2f https://devapps.diality.us/changelog/dgfirmware?cs=0dec8744af40d0c87a6d7cd1923920c1c2bd1d2f Dara Navaei committed 0dec874 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 235 more in dgfirmware Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
… 12 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Match HD arrangement for CAN Tx manager. Fri, 24 Jul 2020 13:55:01 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=ea5cb9d5013cc63f0f39d82a6277da3bfd0ae100 https://devapps.diality.us/changelog/dgfirmware?cs=ea5cb9d5013cc63f0f39d82a6277da3bfd0ae100 Sean Nash committed ea5cb9d on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 235 more in dgfirmware Match HD arrangement for CAN Tx manager.

· /firmware/App/Services/SystemComm.c (-11, +7) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Finish fix to Valves module. Allow transition to heat disinfect mode from standby mode. Fix CAN comm logic for when DG... Thu, 23 Jul 2020 19:20:07 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=2db16f950f61815bd8be6d7d300a82eb1f6ee6da https://devapps.diality.us/changelog/dgfirmware?cs=2db16f950f61815bd8be6d7d300a82eb1f6ee6da Sean Nash committed 2db16f9 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 235 more in dgfirmware Finish fix to Valves module. Allow transition to heat disinfect mode from standby mode. Fix CAN comm logic for when DG is alone on bus.

· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff
· /firmware/App/DGCommon.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-1, +2) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-4, +1) | History | Source | Diff
· /firmware/App/Services/CommBuffers.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/Interrupts.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-34, +47) | History | Source | Diff
]]> dgfirmware (DEN-3421-dg-heat-disinfection): DEN-3421 modified the RO pump module and added commands to run from SystemComm Thu, 23 Jul 2020 18:08:58 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=359cf587f2f935ef9f40a16d17c4105efa653c1d https://devapps.diality.us/changelog/dgfirmware?cs=359cf587f2f935ef9f40a16d17c4105efa653c1d Dara Navaei committed 359cf58 on branch DEN-3421-dg-heat-disinfection in dgfirmware DEN-3421 modified the RO pump module and added commands to run from SystemComm

· /firmware/.launches/DG.launch (-0, +5) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-13, +35) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +4) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-36, +51) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-5, +5) | History | Source | Diff
· /firmware/App/DGCommon.h (-3, +3) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-23, +84) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1099, +1059) | History | Source | Diff
· /firmware/App/Services/SystemComm.h (-47, +39) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3922 Added missing break in switch case Thu, 23 Jul 2020 09:32:52 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=8e21697ca3dcab4150ed9945c5ab70d787c673f7 https://devapps.diality.us/changelog/dgfirmware?cs=8e21697ca3dcab4150ed9945c5ab70d787c673f7 Quang Nguyen <qnguyen@diality.com> committed 8e21697 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 236 more in dgfirmware DEN-3922 Added missing break in switch case

· /firmware/App/Services/SystemComm.c (-0, +1) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Added range checks to several functions. Wed, 22 Jul 2020 18:51:03 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=699c4f96ab672fb9db9ac218a5a00358dc68c2c6 https://devapps.diality.us/changelog/dgfirmware?cs=699c4f96ab672fb9db9ac218a5a00358dc68c2c6 Sean Nash committed 699c4f9 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 235 more in dgfirmware Added range checks to several functions.

· /firmware/App/Controllers/TemperatureSensors.c (-10, +14) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-7, +14) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-4, +6) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3922 Addressed code reviews and removed VC previous import errors Tue, 21 Jul 2020 20:56:50 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=5cfa1f3d17db625f92f046868812717e3f1f51c3 https://devapps.diality.us/changelog/dgfirmware?cs=5cfa1f3d17db625f92f046868812717e3f1f51c3 Quang Nguyen <qnguyen@diality.com> committed 5cfa1f3 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 236 more in dgfirmware DEN-3922 Addressed code reviews and removed VC previous import errors

· /firmware/App/Controllers/ConductivitySensors.c (-12, +18) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-2, +0) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-3, +3) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
… 13 more files in changeset.
]]> dgfirmware (DEN-3421-dg-heat-disinfection): Merge branch &#039;DEN-2490-firmware-lockup&#039; into DEN-3421-dg-heat-disinfection Tue, 21 Jul 2020 11:38:33 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=53af4ddc318cc5299f15e3cc1ce506b166e6e156 https://devapps.diality.us/changelog/dgfirmware?cs=53af4ddc318cc5299f15e3cc1ce506b166e6e156 Dara Navaei committed 53af4dd on branch DEN-3421-dg-heat-disinfection in dgfirmware Merge branch 'DEN-2490-firmware-lockup' into DEN-3421-dg-heat-disinfection

· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-5, +5) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-144, +187) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-67, +85) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-5, +3) | History | Source | Diff
]]> dgfirmware (DEN-3421-dg-heat-disinfection): Resolved a merge conflict with master Tue, 21 Jul 2020 11:37:54 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=be5079c95b05c303878763b458dc0854a600317e https://devapps.diality.us/changelog/dgfirmware?cs=be5079c95b05c303878763b458dc0854a600317e Dara Navaei committed be5079c on branch DEN-3421-dg-heat-disinfection in dgfirmware Resolved a merge conflict with master

· /firmware/App/Controllers/DrainPump.c (-17, +18) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-15, +16) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-19, +22) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-15, +16) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-15, +16) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-14, +19) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-15, +16) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.h (-15, +16) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-15, +16) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-15, +16) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-17, +16) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-19, +20) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-15, +16) | History | Source | Diff
]]>