Fisheye on dialin/changelog.md https://devapps.diality.us/changelog/~br%3DDEN-3964-Maintenance/dialin/changelog.md Recent activity in "dialin" under directory /changelog.md DIALIN-DEN-4438-1: closed by Behrouz NematiPour Fri, 28 Aug 2020 16:59:42 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1 https://devapps.diality.us/cru/DIALIN-DEN-4438-1 Behrouz NematiPour Closed DIALIN-DEN-4438-1 ]]> DIALIN-DEN-4438-1: reviewers finished Fri, 28 Aug 2020 16:57:22 -0700 https://devapps.diality.us/cru/DIALIN-DEN-4438-1 https://devapps.diality.us/cru/DIALIN-DEN-4438-1 plucia  (deleted user) and pmontazemi  (deleted user) finished reviewing DIALIN-DEN-4438-1 DIALIN-DEN-4438_Saline Bolus ]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "RESOLVED" Fri, 28 Aug 2020 16:54:25 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4296 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4296 Behrouz NematiPour replied to pmontazemi  (deleted user) in DIALIN-DEN-4438-1

RESOLVED

]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "RESOLVED" Fri, 28 Aug 2020 16:53:15 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4294 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4294 Behrouz NematiPour replied to pmontazemi  (deleted user) in DIALIN-DEN-4438-1

RESOLVED

]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "RESOLVED" Fri, 28 Aug 2020 16:52:59 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4293 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4293 Behrouz NematiPour replied to pmontazemi  (deleted user) in DIALIN-DEN-4438-1

RESOLVED

]]> DIALIN-DEN-4438-1: comment by pmontazemi "OK." Fri, 28 Aug 2020 16:47:02 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4268 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4268 pmontazemi  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4438-1

OK.

]]> DIALIN-DEN-4438-1: comment by pmontazemi "OK." Fri, 28 Aug 2020 16:46:46 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4266 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4266 pmontazemi  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4438-1

OK.

]]> DIALIN-DEN-4438-1: comment by pmontazemi "OK." Fri, 28 Aug 2020 16:46:35 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4264 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4264 pmontazemi  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4438-1

OK.

]]> DIALIN-DEN-4438-1: comment by plucia "RESOLVED" Thu, 27 Aug 2020 12:36:20 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4053 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4053 plucia  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-4438-1

RESOLVED

]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "I tried to remove it but seems like Jira doesn'..." Tue, 25 Aug 2020 13:28:52 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3907 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3907 Behrouz NematiPour commented on DIALIN-DEN-4438-1

I tried to remove it but seems like Jira doesn't listen.
sadly after we discussed in a conversation we had that Sarina arranged, when you told me to merge the staging branch into my working branch I didn't envision at that moment Jira doesn't let us remove it after it has been added.
Fortunately what we currently can do is to only review files in dialin/squish folder.

Thanks,

]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "I have a screen capture that I can't attach her..." Sun, 23 Aug 2020 12:02:03 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3785 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3785 Behrouz NematiPour replied to pmontazemi  (deleted user) in DIALIN-DEN-4438-1

I have a screen capture that I can't attach here and put in X:\Users\PemanM.
As I explained in the image file, I don't quit understand how Squish is managing the last line.
Now I removed extra it shows no empty line at the EOF but I see there is one, prior to that it was showing one but was actually two.
Squish and Jira have different view.
external editor is showing one empty line though.

]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "[~pmontazemi] Could you please review your comm..." Tue, 25 Aug 2020 13:34:29 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3908 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3908 Behrouz NematiPour commented on DIALIN-DEN-4438-1

[~pmontazemi] Could you please review your comments and if it's not in the dialin/squish please keep it for later/related code reviews?
Thanks,

]]> DIALIN-DEN-4438-1: comment by plucia "Can you remove unrelated changesets from this c..." Tue, 25 Aug 2020 11:31:10 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3888 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3888 plucia  (deleted user) commented on DIALIN-DEN-4438-1

Can you remove unrelated changesets from this code review? I'm seeing many of my changes in this review

]]> DIALIN-DEN-4438-1: comment by pmontazemi "RESOLVED." Tue, 25 Aug 2020 09:54:16 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3821 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3821 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-4438-1

RESOLVED.

]]> DIALIN-DEN-4438-1: comment by pmontazemi "RESOLVED." Tue, 25 Aug 2020 09:53:31 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3820 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3820 pmontazemi  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4438-1

RESOLVED.

]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "As a general comment, the only folder which has..." Sun, 23 Aug 2020 12:37:36 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3786 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3786 Behrouz NematiPour commented on DIALIN-DEN-4438-1

As a general comment, the only folder which has to be modified if required for any feature related to a UI Story has to be only dialin/squish/ folder and none of the other files are related to this Story.
The only one comment related to this story has been addressed.
This comment checked as "Needs resolution" so we all see and agree on this topic after it has been resolved.

]]> DIALIN-DEN-4438-1: comment by plucia "Peman this isn't Behrouz's change. I must have ..." Fri, 21 Aug 2020 12:41:34 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3739 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3739 plucia  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-DEN-4438-1

Peman this isn't Behrouz's change. I must have added this as a placeholder. I have now removed it on my development branch, so it can be replaced in the future with the coverage test.

]]> DIALIN-DEN-4438-1: comment by pmontazemi "Why file is empty?" Thu, 20 Aug 2020 21:52:01 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3698 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3698 pmontazemi  (deleted user) commented on DIALIN-DEN-4438-1

Why file is empty?

]]> DIALIN-DEN-4438-1: comment by pmontazemi "Remove extra line." Thu, 20 Aug 2020 21:48:48 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3695 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3695 pmontazemi  (deleted user) commented on DIALIN-DEN-4438-1

Remove extra line.

]]> DIALIN-DEN-4438-1: started by Behrouz NematiPour Fri, 14 Aug 2020 02:39:15 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1 https://devapps.diality.us/cru/DIALIN-DEN-4438-1 Behrouz NematiPour started review DIALIN-DEN-4438-1 ]]> DIALIN-DEN-3593-1: closed by plucia Mon, 20 Jul 2020 12:34:14 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-3593-1 https://devapps.diality.us/cru/DIALIN-DEN-3593-1 plucia  (deleted user) Closed DIALIN-DEN-3593-1 ]]> DIALIN-DEN-3593-1: reviewers finished Mon, 20 Jul 2020 12:21:05 -0700 https://devapps.diality.us/cru/DIALIN-DEN-3593-1 https://devapps.diality.us/cru/DIALIN-DEN-3593-1 Sean Nash and pmontazemi  (deleted user) finished reviewing DIALIN-DEN-3593-1 DIALIN-DEN-3593_Maintenance ]]> DIALIN-DEN-3593-1: comment by pmontazemi "RESOLVED." Mon, 20 Jul 2020 11:13:07 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2830 https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2830 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-3593-1

RESOLVED.

]]> DIALIN-DEN-3593-1: comment by plucia "This file is symbolically linked to dialin/vers..." Mon, 20 Jul 2020 10:19:29 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2821 https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2821 plucia  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-DEN-3593-1

This file is symbolically linked to dialin/version.py - the copyright header is in that file

]]> DIALIN-DEN-3593-1: comment by pmontazemi "Comment says DONE but I still cannot see the co..." Mon, 20 Jul 2020 10:09:27 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2819 https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2819 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-3593-1

Comment says DONE but I still cannot see the copyright header.

]]> DIALIN-DEN-3593-1: comment by pmontazemi "RESOLVED." Mon, 20 Jul 2020 10:08:30 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2818 https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2818 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-3593-1

RESOLVED.

]]> DIALIN-DEN-3593-1: comment by pmontazemi "RESOLVED." Mon, 20 Jul 2020 10:08:18 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2816 https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2816 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-3593-1

RESOLVED.

]]> DIALIN-DEN-3593-1: comment by pmontazemi "RESOLVED." Mon, 20 Jul 2020 10:07:49 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2815 https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2815 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-3593-1

RESOLVED.

]]> DIALIN-DEN-3593-1: comment by pmontazemi "RESOLVED." Mon, 20 Jul 2020 10:07:38 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2814 https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2814 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-3593-1

RESOLVED.

]]> DIALIN-DEN-3593-1: comment by pmontazemi "RESOLVED." Mon, 20 Jul 2020 10:07:27 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2813 https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2813 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-3593-1

RESOLVED.

]]>