Fisheye on dialin/tests/dg_test_script.py https://devapps.diality.us/changelog/~br%3DDEN-3964-Maintenance/dialin/tests/dg_test_script.py Recent activity in "dialin" under directory /tests/dg_test_script.py DIALIN-DEN-4438-1: closed by Behrouz NematiPour Fri, 28 Aug 2020 16:59:42 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1 https://devapps.diality.us/cru/DIALIN-DEN-4438-1 Behrouz NematiPour Closed DIALIN-DEN-4438-1 ]]> DIALIN-DEN-4438-1: reviewers finished Fri, 28 Aug 2020 16:57:22 -0700 https://devapps.diality.us/cru/DIALIN-DEN-4438-1 https://devapps.diality.us/cru/DIALIN-DEN-4438-1 plucia  (deleted user) and pmontazemi  (deleted user) finished reviewing DIALIN-DEN-4438-1 DIALIN-DEN-4438_Saline Bolus ]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "RESOLVED" Fri, 28 Aug 2020 16:54:25 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4296 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4296 Behrouz NematiPour replied to pmontazemi  (deleted user) in DIALIN-DEN-4438-1

RESOLVED

]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "RESOLVED" Fri, 28 Aug 2020 16:53:15 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4294 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4294 Behrouz NematiPour replied to pmontazemi  (deleted user) in DIALIN-DEN-4438-1

RESOLVED

]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "RESOLVED" Fri, 28 Aug 2020 16:52:59 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4293 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4293 Behrouz NematiPour replied to pmontazemi  (deleted user) in DIALIN-DEN-4438-1

RESOLVED

]]> DIALIN-DEN-4438-1: comment by pmontazemi "OK." Fri, 28 Aug 2020 16:47:02 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4268 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4268 pmontazemi  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4438-1

OK.

]]> DIALIN-DEN-4438-1: comment by pmontazemi "OK." Fri, 28 Aug 2020 16:46:46 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4266 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4266 pmontazemi  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4438-1

OK.

]]> DIALIN-DEN-4438-1: comment by pmontazemi "OK." Fri, 28 Aug 2020 16:46:35 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4264 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4264 pmontazemi  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4438-1

OK.

]]> DIALIN-DEN-4438-1: comment by plucia "RESOLVED" Thu, 27 Aug 2020 12:36:20 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4053 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c4053 plucia  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-4438-1

RESOLVED

]]> DIALIN-DEN-4344-1: closed by plucia Wed, 26 Aug 2020 12:02:54 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1 https://devapps.diality.us/cru/DIALIN-DEN-4344-1 plucia  (deleted user) Closed DIALIN-DEN-4344-1 ]]> DIALIN-DEN-4344-1: reviewers finished Wed, 26 Aug 2020 12:01:57 -0700 https://devapps.diality.us/cru/DIALIN-DEN-4344-1 https://devapps.diality.us/cru/DIALIN-DEN-4344-1 Sean Nash and Behrouz NematiPour finished reviewing DIALIN-DEN-4344-1 DIALIN-DEN-4344_Sprint 25 ]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "RESOLVED." Wed, 26 Aug 2020 11:52:21 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c4001 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c4001 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-DEN-4344-1

RESOLVED.

]]> DIALIN-DEN-3964-2-1: closed by plucia Wed, 26 Aug 2020 11:51:36 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-3964-2-1 https://devapps.diality.us/cru/DIALIN-DEN-3964-2-1 plucia  (deleted user) Closed DIALIN-DEN-3964-2-1 ]]> DIALIN-DEN-4344-1: comment by plucia "Okay. It's "Projects" now" Wed, 26 Aug 2020 11:49:12 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c4000 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c4000 plucia  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4344-1

Okay. It's "Projects" now

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "Reminded him again and he is aware of it and ha..." Wed, 26 Aug 2020 11:46:40 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3999 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3999 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-DEN-4344-1

Reminded him again and he is aware of it and has plan to do so.
We use "Projects" and if meanwhile anyone has a non-updated VM will update the folder name manually for now.

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "Yes I told him to update that. Will remind him..." Wed, 26 Aug 2020 11:29:20 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3994 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3994 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-DEN-4344-1

Yes I told him to update that.
Will remind him again.

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "Great, RESOLVED" Wed, 26 Aug 2020 11:28:28 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3993 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3993 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-DEN-4344-1

Great,
RESOLVED

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "great, RESOLVED" Wed, 26 Aug 2020 11:28:16 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3992 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3992 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-DEN-4344-1

great,
RESOLVED

]]> DIALIN-DEN-4344-1: comment by plucia "Have you checked with Dara on this? I think the..." Wed, 26 Aug 2020 10:43:59 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3960 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3960 plucia  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4344-1

Have you checked with Dara on this? I think the VM's are setup with the "~/projects" directory. Systems and V&V both have v4 of those VM's already...

]]> DIALIN-DEN-4344-1: comment by plucia "I had the same thought awhile ago and begin inv..." Wed, 26 Aug 2020 10:41:21 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3958 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3958 plucia  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4344-1

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: http://dvm-linux02:8080/browse/DIAL-23.

]]> DIALIN-DEN-4344-1: comment by plucia "I had the same thought awhile ago and begin inv..." Wed, 26 Aug 2020 10:36:29 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3955 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3955 plucia  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4344-1

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: http://dvm-linux02:8080/browse/DIAL-23.

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "Is there a way to get these values right from c..." Wed, 26 Aug 2020 10:33:27 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3948 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3948 Behrouz NematiPour commented on DIALIN-DEN-4344-1

Is there a way to get these values right from c code of firmware?
Like a scripts which reads the c file and generates this py code.

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "Is there a way to get these values right from c..." Wed, 26 Aug 2020 10:32:33 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3946 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3946 Behrouz NematiPour commented on DIALIN-DEN-4344-1

Is there a way to get these values right from c code of firmware?
Like a scripts which reads the c file and generates this py code.

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "It has been updated in scripts to "Projects"" Wed, 26 Aug 2020 10:25:43 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3945 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3945 Behrouz NematiPour commented on DIALIN-DEN-4344-1

It has been updated in scripts to "Projects"

]]> DIALIN-DEN-3964-2-1: reviewers finished Wed, 26 Aug 2020 10:20:48 -0700 https://devapps.diality.us/cru/DIALIN-DEN-3964-2-1 https://devapps.diality.us/cru/DIALIN-DEN-3964-2-1 Behrouz NematiPour finished reviewing DIALIN-DEN-3964-2-1 DIALIN-DEN-3964_Dialin Maintenance 2 ]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "I tried to remove it but seems like Jira doesn'..." Tue, 25 Aug 2020 13:28:52 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3907 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3907 Behrouz NematiPour commented on DIALIN-DEN-4438-1

I tried to remove it but seems like Jira doesn't listen.
sadly after we discussed in a conversation we had that Sarina arranged, when you told me to merge the staging branch into my working branch I didn't envision at that moment Jira doesn't let us remove it after it has been added.
Fortunately what we currently can do is to only review files in dialin/squish folder.

Thanks,

]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "I have a screen capture that I can't attach her..." Sun, 23 Aug 2020 12:02:03 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3785 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3785 Behrouz NematiPour replied to pmontazemi  (deleted user) in DIALIN-DEN-4438-1

I have a screen capture that I can't attach here and put in X:\Users\PemanM.
As I explained in the image file, I don't quit understand how Squish is managing the last line.
Now I removed extra it shows no empty line at the EOF but I see there is one, prior to that it was showing one but was actually two.
Squish and Jira have different view.
external editor is showing one empty line though.

]]> DIALIN-DEN-4438-1: comment by Behrouz NematiPour "[~pmontazemi] Could you please review your comm..." Tue, 25 Aug 2020 13:34:29 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3908 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3908 Behrouz NematiPour commented on DIALIN-DEN-4438-1

[~pmontazemi] Could you please review your comments and if it's not in the dialin/squish please keep it for later/related code reviews?
Thanks,

]]> DIALIN-DEN-3964-2-1: reviewers finished Tue, 25 Aug 2020 11:46:16 -0700 https://devapps.diality.us/cru/DIALIN-DEN-3964-2-1 https://devapps.diality.us/cru/DIALIN-DEN-3964-2-1 Sean Nash finished reviewing DIALIN-DEN-3964-2-1 DIALIN-DEN-3964_Dialin Maintenance 2 ]]> DIALIN-DEN-4438-1: comment by plucia "Can you remove unrelated changesets from this c..." Tue, 25 Aug 2020 11:31:10 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3888 https://devapps.diality.us/cru/DIALIN-DEN-4438-1/#c3888 plucia  (deleted user) commented on DIALIN-DEN-4438-1

Can you remove unrelated changesets from this code review? I'm seeing many of my changes in this review

]]>