Fisheye on dgfirmware/firmware/App/Modes/ModeRecirculate.h https://devapps.diality.us/changelog/~br%3DDEN-4217-level-and-shock-detection/dgfirmware/firmware/App/Modes/ModeRecirculate.h Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeRecirculate.h DG-DEN-2650-1: closed by Dara Navaei Thu, 19 Oct 2023 08:42:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei Closed DG-DEN-2650-1 ]]> DG-DEN-2650-1: reviewers finished Thu, 19 Oct 2023 08:42:03 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei finished reviewing DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:41:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2650-1: started by Dara Navaei Thu, 19 Oct 2023 08:41:19 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei started review DG-DEN-2650-1 ]]> DG-UCOMMITS-38: closed by Sean Nash Thu, 03 Aug 2023 09:51:06 -0700 Sean Nash https://devapps.diality.us/cru/DG-UCOMMITS-38 https://devapps.diality.us/cru/DG-UCOMMITS-38 Sean Nash Closed DG-UCOMMITS-38 ]]> DG-UCOMMITS-38: reviewers finished Thu, 03 Aug 2023 09:45:10 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-38 https://devapps.diality.us/cru/DG-UCOMMITS-38 Dara Navaei and Sean Nash finished reviewing DG-UCOMMITS-38 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-38: started by Dara Navaei Tue, 23 May 2023 10:14:12 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-38 https://devapps.diality.us/cru/DG-UCOMMITS-38 Dara Navaei started review DG-UCOMMITS-38 ]]> DG-DEN-7802-1: closed by Dara Navaei Thu, 02 Sep 2021 14:34:33 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-7802-1 https://devapps.diality.us/cru/DG-DEN-7802-1 Dara Navaei Closed DG-DEN-7802-1 ]]> DG-DEN-7802-1: reviewers finished Tue, 31 Aug 2021 16:26:59 -0700 https://devapps.diality.us/cru/DG-DEN-7802-1 https://devapps.diality.us/cru/DG-DEN-7802-1 Dara Navaei and Sean Nash finished reviewing DG-DEN-7802-1 DG-DEN-7802_DG-DEV Dialysate Generation ]]> DG-DEN-7802-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 31 Aug 2021 16:20:47 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10832 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10832 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-7802-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7802-1: comment by qnguyen "Nice catch. Fixed." Fri, 27 Aug 2021 15:24:50 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-7802-1/#c10830 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10830 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-7802-1

Nice catch. Fixed.

]]> DG-DEN-7802-1: comment by Sean Nash "The max part of these do not look right (backwa..." Fri, 27 Aug 2021 10:38:24 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10828 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10828 Sean Nash commented on DG-DEN-7802-1

The max part of these do not look right (backward).

]]> DG-DEN-7802-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 19 Aug 2021 10:41:27 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10815 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10815 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-7802-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7802-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 19 Aug 2021 10:41:12 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10814 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10814 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-7802-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7802-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 19 Aug 2021 10:40:45 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10813 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10813 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-7802-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7802-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 19 Aug 2021 10:40:30 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10812 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10812 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-7802-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7802-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 19 Aug 2021 10:40:04 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10811 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10811 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-7802-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7802-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 19 Aug 2021 10:39:47 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10810 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10810 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-7802-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7802-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 19 Aug 2021 10:39:30 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10809 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10809 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-7802-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7802-1: comment by qnguyen "Done." Thu, 19 Aug 2021 10:39:27 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-7802-1/#c10808 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10808 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-7802-1

Done.

]]> DG-DEN-7802-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 19 Aug 2021 10:37:52 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10807 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10807 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-7802-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-7802-1: comment by qnguyen "Done." Thu, 19 Aug 2021 10:13:54 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-7802-1/#c10793 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10793 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-7802-1

Done.

]]> DG-DEN-7802-1: comment by qnguyen "Done." Thu, 19 Aug 2021 10:10:27 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-7802-1/#c10792 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10792 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-7802-1

Done.

]]> DG-DEN-7802-1: comment by qnguyen "Done." Thu, 19 Aug 2021 10:10:20 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-7802-1/#c10791 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10791 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-7802-1

Done.

]]> DG-DEN-7802-1: comment by qnguyen "Done." Thu, 19 Aug 2021 10:08:35 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-7802-1/#c10790 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10790 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-7802-1

Done.

]]> DG-DEN-7802-1: comment by Sean Nash "I would prefer we return a TRUE or FALSE explic..." Thu, 19 Aug 2021 09:26:36 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10789 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10789 Sean Nash commented on DG-DEN-7802-1

I would prefer we return a TRUE or FALSE explicitly (like function below).

]]> DG-DEN-7802-1: comment by qnguyen "Removed." Thu, 19 Aug 2021 09:26:23 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-7802-1/#c10788 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10788 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-7802-1

Removed.

]]> DG-DEN-7802-1: comment by Sean Nash "Start comments w/ capital letter." Thu, 19 Aug 2021 09:25:14 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10787 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10787 Sean Nash commented on DG-DEN-7802-1

Start comments w/ capital letter.

]]> DG-DEN-7802-1: comment by Sean Nash "I know bicarb pump "on" request above does not ..." Thu, 19 Aug 2021 09:23:16 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10786 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10786 Sean Nash commented on DG-DEN-7802-1

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

]]> DG-DEN-7802-1: comment by Sean Nash "I know acid pump "on" request above does not im..." Thu, 19 Aug 2021 09:20:56 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-7802-1/#c10785 https://devapps.diality.us/cru/DG-DEN-7802-1/#c10785 Sean Nash commented on DG-DEN-7802-1

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

]]>