RESOLVED

RESOLVED

RESOLVED

OK.

OK.

OK.

RESOLVED

I tried to remove it but seems like Jira doesn't listen.
sadly after we discussed in a conversation we had that Sarina arranged, when you told me to merge the staging branch into my working branch I didn't envision at that moment Jira doesn't let us remove it after it has been added.
Fortunately what we currently can do is to only review files in dialin/squish folder.

Thanks,

I have a screen capture that I can't attach here and put in X:\Users\PemanM.
As I explained in the image file, I don't quit understand how Squish is managing the last line.
Now I removed extra it shows no empty line at the EOF but I see there is one, prior to that it was showing one but was actually two.
Squish and Jira have different view.
external editor is showing one empty line though.

[~pmontazemi] Could you please review your comments and if it's not in the dialin/squish please keep it for later/related code reviews?
Thanks,

Can you remove unrelated changesets from this code review? I'm seeing many of my changes in this review

RESOLVED.

RESOLVED.

As a general comment, the only folder which has to be modified if required for any feature related to a UI Story has to be only dialin/squish/ folder and none of the other files are related to this Story.
The only one comment related to this story has been addressed.
This comment checked as "Needs resolution" so we all see and agree on this topic after it has been resolved.

Peman this isn't Behrouz's change. I must have added this as a placeholder. I have now removed it on my development branch, so it can be replaced in the future with the coverage test.

Why file is empty?

Remove extra line.

· /changelog.md	(-0, +35)	| History	| Source	| Diff
· /dialin/version.py	(-1, +1)	| History	| Source	| Diff

]]> Mon, 20 Jul 2020 14:58:19 -0700 Peter Lucia <plucia@diality.com> https://devapps.diality.us/changelog/dialin?cs=470124900172c85eb05dcb03b465cf73de854bc8 https://devapps.diality.us/changelog/dialin?cs=470124900172c85eb05dcb03b465cf73de854bc8 Peter Lucia <plucia@diality.com> committed 4701249 on branch 2020_EOY_DEMO, Calibration_fixes and 284 more in dialin Patch to fix invalid dg handler function registration

· /changelog.md	(-0, +5)	| History	| Source	| Diff
· /dialin/version.py	(-1, +1)	| History	| Source	| Diff

]]> Mon, 20 Jul 2020 13:08:26 -0700 Peter Lucia <plucia@diality.com> https://devapps.diality.us/changelog/dialin?cs=9fdcd50fe3d66867e44fe09834168b72ed850ba0 https://devapps.diality.us/changelog/dialin?cs=9fdcd50fe3d66867e44fe09834168b72ed850ba0 Peter Lucia <plucia@diality.com> committed 9fdcd50 on branch 2020_EOY_DEMO, Calibration_fixes and 284 more in dialin Bumping dialin minor version, updated changelog

· /changelog.md	(-0, +24)	| History	| Source	| Diff
· /dialin/version.py	(-1, +1)	| History	| Source	| Diff

]]> Mon, 20 Jul 2020 12:34:14 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-3593-1 https://devapps.diality.us/cru/DIALIN-DEN-3593-1 plucia  (deleted user) Closed DIALIN-DEN-3593-1 ]]> Mon, 20 Jul 2020 12:21:05 -0700 https://devapps.diality.us/cru/DIALIN-DEN-3593-1 https://devapps.diality.us/cru/DIALIN-DEN-3593-1 Sean Nash and pmontazemi  (deleted user) finished reviewing DIALIN-DEN-3593-1 DIALIN-DEN-3593_Maintenance ]]> Mon, 20 Jul 2020 11:13:07 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2830 https://devapps.diality.us/cru/DIALIN-DEN-3593-1/#c2830 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-3593-1

RESOLVED.

This file is symbolically linked to dialin/version.py - the copyright header is in that file

Comment says DONE but I still cannot see the copyright header.

RESOLVED.

RESOLVED.